Message-ID: <46C41730.3060009@shadowen.org>
Date: Thu, 16 Aug 2007 10:21:52 +0100
From: Andy Whitcroft <apw@shadowen.org>
User-Agent: Icedove 1.5.0.9 (X11/20061220)
MIME-Version: 1.0
To: Eugene Teo <eugeneteo@kernel.sg>
CC: linux-kernel@vger.kernel.org, auke-jan.h.kok@intel.com
Subject: Re: [PATCH] Make checkpatch rant about trailing ; at the end of "if"
 expr
References: <20070816052215.GA3857@kernel.sg>
In-Reply-To: <20070816052215.GA3857@kernel.sg>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1570
Lines: 49

Eugene Teo wrote:
> Make checkpatch rant about trailing ; at the end of "if" expression.
> 
> Thanks to Auke for the regexp.
> 
> Signed-off by: Eugene Teo <eugeneteo@kernel.sg>
> 
> --- checkpatch.pl-0.09.default	2007-08-03 23:31:40.000000000 +0800
> +++ checkpatch.pl-0.09	2007-08-16 13:18:40.000000000 +0800
> @@ -1091,6 +1091,12 @@ sub process {
>  				CHK("__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr);
>  			}
>  		}
> +
> +# checks for trailing ; at the end of "if" expression
> +		if ($line =~ /\bif\s*\([^\)]*\)\s*\;/) {
> +			my $herevet = "$here\n" . cat_vet($line) . "\n";
> +			ERROR("trailing ;\n" . $herevet);
> +		}
>  	}
>  
>  	if ($chk_patch && !$is_patch) {

Heh, you are the second person to suggest this check today, do I detect
some ripped out hair due to one of these!

I've taken this idea and expanded it to cover if, for and while which
can all suffer from this.  Using the relative indent to work out which
are valid combinations:

WARNING: Trailing semicolon indicates no statements, indent implies
otherwise
#28: FILE: Z17.c:25:
+       if (foo);
+               return 10;
WARNING: Trailing semicolon indicates no statements, indent implies
otherwise
#31: FILE: Z17.c:28:
+       for (a; b; c);
+               a += *b;

Thanks for the patch.

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/