Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Dec 2022 10:05:25 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Vincent MAILHOL <mailhol.vincent@wanadoo.fr>
Cc:     Frank Jungclaus <frank.jungclaus@esd.eu>,
        linux-can@vger.kernel.org, Wolfgang Grandegger <wg@grandegger.com>,
        Stefan =?utf-8?B?TcOkdGpl?= <stefan.maetje@esd.eu>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] can: esd_usb: Improved decoding for
 ESD_EV_CAN_ERROR_EXT messages
Message-ID: <20221220090525.tvmgmtffmy7ruyi3@pengutronix.de>
References: <20221219212717.1298282-1-frank.jungclaus@esd.eu>
 <20221219212717.1298282-2-frank.jungclaus@esd.eu>
 <CAMZ6RqKMSGpxBbgfD6Q4DB9V0EWmzXknUW6btWudtjDu=uF4iQ@mail.gmail.com>
 <CAMZ6RqKRzJwmMShVT9QKwiQ5LJaQupYqkPkKjhRBsP=12QYpfA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="l2o3hyqitwoctluq"
Content-Disposition: inline
In-Reply-To: <CAMZ6RqKRzJwmMShVT9QKwiQ5LJaQupYqkPkKjhRBsP=12QYpfA@mail.gmail.com>
Precedence: bulk


--l2o3hyqitwoctluq
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 20.12.2022 17:53:28, Vincent MAILHOL wrote:
> > >  struct tx_msg {
> > > @@ -229,10 +237,10 @@ static void esd_usb_rx_event(struct esd_usb_net=
_priv *priv,
> > >         u32 id =3D le32_to_cpu(msg->msg.rx.id) & ESD_IDMASK;
> > >
> > >         if (id =3D=3D ESD_EV_CAN_ERROR_EXT) {
> > > -               u8 state =3D msg->msg.rx.data[0];
> > > -               u8 ecc =3D msg->msg.rx.data[1];
> > > -               u8 rxerr =3D msg->msg.rx.data[2];
> > > -               u8 txerr =3D msg->msg.rx.data[3];
> > > +               u8 state =3D msg->msg.rx.ev_can_err_ext.status;
> > > +               u8 ecc =3D msg->msg.rx.ev_can_err_ext.ecc;
> > > +               u8 rxerr =3D msg->msg.rx.ev_can_err_ext.rec;
> > > +               u8 txerr =3D msg->msg.rx.ev_can_err_ext.tec;
> >
> > I do not like how you have to write msg->msg.rx.something. I think it
> > would be better to make the union within struct esd_usb_msg anonymous:
> >
> >   https://elixir.bootlin.com/linux/latest/source/drivers/net/can/usb/es=
d_usb.c#L169
>=20
> Or maybe just declare esd_usb_msg as an union instead of a struct:

+1

>   union esd_usb_msg {
>           struct header_msg hdr;
>           struct version_msg version;
>           struct version_reply_msg version_reply;
>           struct rx_msg rx;
>           struct tx_msg tx;
>           struct tx_done_msg txdone;
>           struct set_baudrate_msg setbaud;
>           struct id_filter_msg filter;
>   };

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--l2o3hyqitwoctluq
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmOhetIACgkQrX5LkNig
012WuQf+IkVianuuTf4emi0PthBoG9enYth6Nfh6yWTLf0lV3jR5vcMvxG8yumAm
zx1cOZCy5lJmn+TWdEAuqGl7Pe4jC+JNsoZSDMe/2psnH9EVwMonpQFkC5LLi1vt
7+6zDZRHV6xxbAvu4m3cZaGFrWpYFSmUubbXZdnrrvw2TNbX7vMAC5oRXOv6Bio5
3yAX5F7Ax6sKiG/YmkrzaqxlvFWwhu2VT4L4qInKAW0D7ePx7V+IWZ1muKaNUV+j
LqFUqQlAaHJ3CFTkbXaSfw2Y+wGonZ+9mmuPz7j9hUM9PUIATlUAfDrAsbv5y+NZ
c1g2LnpW73YZndeI7oPwqfCf/Tb+Eg==
=9Pzh
-----END PGP SIGNATURE-----

--l2o3hyqitwoctluq--