Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1b466138b931e7c149551a3f5bfcf0edb4eb7932.camel@hadess.net>
Subject: Re: [PATCH] hid: Support for Litra Glow
From:   Bastien Nocera <hadess@hadess.net>
To:     Andreas Bergmeier <abergmeier@gmx.net>,
        Jiri Kosina <jikos@kernel.org>,
        Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Filipe =?ISO-8859-1?Q?La=EDns?= <lains@riseup.net>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 20 Dec 2022 10:22:53 +0100
In-Reply-To: <b787798328560ef3627ba3f8634114d78d3f249a.camel@hadess.net>
References: <9fca69c7-cc24-63d0-98f6-80c28fc69a5@9300>
         <8f00ae9463b07fbd789af3840cd59a9e99caff34.camel@hadess.net>
         <b787798328560ef3627ba3f8634114d78d3f249a.camel@hadess.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2022-12-16 at 15:27 +0100, Bastien Nocera wrote:
> On Fri, 2022-12-16 at 10:53 +0100, Bastien Nocera wrote:
> > On Thu, 2022-12-15 at 22:09 +0100, Andreas Bergmeier wrote:
> > > Tries to implement as general support for Illumination Light as
> > > possible. Note that it is singular, which means by Logitech spec
> > > we
> > > are
> > > fine off with just handling one capability/device.
> > 
> > Your email client absolutely trashed the patch's indentation, it's
> > unreadable as-is.
> > 
> > > Implementation currently only exposes Brightness and On/Off
> > > controls.
> > > Does currently not expose Color Temperature because LEDs does not
> > > support it.
> > > 
> > > Introduces HIDPP_QUIRK_CLASS_SIMPLE_START to prevent reconnect on
> > > startup. Could not get Glow to work with that.
> > 
> > I'd really rather we didn't introduce a new quirk, but instead
> > fixed
> > the fact that we need to restart the HID transport to support 3 (!)
> > devices.
> > 
> > Would something like the attached patch work? I haven't tested it
> > yet,
> > but if it works for you, I'll test it on the devices I have here.
> 
> A tested version attached. I'll need to test it against a T650 before
> sending it for review.

I've tested it with a T650, and it works, so I sent it for review.

Would be great to know if it helps simplify your driver.

Cheers