Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp3876323rwj; Tue, 20 Dec 2022 03:13:23 -0800 (PST) X-Google-Smtp-Source: AMrXdXtpr9PpU9QXIPvwfWV7xl2x5TsDqxOkh7J5TRCUSuzXgovY43W6vRSq/005SqtwNX6IWhQw X-Received: by 2002:a62:388d:0:b0:57c:c79e:2a41 with SMTP id f135-20020a62388d000000b0057cc79e2a41mr26420418pfa.1.1671534803420; Tue, 20 Dec 2022 03:13:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671534803; cv=none; d=google.com; s=arc-20160816; b=yVVkNKu+qdZRkO4gqcHKsdY2o7jhGDWGv447YpO1TCRlZ9/xHUdSAt4s7Cj9+RBdGO N/5E1yzCDvAKdh+vkYIwNz42tBbqOoNq6NOw6u6+INeXRZZ3LaYkaNF+u3E3Bd8fnH8e yf+LLnNQy4ILy9DY1rtNDHixW6TNmORxcekIi6SW8rPCij8C08WVMhQnxz0ac74rsAxb NXswoyCgFjxyVwKqpTKX00LJjBTS7mOC/RsgzESuBpaKZ+wiRhlSQ8pQZUQg7u4x+08d NM7yvNctkNWp+kfIbY/2RJbK2gwFNlIW0pnjiA76S6U+c1GQ1uSHXknHsD0BBxM2X1Eh GJPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=5OR670xRkqSTI0q41azgkxS5SOSeUkXf1WEmUavzHcg=; b=ywZ44Y9qZhGYc2QfU08zlMaQpiin2OSVa3KAXzvT8ALedTumwIFQqSiPkejadGvLEz 7H4rJvi6HNILplovclebauPE+HxuA8cAAFi5Zo4sH6UD6ygcUzunKA7Dw8hlkfCeBHT2 bWLmm4rozZyOjvbWkq1iwes5QN2TEa6rOAIeSG+a6z8hfe8bEJn6a0APwg5RkLpYZAeg vF7st+UcjseG4mzYefXsZvGfe/+dBBL1dJfg11oxgLPKLsVmYomzWsx8v21Ebo0rbkQ/ 2hLbxzMewMAxP2y11YIvcDVE3AGBBiyhIOtdwpbIvBzgo/nPGHB/wqy/N6OJkfDk4BI5 mD1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=n2fRW87D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j8-20020a637a48000000b0046edb8cdbf7si13516159pgn.795.2022.12.20.03.13.13; Tue, 20 Dec 2022 03:13:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=n2fRW87D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229819AbiLTKzE (ORCPT + 70 others); Tue, 20 Dec 2022 05:55:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233215AbiLTKzB (ORCPT ); Tue, 20 Dec 2022 05:55:01 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53561186FE; Tue, 20 Dec 2022 02:55:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671533700; x=1703069700; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=g7pc3I3NQ4mRKhNaYT20es/wLv6RuJ2eCZI41VwUgGg=; b=n2fRW87DRG02oE1TWV9izPox1sYUEnKlQ4zwcGTRH4RlFA6Lo0GMBsk2 58MNBQpEuI4PrQFk85FKczZi52jN4yDNVRv4ebckawxClRP201O4Yyt5m fgT2a0hwtM0cYPuK9FHjp6D46v9R8cU69PFVmUZobC/fJRDKsWlQdxx7R Pn5I6TCrTNvlkpotJw7BZFqPo6bjzukWBjIIHz3R4L1uNU88wqSvVCXWV ka8p2pkL3SbysYz2IQfF2dTUJfLmVHgAi4yVmT372kQopSMkWQOZu2Lz8 frW+SSIVquEJZPXnqizOvDHFNkRkFck7fv5X/lUvUDOjdycvenLuB6Y2a Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="299929245" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="299929245" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2022 02:54:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10566"; a="650952828" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="650952828" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP; 20 Dec 2022 02:54:51 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p7aGn-00CpcS-0N; Tue, 20 Dec 2022 12:54:49 +0200 Date: Tue, 20 Dec 2022 12:54:48 +0200 From: Andy Shevchenko To: "Hawa, Hanna" Cc: Wolfram Sang , Linus Walleij , jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com, jsd@semihalf.com, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, dwmw@amazon.co.uk, benh@amazon.com, ronenk@amazon.com, talel@amazon.com, jonnyc@amazon.com, hanochu@amazon.com, farbere@amazon.com, itamark@amazon.com Subject: Re: [PATCH v2 1/1] i2c: designware: set pinctrl recovery information from device pinctrl Message-ID: References: <20221214142725.23881-1-hhhawa@amazon.com> <1408bbef-10e3-f76b-b66d-b95e84748e18@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 19, 2022 at 09:35:37PM +0200, Hawa, Hanna wrote: > On 12/16/2022 4:46 PM, Andy Shevchenko wrote: > > Can be simplified with help of Elvis: > > > > p = bri->pinctrl ?: dev_pinctrl(dev->parent); > > Can't use this, as need to set the bri->pinctrl to dev_pinctrl() in case > it's not set by the driver. I guess you can. I will answer to the v3. -- With Best Regards, Andy Shevchenko