Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-id: <a80857cb-e3a0-74b2-a7c4-a1afb34e5082@augustwikerfors.se>
Date:   Tue, 20 Dec 2022 12:30:39 +0100
MIME-version: 1.0
Subject: Re: [PATCH] nvme-pci: add NVME_QUIRK_BOGUS_NID for Samsung PM9B1 256G
 and 512G
Content-language: en-US
To:     Christoph Hellwig <hch@lst.de>
Cc:     Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
        Sagi Grimberg <sagi@grimberg.me>,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
        Kanchan Joshi <joshi.k@samsung.com>
References: <20221116171727.4083-1-git@augustwikerfors.se>
 <CGME20221116172324epcas5p3d9877249797ac741ead5785cba27e00e@epcas5p3.samsung.com>
 <20221116171935.GA24524@lst.de> <20221117031951.GB392@test-zns>
 <20221206055928.GB24451@test-zns>
From:   August Wikerfors <git@augustwikerfors.se>
In-reply-to: <20221206055928.GB24451@test-zns>
Content-type: text/plain; charset=UTF-8; format=flowed
Content-transfer-encoding: 7bit
Reporting-Meta: AAGILxLChfRQdNmOHagNzZxsBm++OdYCqjaY8vHGYk7FpcpdeqBieFG87sYLWtZE
 9KAz4qXu7D9U91Btd+Yjlw6FxRtZl6XjVEKGEXZrhEWBTRRCsIwsA6omS0X+6IUm
 RbpExorMWpollADH5GHiIp/ugzlDMlRTHT8tu5PP/P/rBhrWZPCQpR7sE+39OAI2
 B7V4SaaozLh6AwapbQL61+KeYW5SliBUAYJ2eCi0D6V1bgZo6/IxqzzytShcAWXH
 jmmKWiuJ/mKgGFUnQOQ1aFTK4bZMgffUZol7jW9JilxfUODLlwN4d/03Bb1H/IcE
 SPKKrEiiFhE08FBrXemLv0z1BY10D/6Smz5ZjzhSKyzNYkVmFfAZfCzNAT2dCI3B
 GhdiI9+CCBbMUOC+xidO712tTgSmU63fHj2d56hV47j+8uXxaN+UuQYGD7x8m3P1 a1+f1g==
Precedence: bulk

On 2022-12-06 06:59, Kanchan Joshi wrote:
> On Thu, Nov 17, 2022 at 08:49:51AM +0530, Kanchan Joshi wrote:
>> On Wed, Nov 16, 2022 at 06:19:35PM +0100, Christoph Hellwig wrote:
>>> On Wed, Nov 16, 2022 at 06:17:27PM +0100, August Wikerfors wrote:
>>>> The Samsung PM9B1 512G SSD found in some Lenovo Yoga 7 14ARB7 laptop 
>>>> units
>>>> reports eui as 0001000200030004 when resuming from s2idle, causing the
>>>> device to be removed with this error in dmesg:
>>>>
>>>> nvme nvme0: identifiers changed for nsid 1
>>>
>>> What EUI did it report before? Is the identifier stable after
>>> multiple resume cycles?
>>>
>>> Can some of the Samsung folks here reach out to the relevant firmware
>>> team to see if they have any clues?
>>
>> I will check.
> 
> Took more time than I wanted. Firmware team mentioned that issue existed
> in this firmware. This is fixed in new firmware, but bit of travel time
> is involved when official release from OEM (Lenovo) comes out.
> 
> Hope the information is sufficient, and quirk can go in.
> 
> If required, Acked-by: Kanchan Joshi <joshi.k@samsung.com>

Ping, anything left for me to do before this can be merged?

Regards,
August Wikerfors