Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp3942280rwj; Tue, 20 Dec 2022 04:09:26 -0800 (PST) X-Google-Smtp-Source: AA0mqf5O5dqKV2qtDwgZFeV08V9dXH/KdscWS8fXtGlLZv6vG7pceYbPHP14KXd46Ew4rChf3nYm X-Received: by 2002:a17:902:8a8d:b0:189:c536:c745 with SMTP id p13-20020a1709028a8d00b00189c536c745mr41888555plo.2.1671538165994; Tue, 20 Dec 2022 04:09:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671538165; cv=none; d=google.com; s=arc-20160816; b=yiCL/+aR9HQG+l1Ol9IkqtSPv2M9EWPiADl/nfj2+TCcoEtnWcpGiTtgcOpbzLHd1A 93Trr8EgWPO/we4BC3gP5A9znNuDPT4fpZFm8otn7QvgUz5vIQzb6eMWSaKMhQhhfOHh e9M7NNa6sLPhYoSQN40tKMXP9ho4jpyWztQ10U4ctWVMR6+ISId3kpMgQHslDJMekRhp QlJDBDulPRN5+zIoKLXlHjDvNfcVj0axOSAyUbza20QJ/ue3MaV7G/ObQyyq5SCMkJtU KxjkTmccu6rTG8USa7qvQiKbJ/qdx7MrHOH0aufG1UvwmTjFvNWi8ARG1vYtxuBfB1z6 C8zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=t89MKrBwUBLS+ByzcZGzZZQEQJcYQVoYJCazuvi3KIQ=; b=JYQorQB2SwCrSboHvGKRXc7f89iaERefjy/Zol/y9zWFmnDSK/FF1i+Gi6Ggd2QY/k RZ1PRQPjEZ7eN+m8TB+Gg6QC7EgvpaZb+ZuwDVvo5ayUyn/5BFgGcLM6JulaJVUq5r7a Ob5EJ56IM/igyomqollotmJfZbqHr9VYkKxQfAyPtTKaXgdh+hpZlQE3ho98bSOQo3wz g49OPbuCYnFDjiuxdeuMoQhJ2AiJEq5v19P3TXmEcQjN4Uy/RwWNf70wi3lJYAwZNoTB ING1KD7NkkLbVanKvPWlf3aq+dMyFsk2UR+lwqxhv2Rko1XJhh6NfxzssAzCGYpI4XHj +OiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=EAe87txz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l189-20020a6388c6000000b00478cec4767asi13945992pgd.38.2022.12.20.04.09.15; Tue, 20 Dec 2022 04:09:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=EAe87txz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232419AbiLTLjG (ORCPT + 70 others); Tue, 20 Dec 2022 06:39:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229657AbiLTLjE (ORCPT ); Tue, 20 Dec 2022 06:39:04 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 427625F5E for ; Tue, 20 Dec 2022 03:39:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=t89MKrBwUBLS+ByzcZGzZZQEQJcYQVoYJCazuvi3KIQ=; b=EAe87txzRGIH62QagEKuf9gafY x965J8pybTHj1rp6tKY8G9ajKrYYFbG3HvN7WsDG7U61sApoWul5/WISscm0GoO4jK0XNyAnH1nC4 3oIZ85eNPc/j2mSW+Fbm/1O9Im+FtlHNIizu7LMNQQ6QMIeKOafsReKYwdUIniMC1/BCdYFgJTsdZ OaTFDf5b8up5FSRNCSs1FSA0inFoQlbD6V2miDtEsND2LAQgZBpBohUKPy92lE6FT1WkrJIWODbAF sFrhCxHFrzdsawFQdaXbnY+d7VxoLG5VcHTUP+KlQOXmZky+C2KHJI2np255QxfjQQXnmc9HzTD2p pjxiN2Cg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7axW-001kai-Jc; Tue, 20 Dec 2022 11:38:58 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 31E54300E86; Tue, 20 Dec 2022 12:38:47 +0100 (CET) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 12EAE20B0F896; Tue, 20 Dec 2022 12:38:47 +0100 (CET) Date: Tue, 20 Dec 2022 12:38:46 +0100 From: Peter Zijlstra To: Baoquan He Cc: linux-kernel@vger.kernel.org, Thomas Gleixner , x86@kernel.org, kexec@lists.infradead.org Subject: Re: [PATCH] Revert "x86/apic/x2apic: Implement IPI shorthands support" Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 20, 2022 at 01:34:58PM +0800, Baoquan He wrote: > This reverts commit 43931d350f30c6cd8c2f498d54ef7d65750abc92. > > On kvm guest with 4 cpus deployed, when adding 'nr_cpus=2' to normal > kernel's cmdline, and triggering crash to jump to kdump kernel, kdump > kernel will stably hang. Reverting commit 43931d350f30 ("x86/apic/x2apic: > Implement IPI shorthands support") can fix it. > > The problem will disappear if removing 'nr_cpus=2' from normal kerne's > cmdline. And the root cause for this is... ? Does the kvm x2apic emulation somehow get upset when we shorthand CPUs that haven't been initialized?