Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a85e08c6af0fbdafaa6f3799264e92bba7607b9c.camel@collabora.com>
Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-am62-main: Update OTAP and ITAP
 delay select
From:   Sjoerd Simons <sjoerd@collabora.com>
To:     Vignesh Raghavendra <vigneshr@ti.com>, Nishanth Menon <nm@ti.com>
Cc:     martyn.welch@collabora.com, Nitin Yadav <n-yadav@ti.com>,
        Aswath Govindraju <a-govindraju@ti.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Tero Kristo <kristo@kernel.org>, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Date:   Tue, 20 Dec 2022 14:07:14 +0100
In-Reply-To: <b22b6349-9cec-2e86-294a-249f24de2345@ti.com>
References: <20221216143624.23708-1-sjoerd@collabora.com>
         <20221216143624.23708-2-sjoerd@collabora.com>
         <b22b6349-9cec-2e86-294a-249f24de2345@ti.com>
Organization: Collabora Ltd.
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.2-1 
MIME-Version: 1.0
Precedence: bulk

Hey Vignesh

On Tue, 2022-12-20 at 16:49 +0530, Vignesh Raghavendra wrote:
>=20
>=20
> On 16/12/22 8:06 pm, Sjoerd Simons wrote:
> > From: Nitin Yadav <n-yadav@ti.com>
> >=20
> > UHS Class U1 sd-card are not getting detected due to incorrect
> > OTAP/ITAP delay select values in linux. Update OTAP and ITAP
> > delay select values for various speed modes. For sdhci0, update
> > OTAP delay values for ddr52 & HS200 and add ITAP delay for legacy
> > & mmc-hs. For sdhci1 & sdhci2, update OTAP & ITAP delay select
> > recommended as in RIOT for various speed modes.
> >=20
> > Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> > [cherry-pick from vendor BSP]
> > Signed-off-by: Sjoerd Simons <sjoerd@collabora.com>
> > ---
> >=20
> > =C2=A0arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 46 ++++++++++++-------=
-
> > ----
> > =C2=A01 file changed, 24 insertions(+), 22 deletions(-)
> >=20
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > index 03660476364f..28c250a8d1ec 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> > @@ -391,8 +391,10 @@ sdhci0: mmc@fa10000 {
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0ti,clkbuf-sel =3D <0x7>;
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0ti,otap-del-sel-legacy =3D <0x0>;
> > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0ti,otap-del-sel-mmc-hs =3D <0x0>;
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0ti,otap-del-sel-ddr52 =3D <0x9>;
> > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0ti,otap-del-sel-hs200 =3D <0x6>;
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0ti,otap-del-sel-ddr52 =3D <0x5>;
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0ti,otap-del-sel-hs200 =3D <0x5>;
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0ti,itap-del-sel-legacy =3D <0xa>;
>=20
> This is pretty useless without corresponding driver changes=20
> to pick up ti,itap-del-sel-legacy as well

Right; itap-del-sel-legacy is properly documented in the device-tree
binding and was already previously set ofcourse so i didn't pick up it
needed more driver changes. That said the dtb change itself should
still be valid even if not actually applied.

> https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/drivers/mm=
c/host/sdhci_am654.c?h=3Dti-linux-5.10.y&id=3D93d22fc56007ee13e589debf0d32c=
8b1d5fdc6d8
> https://git.ti.com/cgit/ti-linux-kernel/ti-linux-kernel/commit/drivers/mm=
c/host/sdhci_am654.c?h=3Dti-linux-5.10.y&id=3D9c878c3dc642f7f1f3ab6ca7f812c=
d43fe7ed7d8
>=20
> Could you list that cards affected and fixed by this change?

It's a Collabora branded UHS class 1 (SDR104) card; Matching the commit
message indication given by Nitin. So that in particular i guess, will
have been fixed by the change to the ti,otap-del-sel-sdr104 value for
sdhci1.

For the two patches you highlighted above; Is TI planning to upstream
those as well?=20


--=20
Sjoerd Simons
Collabora Ltd.