Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Dec 2022 21:43:08 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     Sean Christopherson <seanjc@google.com>
CC:     Zhang Chen <chen.zhang@intel.com>, <x86@kernel.org>,
        <linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>,
        Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@redhat.com>,
        "Thomas Gleixner" <tglx@linutronix.de>
Subject: Re: [RFC PATCH 5/9] x86/bugs: Use Virtual MSRs to request hardware
 mitigations
Message-ID: <Y6G77CTIk8CvtTLn@gao-cwp>
References: <20221210160046.2608762-1-chen.zhang@intel.com>
 <20221210160046.2608762-6-chen.zhang@intel.com>
 <Y5oviY0471JytWPo@google.com>
 <Y6BtcutjgcgE8dsv@gao-cwp>
 <Y6Cb2OrkQ8X3IvW5@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y6Cb2OrkQ8X3IvW5@google.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?G4dtvIWI4SNusqMpJoBVn1BRChPc/zJFw0ApNFfU1Z6oL0EDoYtHw9ncRWNq?=
 =?us-ascii?Q?bMUL7h0gAbgDCcbvhEQYl53fRFXLxnQ8XK/wU1qZcuzM3tDj4st/QBGdI53l?=
 =?us-ascii?Q?PHionYpeXm5lXqZIVYo3kGBW306+LiA1mxrTnFRXHh1z+dXXp4lkNdEbdpxA?=
 =?us-ascii?Q?ixy7axslIltdVUV8me7KbbfqbBDwcQ8ocVBC278UebWAwgByemc6E8EPkuJY?=
 =?us-ascii?Q?f2KNtMHA/HoFF0wNHkoPfO61jhHcQIIPov9JqVO/rT7PFzRMEXuJudqI/b5m?=
 =?us-ascii?Q?RBIjEalfI3FG3nArEopDzY8cDG/tnPmR1gZFOGg0i5Y5JitMYZM8NawypO2e?=
 =?us-ascii?Q?+muopWdL5bLuzTA/xgwF4UeTCePiVdFdTg6LIM9IHLk1Q+mZ/JEUqHI+J+GO?=
 =?us-ascii?Q?w717NDWssepQj1osZofwhBoTQTfercz15iRL+MbwMI6MM8SBzEpipIb/X8GT?=
 =?us-ascii?Q?1HM+HAiiUOI8yxBZF160sJP4ncy4C9kQvklfWXJv72hCaeic7pYExv01tmzi?=
 =?us-ascii?Q?/TPeV5luhxfZizljN4vQPDQYs+MBsvsxLSPKOmIdI8fwdhYJ+puVkJH853gj?=
 =?us-ascii?Q?nAj+/sqxfkcsYhDD6vwz+nkPo320sIKHwsJDjfJUFylQrJxT0T83QHJT80T+?=
 =?us-ascii?Q?IO/Fn/kNEmShONaEW65gsvtWWLIhF/WONMNUrKzvbn05Qp6EEDWKTT1ZeaGs?=
 =?us-ascii?Q?FZP0dXCR1/X/4Ve1KXWT9pxdf1acQg1woI5nzyLJd1xRH3SLlQKBo/rW7P0N?=
 =?us-ascii?Q?nrNVEfMFwHdOjSKR679dqd94+7V2dH1t5pkPnfzD9xyjE5E/U4j8JQRgxOD2?=
 =?us-ascii?Q?vm2RSwP7BlEHR05ITxje2FN2nPyryAFWhq3rtqCxngeuYpvSRASeQb8khcAS?=
 =?us-ascii?Q?5BmPI4DwROib6MTL2Kq2KLYkZBmtDFxaItB1kcQH+UJYCL6ocJS3iva1P2vv?=
 =?us-ascii?Q?9SvrJ3dODZGA22D3hwzQcv3+Bv9EoUkYCgUJfdCw626eZTWW3woaWef9mmeG?=
 =?us-ascii?Q?1rQ4lFP2oypg5vL98BRKUwzK8Zl7NQKaKy3y6IHne8SxQK5wN/9gBBrxQ0GA?=
 =?us-ascii?Q?JzoENsgJeQJOZnQGb6WdFjiGzm1B73159y62mZU3HEQHu9q+bbCiJG2evK+h?=
 =?us-ascii?Q?LFroUiNWfAdKUJ3ZCUJXMvieKo59J/g7GoDsYcDedAsCvwLxSoC29rbx9M9B?=
 =?us-ascii?Q?yOgIBpnJLCN15NLLdkz+TUXbGCX8pRN29tSNdv7sHvp4mOYsZGY64RGZmyiF?=
 =?us-ascii?Q?YaSH5Okj/Kc9bLMx5GXiiAK9u/VHdxnMKZfwRoqsdT3lwkoQyM46A+69CKMg?=
 =?us-ascii?Q?64BUQtYG4SkfKlAkFSfrWpszidKBpIDHxNzZGyoBtiACRnbYUjQUe0PhytH5?=
 =?us-ascii?Q?YyIfjnUuzrBbvwQJm0qPi8NEqL1PLL/fSaE7jfp9Ty1wgo1QLcYyS8cPz1Vb?=
 =?us-ascii?Q?Uebf/+Pmxm15bgmiM5rI4Ii0zvOG60WHbDOdugJfcOK7fMrBA4Zah0/yuvv4?=
 =?us-ascii?Q?P8F7PcUZCK3xnoAp/lKHEHW4G/Qt3jwGq3lIgcVWOEQjTy2aib/7/IJhn3Vu?=
 =?us-ascii?Q?Co5uxiiZAfj+GIzpy9WZj07e92IPlCKWaKMncSQl?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c53bd1e3-b6ce-4b9b-5874-08dae2901ed9
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2221.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2022 13:43:05.4418
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kT/B8pRgCuU9kz3JNQY5Yt/JNg6nMSozr4SYGNNQgrLBuX8EM4tR88elNRC+55Hr46Zh3k8zjeH8+C6wBlYWgw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5513
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Dec 19, 2022 at 05:14:00PM +0000, Sean Christopherson wrote:
>On Mon, Dec 19, 2022, Chao Gao wrote:
>> On Wed, Dec 14, 2022 at 08:18:17PM +0000, Sean Christopherson wrote:
>> > To me, this looks like Intel is foisting a paravirt interface on KVM and other
>> > hypervisors without collaborating with said hypervisors' developers and maintainers.
>> >
>> >I get that some of the mitigations are vendor specific, but things like RETPOLINE
>> >aren't vendor specific.  I haven't followed all of the mitigation stuff very
>> >closely, but I wouldn't be surprised if there are mitigations now or in the future
>> >that are common across architectures, e.g. arm64 and x86-64.  Intel doing its own
>> >thing means AMD and arm64 will likely follow suit, and suddenly KVM is supporting
>> >multiple paravirt interfaces for very similar things, without having any control
>> >over the APIs.  That's all kinds of backwards.
>> 
>> But if the interface is defined by KVM rather than Intel, it will likely end up
>> with different interfaces for different VMMs, then Linux guest needs to support
>> all of them. And KVM needs to implement Hyper-V's and Xen's interface to support
>> Hyper-V enlightened and Xen enlightened guest. This is a _real_ problem and
>> complicates KVM/Linux in a similar way as multiple paravirt interfaces.
>
>I never said the PV interfaces should be defined by KVM.  I 100% agree that any
>one hypervisor defining its own interface will suffer the same problem.

I am thinking there are only two options:

1. Intel defines the interface.
2. Every VMM defines its own interface.

Any middle ground between the two options?

>
>I think having a PV interface for coordinating mitigations between host and guest
>is a great idea.  What I don't like is tying the interface to "hardware" and defining

Do you think something below is better than the intel-defined interface?
add a new KVM_CAP_* and a KVM_FEATURE_* in hypervisor CPUID leaf to enumerate
the interface. And add a new virtual MSR 0x4b564dxx for guest to report in-use
software mitigations and assign one bit for each software mitigation. On MSR
write emulation, call into vmx code to enable some hardware mitigations if
the corresponding software mitigations are not effective on host.

I am afraid it is late to switch to above approach because e.g., if Hyper-V
decides to support the intel-defined interface, KVM probably needs to support it
for Hyper-V guests.

Can we emulate IA32_ARCH_CAPABILITIES for AMD guests so that AMD can re-use
intel-defined interface?

>the interface without even trying to collaborate with others.

I will pass on this to related Intel folks and ask them to collaborate with
KVM community on future PV interfaces.