Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp4097773rwj; Tue, 20 Dec 2022 06:08:32 -0800 (PST) X-Google-Smtp-Source: AA0mqf6kL6nxYw0E0EDc/gniWayo6A8164+RDbDyCOclNKTf1r5azd4RFHWW/nTGqvgR4ZxAX7MM X-Received: by 2002:a05:6402:7ca:b0:46b:aa:8564 with SMTP id u10-20020a05640207ca00b0046b00aa8564mr35423017edy.30.1671545312063; Tue, 20 Dec 2022 06:08:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671545312; cv=none; d=google.com; s=arc-20160816; b=Ak+lFd+JYQpeTwenMJ4Ka7zqUwrAJVotDSuNgEC4c4sfd9RenfvaCbA0obY6XKkS8i DrxzIj53mvJyCSRR2DcyzYxn7UMU5DqUuHBDVHl7qhh6XJDHPgl/VVSTX/Lks8+GzbI4 kSLNrx4YpVCkObY/+32NtBk24uvJblJBchAO3vOISOjGDV1uTuDy2a6yYoJejeBDShqk 6IF9q3KCh6gyJGqdY15RTN0aSxgErC8uKHg6SjxHVgifFbiba9KpSa7BSOGtGvnoF68b ItdiL0fvjdX9ApbCeGUETqdrYP239OrXILE4YePf789CBz4WG9F3fsAOqOPzAWvwIMBO WXCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:organization:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=D2LUSIWbewRed3LSO+tNLRqm2CSvR5MB5lI8bT8/wvY=; b=gfQfnDcekyoYvutFCmhq+d+w4F6VC25iVe0NJmAYZedys9ZkBNyus+3tIXmCc7qASW e0bVTE0BUNnG2sCLU1LwagseI1oA9krnIZBnjLM+PF7+4BnxZvPSYzUPtf9SRu6urKA6 lEShuOllO/4wy25VCxtkGgHuMUl3szvyvC3UWigDXCtsKbe/BlaelYAZi8SdzVCB0Bei 4QFjAs+cQW/euzUsayDcJ2if0I8spWYZSrLDPKVuX4UITQZN0NLxQxlT3f8CKMj+V7fb Kfr1Sbqck7BIAR0XxySDry4eYpsjuef03gIeS+NnBsnmBzwV+P8Ce6D36hRln8d88mIZ BPfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="N6xhxa/0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c13-20020a50d64d000000b0046d57bba913si11381207edj.520.2022.12.20.06.08.15; Tue, 20 Dec 2022 06:08:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="N6xhxa/0"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233336AbiLTN6V (ORCPT + 69 others); Tue, 20 Dec 2022 08:58:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229727AbiLTN6R (ORCPT ); Tue, 20 Dec 2022 08:58:17 -0500 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3ECFD1ADB6; Tue, 20 Dec 2022 05:58:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671544696; x=1703080696; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7ENqNGBGxElEKmjL75RbPPosjyOCqTtL2c+cIIbN8kI=; b=N6xhxa/02pZBmbg+pq0mXXz3i74NnCKzZLAzu5Ae/0EyoneJMrfxggLJ t09i9w8QRrffXdsXYxLVltW9yaFkzPCiK3Caa/ctOq2l/o/9ch3IDrN3V //tnrkbKjTA3fymgcP4NAY7zi32tB8dBUc5RT2xitaI8h8OXh2jp79ieM pUa+BX0p3EyV/jMBDuUcewEgDKt64aoyO9gW4WTdA4QqGLG7VyxVaPHmb DhINaMu4e6Tsz+x3Ah1BPTkfB1CPh/ta+mxL+jxRhGgEjDLmLqvV1XVtt eU9rDuzl8dnmKCCqOpxwohpTU7mHWtM2xS37jk81OMqiYm2ec9VMQYr01 g==; X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="317253079" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="317253079" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2022 05:58:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="775319334" X-IronPort-AV: E=Sophos;i="5.96,259,1665471600"; d="scan'208";a="775319334" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004.jf.intel.com with ESMTP; 20 Dec 2022 05:58:13 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1p7d8G-00CtU8-0T; Tue, 20 Dec 2022 15:58:12 +0200 Date: Tue, 20 Dec 2022 15:58:11 +0200 From: Andy Shevchenko To: Dmitry Torokhov Cc: Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/5] gpiolib: of: remove of_get_gpio[_flags]() and of_get_named_gpio_flags() Message-ID: References: <20221219192016.1396950-1-dmitry.torokhov@gmail.com> <20221219192016.1396950-4-dmitry.torokhov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221219192016.1396950-4-dmitry.torokhov@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 19, 2022 at 11:20:15AM -0800, Dmitry Torokhov wrote: > There are no more users of these APIs in the mainline kernel, remove > them. This leaves of_get_named_gpio() as the only legacy OF-specific > API. ... > - desc = of_get_named_gpiod_flags(np, list_name, index, flags); > + desc = of_get_named_gpiod_flags(np, propname, index, NULL); I didn't get it. The commit message and the subject says there are no more users of these APIs, why is it still here? How is it compiled? -- With Best Regards, Andy Shevchenko