Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <65e1f6da-d0eb-2fa1-1457-8a3afe714a9b@kernel.org>
Date:   Tue, 20 Dec 2022 15:09:25 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH 4/7] spi: cadence: Change dt-bindings documentation for
 Cadence XSPI controller
Content-Language: en-US
To:     Witold Sadowski <wsadowski@marvell.com>, broonie@kernel.org
Cc:     linux-spi@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, jpawar@cadence.com,
        pthombar@cadence.com, konrad@cadence.com, wbartczak@marvell.com,
        wzmuda@marvell.com
References: <20221219144254.20883-1-wsadowski@marvell.com>
 <20221219144254.20883-5-wsadowski@marvell.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
In-Reply-To: <20221219144254.20883-5-wsadowski@marvell.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 19/12/2022 15:42, Witold Sadowski wrote:
> Add parameter cdns,read-size.
> Parameter is controlling SDMA read size length.

Use subject prefixes matching the subsystem (git log --oneline -- ...).

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

> 
> Signed-off-by: Witold Sadowski <wsadowski@marvell.com>
> ---
>  Documentation/devicetree/bindings/spi/cdns,xspi.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> index f71a9c74e2ca..1274e3bf68e6 100644
> --- a/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> +++ b/Documentation/devicetree/bindings/spi/cdns,xspi.yaml
> @@ -37,6 +37,10 @@ properties:
>    interrupts:
>      maxItems: 1
>  
> +  cdns,read-size:
> +    items:
> +      - description: size of single SDMA read operation

Why is this a property of DT?

> +
>  required:
>    - compatible
>    - reg
> @@ -60,6 +64,7 @@ examples:
>              reg-names = "io", "sdma", "aux";
>              interrupts = <0 90 IRQ_TYPE_LEVEL_HIGH>;
>              interrupt-parent = <&gic>;
> +            cdns,read-size=<0>;

That's not DT coding style.

>  
>              flash@0 {
>                  compatible = "jedec,spi-nor";

Best regards,
Krzysztof