Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Vernon Yang <vernon2gm@gmail.com>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>
Subject: Re: [PATCH 0/8] Clean up and refinement for maple tree
Thread-Topic: [PATCH 0/8] Clean up and refinement for maple tree
Thread-Index: AQHZFHymZLd/2q9w10GGkrv5FXDz1K5248kA
Date:   Tue, 20 Dec 2022 15:19:08 +0000
Message-ID: <20221220151858.c3bj33jzwjxa3wct@revolver>
References: <20221220140829.1665432-1-vernon2gm@gmail.com>
In-Reply-To: <20221220140829.1665432-1-vernon2gm@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ag+aZqzG41ULQuEW6iwAWUQOCdypHvxj4Vp7u2pUW/A3vnjN/RjRrQMeJtSH?=
 =?us-ascii?Q?jSDVIau1cyDYMhCGKzlSNVpI2RxljhF+U1LCHPJ1BwevAQOJvpzxRqxEdyjP?=
 =?us-ascii?Q?7Mng3yKUimgXBn7jE7FUFYwIqw314hwRKYW2xEL6wUn+yv5/mrL/skTTD790?=
 =?us-ascii?Q?wN6HtSyZKMuHhIQV1Ufke1QWBTgXRT8jqv2q/uf9iVmC2WTHkwNglAiuy+P/?=
 =?us-ascii?Q?WShAZ3lgLwu0+zxyYr3bwtijXxZoaSL9AWv5HA0q+xMxCJmswPZjCI70saR/?=
 =?us-ascii?Q?J1ukyBZMu0n0lzaW4nSZnkOoQCIey6AQhxbhcDPltRnGEX+uPDP8VA+kXP/a?=
 =?us-ascii?Q?yRfDNwjTy9Kg71VUXz6w9e3oDU1a/WvqSa6hTJ83tw83AfiZAtDCN7TOnDf9?=
 =?us-ascii?Q?CC4FAi2vfV9OLwjK9MAYBu7SEhAKLS+643PLV5PlaVoqMlWlyEc1astGnLBj?=
 =?us-ascii?Q?8Ek/cfBXq+fbGlfYfbVwtuG+shLsg5pYo68aHSM7LJHKSS/JRiUXX1y8szgZ?=
 =?us-ascii?Q?bM4/eRH/Py+CW7BtBTzXH1/PdJmpkre2uoqtrnFjpS0/wCPOa6Gy9hN8PuCc?=
 =?us-ascii?Q?9zebSnnQF/i3knesEJW9Wjib8CKjQV91KvpBbuV+1nmighz1v6ZcRx1Hq3xS?=
 =?us-ascii?Q?NqXdrAlgxBjGTZUdfaIFUi6g9gJYRQ3pkJ5hmgxt415R1koTXMG+Ola0ayv7?=
 =?us-ascii?Q?K47USuCUC/MSkoqk97IaivQXb6bYqhR4d/PsLQWk332IaiCJTKbKjGWmt2Qj?=
 =?us-ascii?Q?uUTLHdFb1UTUatViSR2Zj0NzcMR9RNAME0o5I2BVuNfHMJbMrXk/Ef+tsWST?=
 =?us-ascii?Q?mnKmkJ7KrqSLLLz+Qk/8X1vxMt66DVNMYRIXSvBbYyTLHmRP/V3fhsAKTCFM?=
 =?us-ascii?Q?t6Xa/IWjm2uC9hQ2G/8PZxJ44BO25/wYgiR6HZPi7nn+Tk6xNSRFadAF+fhE?=
 =?us-ascii?Q?6htZBq4vAkDwn88xC3/UBeUVYlSIVHM1QFCv6nI+ueC7bGxQC3wlP+sEOyop?=
 =?us-ascii?Q?pryjn25MEoMQBDQ9N/rulPVzNg43/uIDUvvx71yuNIgz9YJ0YRGR2dPI+9m/?=
 =?us-ascii?Q?bvB83v0zFwOwmGSKGq3ksbVCELv2pf1r00pXPtKzIWpWe0DfRGqAm3bfbOp4?=
 =?us-ascii?Q?IaRtbB0bcTIvkUJ2pxBR/YwMuUPa8SBJe9m4VJmOcfitJf95hwq/lmLUos4b?=
 =?us-ascii?Q?ilpGs0YNIAeVHFaSRPeh6kfNrTmZ50sW/GXpICdbV6angB1yVnriENnixggn?=
 =?us-ascii?Q?OOAHViJfLGMlgcEHHlA6DVcH8pVW2LNDuusrskn0Oe8GU8euChtSLSCXNRdQ?=
 =?us-ascii?Q?uEgYfG+m2nxNRrBCsSHo2jrl5Qpp369mBHqh1r0TfOdzc3u5ehQX7aXvVhym?=
 =?us-ascii?Q?5w43vQyXOc+5VJ3/XNPp/jlLJ36UhNpyZCGhX8/iiNLi8qaFhzZxkbrogMER?=
 =?us-ascii?Q?PHHG8ZDWN8Y71Ltd9mTorPlCZ5cqcTw80UG2uTLr+fhtnkRw+Q3tz2jpw8a8?=
 =?us-ascii?Q?M4YQiesel9+aQ+qvcPu9RAEQnVahZr9ERUIDStgA4ok07wkcvJsdU6/0VfNv?=
 =?us-ascii?Q?Bk3Xgmpa1RhYf33ffOznpRjJBCX6Iy3WrldFat82Dyft6npTZnRMlWYgim8T?=
 =?us-ascii?Q?5Q=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <27B852504A6DC549BC02053421620ABA@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cf633bf7-eab8-4529-cc71-08dae29d8a9a
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2022 15:19:08.9333
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: M0oWV0bZ1t3TtMiw4uQke6xhiP2WAWSHQ+OkcDIyjI0EAhJuVi064G9mhTslqgEH/daovmHH/7d8DzVazRmGdA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB7483
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-20_05,2022-12-20_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 suspectscore=0
 adultscore=0 malwarescore=0 spamscore=0 mlxlogscore=999 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2212200126
X-Proofpoint-GUID: 2lYEO1qOdxKm0_fhn287076s6GxMQ708
X-Proofpoint-ORIG-GUID: 2lYEO1qOdxKm0_fhn287076s6GxMQ708
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Vernon Yang <vernon2gm@gmail.com> [221220 09:09]:
> Hello,
>=20
> This patchset clean up and refinement some maple tree code, a few small
> changes make the code easier to understand and for better readability.

Thanks for looking at the maple tree.  It seems somehow this cover
letter is detached from the series found here [1].

All of these look good except 6 and 8, which I have responded to the
actual patch.  I've indicated below which is 6/8 and 8/8.


1. https://lore.kernel.org/linux-mm/20221220142606.1698836-2-vernon2gm@gmai=
l.com/

Please add my reviewed-by to all patches besides 6 & 8.
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

>=20
> Vernon Yang (8):
>   maple_tree: remove extra space and blank line
>   maple_tree: remove extra return statement
>   maple_tree: use mt_node_max() instead of direct operations mt_max[]
>   maple_tree: use macro MA_ROOT_PARENT instead of number
>   maple_tree: remove the redundant code
    ^--- 6

>   maple_tree: change return type of mas_commit_b_node()
>   maple_tree: refine ma_state init from mas_start()
>   maple_tree: refine mab_calc_split function
    ^--- 8
>=20
>  include/linux/maple_tree.h |  6 ------
>  lib/maple_tree.c           | 41 ++++++++++++++------------------------
>  2 files changed, 15 insertions(+), 32 deletions(-)
>=20
> --
> 2.34.1
> =