Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Vernon Yang <vernon2gm@gmail.com>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/8] maple_tree: change return type of mas_commit_b_node()
Thread-Topic: [PATCH 6/8] maple_tree: change return type of
 mas_commit_b_node()
Thread-Index: AQHZFH8Wjm50mACylE+Yuuc9fGTJxa5231oA
Date:   Tue, 20 Dec 2022 15:03:36 +0000
Message-ID: <20221220150310.kfzx5paymtaepbxk@revolver>
References: <20221220142606.1698836-2-vernon2gm@gmail.com>
 <20221220142606.1698836-7-vernon2gm@gmail.com>
In-Reply-To: <20221220142606.1698836-7-vernon2gm@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tm2UWykKegKhHkLR0v6UDRJtDkjKu6NFz4NoG1nUdZTSZYscTVvDSvHUibsI?=
 =?us-ascii?Q?1LIm3VJN+5WvgUJLFbxfTDbvjCIaXWrOyPE/vjQPwlMdT8qxwEbeCrRkgebS?=
 =?us-ascii?Q?lL0SSUm9q7wmVztwG9k78QutTuPP/4xe1NWGZVXxvk1aDE9nBHvxYqZ0Lb09?=
 =?us-ascii?Q?dmeHdqlqkIZ/RZ0bDa0WaR20TZUUZF8gmwvcaUFJj9OlPcd5xiQ24aBi22Gh?=
 =?us-ascii?Q?7nzHdTCaoGnw10Fyv0kCZNs1W0ivT3Z55ucrVcjflg8xRnxydtjAnN2kbZ4j?=
 =?us-ascii?Q?NLLUr7Q8OEhDSDxp/mN4yYLVmlGc0zWdNL4wwGsEyrzQafrhsYCtDPohn+zo?=
 =?us-ascii?Q?S3/pDk09bpvOcFKKxnJ3pxcCZFXgttCTIrrfQ4kzXoDTkBj0hFbiSOizUFR7?=
 =?us-ascii?Q?8j+Qc1+c95WZ/wSVnD+3D+uEelg9v8D9GVrfptwsRAzBCtOCHWXgXhA6wXQg?=
 =?us-ascii?Q?GmqkGWf5dRXsz/Eo+ZjCPmI/mGWtA5QsLRTu0bWoCLFpcgBSrzOVHVYZ9roP?=
 =?us-ascii?Q?hA/zRjk0UNd+EouN9yKbqV4K0RJ98jA885Sw+HVrfayi8jbGJROrQizYMCmR?=
 =?us-ascii?Q?Jrw1qPJ1WIdU5/vekpCVBwcP8Im2hOxBCtF7+tFn9eafzJr4D2EV/Zm+KPkU?=
 =?us-ascii?Q?jh6xe0H67B0RvTak7H428xxZYRDX31s08k9Ecgbljm5GEHoMpdIkVFeudnIH?=
 =?us-ascii?Q?PwUSZ8Cc/8REZWGCqo8RbU26bBzKfR+r9KeRPu8CiRs+GyLg8i2teG3PT/rC?=
 =?us-ascii?Q?FNSDxqOvPpwZRBWtsGsX/FoZCSlRpd9BPpv0+nYnLgyPr/tKezx2nnuu4pHw?=
 =?us-ascii?Q?GtzwjNV6HBSLpmhyl6hRmAr+4L/J6QDt4pdl/dZQ3jijTtB3tMOzF2FcJC95?=
 =?us-ascii?Q?//PJ20yHN6O7EpJ2d62nCPEHKjaWl/Mw5ifwFCvcUOd7F02QKR70/bCQ64YD?=
 =?us-ascii?Q?uUoA4X+pJjli6VPkAB2zvPIMTS5DGdx1sDC49vG2dkvMz0+Acx2DQrnc7iz+?=
 =?us-ascii?Q?/RJzTVueDdL57joTZ+F8EUtyoVfp0wnFf3B80w+reRo3JQ8RxHGe9zY5y+fD?=
 =?us-ascii?Q?h00CneTPkYDiDjIbRk08dHS3Ist3GnkTm4cUHCrJ5hvZZtWMhHJx3Nyiu37E?=
 =?us-ascii?Q?QyR7uICmcM6WvSXn/0wYiRbLahqryv64gFuCAJxb6tDvEWptWLdg9knKtAmt?=
 =?us-ascii?Q?OKmrusVB4oKMCjh+RLB89NsFHZB3oDw1gu2IyzWJ/2QdrnWTZabsxLUsZCz+?=
 =?us-ascii?Q?lFlicjsF2r02kJ8mWStDGkuOSHniYHQLuzBGTPJUVL8EiZG9NGOqJzEqtfPX?=
 =?us-ascii?Q?punoXDeRilgcwtckqsqAdBI6sUSks69gjnuhqNe07dRMxywz4u3uexanPGYC?=
 =?us-ascii?Q?ZGt4aeF+UiX5fG0yV82fquyNk6HqY8EytcbTpiVF20nmQQf2Ssr/OHyP+uk4?=
 =?us-ascii?Q?ZZjL45Hsp07jsw6KSlngevNBDsMuUXziN+Z6fMRix3YAE1d+ajTT28z9VGs8?=
 =?us-ascii?Q?dqA572KEiy2D15UQS8snioF6ymOpHFW5Xbi87Togr5FW5G4lFDdvR6AuN3Dz?=
 =?us-ascii?Q?tsArZEEYvSVw6dBIUNC2FfoyX5/6VDXARaizEYiAaxRF+EVF2xrN4IGcLj/v?=
 =?us-ascii?Q?5w=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <9C9019B08C5AEB4DACA70243A048199E@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 446c2d02-3972-414b-234f-08dae29b5eff
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2022 15:03:36.7465
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: m6YSNwAzk0CaDZLjZreGzQVKufgSEM0Xia7LnJkNYGdrb4ajS0wodw5lunhyay+nfv2cclKyeuPIpsNl5P9qsQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB4717
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-20_05,2022-12-20_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0
 phishscore=0 suspectscore=0 spamscore=0 bulkscore=0 mlxscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2212200124
X-Proofpoint-GUID: NOVwbKynIYuFQvzFVL_LwdHJ37HS1vkh
X-Proofpoint-ORIG-GUID: NOVwbKynIYuFQvzFVL_LwdHJ37HS1vkh
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Vernon Yang <vernon2gm@gmail.com> [221220 09:26]:
> The return value of mas_commit_b_node() function represents whether
> the submit b_node is successful, and can only be false and true, so
> the return value type is bool is more appropriate and for better
> readability.
>=20
> Signed-off-by: Vernon Yang <vernon2gm@gmail.com>
> ---
>  lib/maple_tree.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>=20
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index b3a215dd961e..e7dde4a1d6cb 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -3578,7 +3578,7 @@ static inline bool mas_reuse_node(struct ma_wr_stat=
e *wr_mas,
>   * @b_node: The maple big node
>   * @end: The end of the data.
>   */
> -static inline int mas_commit_b_node(struct ma_wr_state *wr_mas,
> +static inline bool mas_commit_b_node(struct ma_wr_state *wr_mas,
>  			    struct maple_big_node *b_node, unsigned char end)

mas_commit_b_node() can also return the ints from mas_split() and
mas_rebalance().  I'm fine with changing the return, but it seems odd to
only half-change it?

Initially I had a different intention for the return type of int, but it
seems the return isn't used at all from this function.  We should
just change mas_commit_b_node(), mas_split(), and mas_rebalance() to
return type void if we're going to clean it up.

>  {
>  	struct maple_node *node;
> @@ -3598,7 +3598,7 @@ static inline int mas_commit_b_node(struct ma_wr_st=
ate *wr_mas,
> =20
>  	mas_node_count(wr_mas->mas, 1);
>  	if (mas_is_err(wr_mas->mas))
> -		return 0;
> +		return false;
> =20
>  	node =3D mas_pop_node(wr_mas->mas);
>  	node->parent =3D mas_mn(wr_mas->mas)->parent;
> @@ -3607,7 +3607,7 @@ static inline int mas_commit_b_node(struct ma_wr_st=
ate *wr_mas,
>  	mas_replace(wr_mas->mas, false);
>  reuse_node:
>  	mas_update_gap(wr_mas->mas);
> -	return 1;
> +	return true;
>  }
> =20
>  /*
> --=20
> 2.34.1
>=20
> =