Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp4229795rwj; Tue, 20 Dec 2022 07:37:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf7n6QbD0fM0FylBeT2gb3USmifdjFlsSzFpFjAqhLvaTcCVGfhK/ndIDHt+RM/P6JhjD2dv X-Received: by 2002:a17:907:1c0e:b0:7c1:63d1:c4e9 with SMTP id nc14-20020a1709071c0e00b007c163d1c4e9mr42499738ejc.29.1671550648021; Tue, 20 Dec 2022 07:37:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671550648; cv=none; d=google.com; s=arc-20160816; b=LnD8IO4+W0r3+TqYTaTHOtXPBinzqKgHFf4XmSkoVqd9C5h1qp7socaTzQIhbUHJFn L8Vbm9RyFeBDNDimATqqLjD6C/0/1gSwxLxhGrkrNkjt9OWR6FilNOgI5PCC8vNpZuYI ssYwZfs7xil8XEMlHi2WtYOzHQBBQEk1RPt2KAgN8v2aW71iQs8fvOu6tOFsPlmdQflU b18vqGQc0PVSjT8/hsgPmuj7V8nFIqhaMSCmaLzWWLaYzvL4Gjh7s2MtPetd6hf3Qef/ FyV46KLEufbLJ+TawHV4iMACahNvKgUAb6oBisL/6w+XYKaoOKuwKM08uYMLi6P6P0LD cfVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=bMwcEP88aaxPcKpXm4Jr7ZoA7j+pIF0TnJwOHWp6n0E=; b=b5vp4qj4wh6HqT2ueiVFGMm4Uuw3Bgb+r5dd0mdav6x6g5WXYTd0HvIsOwWvuCWUQ5 Be1QKkmD5WJt7guyOC/iyjLh46puWGPSbqJnlsadJHyS5GWXW8Z9h/7tp8eiU/OYp0EP 17yufR0MiYkntG+vLRqR0rDwBiGzEjDUbJMMzHkpH6Z1sE3DaIipvtwTaghpJ2ndpeF/ Pdfjv1dvA8gLnwuy9DdDcvo0DkO92YyDOgKG6dFXhBhLrSqmRkb2LC5gME0X9VW6geV8 zKdmsE3C007ce4ShQrYx0Wzi25hGID5MnDGP2lMuEBXy32mGGCWoWXdV9h8SS8TgJKFc 8vFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eQNZVP7x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mp3-20020a1709071b0300b0078bdbb52361si12064280ejc.209.2022.12.20.07.37.10; Tue, 20 Dec 2022 07:37:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eQNZVP7x; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233364AbiLTPPD (ORCPT + 70 others); Tue, 20 Dec 2022 10:15:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57770 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229861AbiLTPPA (ORCPT ); Tue, 20 Dec 2022 10:15:00 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 23599B4AC for ; Tue, 20 Dec 2022 07:14:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671549265; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=bMwcEP88aaxPcKpXm4Jr7ZoA7j+pIF0TnJwOHWp6n0E=; b=eQNZVP7xmLmiQ/e6P+T5VsSm/WW8/GXyV3vHld0WvAuiOWx+IlWaMJkwWDET8wvpYYleAT 90m8R67uHo8uhHUXGD7RvRZxXX2cdMln98TtES2fc/3291tNQqSbwiluaMne99ObUDi0kV JSU4ETvtQNLsjylbqFsFpRVjh8F+tDk= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-586-uA6-OmjONnKk2VNk8fsJgQ-1; Tue, 20 Dec 2022 10:14:21 -0500 X-MC-Unique: uA6-OmjONnKk2VNk8fsJgQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2C8AE2802E3A; Tue, 20 Dec 2022 15:14:21 +0000 (UTC) Received: from metal.redhat.com (ovpn-194-53.brq.redhat.com [10.40.194.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7DC2D2026D4B; Tue, 20 Dec 2022 15:14:19 +0000 (UTC) From: Daniel Vacek To: Waiman Long , Zefan Li , Tejun Heo , Johannes Weiner Cc: Daniel Vacek , cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] cgroup/cpuset: no need to explicitly init a global static variable Date: Tue, 20 Dec 2022 16:14:15 +0100 Message-Id: <20221220151415.856093-1-neelx@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org cpuset_rwsem is a static variable. It's initialized at build time and so there's no need for explicit runtime init leaking one percpu int. Signed-off-by: Daniel Vacek --- kernel/cgroup/cpuset.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c index a29c0b13706bb..87fe410361b3d 100644 --- a/kernel/cgroup/cpuset.c +++ b/kernel/cgroup/cpuset.c @@ -3281,8 +3281,6 @@ struct cgroup_subsys cpuset_cgrp_subsys = { int __init cpuset_init(void) { - BUG_ON(percpu_init_rwsem(&cpuset_rwsem)); - BUG_ON(!alloc_cpumask_var(&top_cpuset.cpus_allowed, GFP_KERNEL)); BUG_ON(!alloc_cpumask_var(&top_cpuset.effective_cpus, GFP_KERNEL)); BUG_ON(!zalloc_cpumask_var(&top_cpuset.subparts_cpus, GFP_KERNEL)); -- 2.38.1