Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4ec9dbed-1758-d6b4-dc1d-ac42e8c22731@oracle.com>
Date:   Tue, 20 Dec 2022 14:59:14 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Subject: Re: [PATCH] scsi: libsas: Grab the host lock in
 sas_ata_device_link_abort()
Content-Language: en-US
To:     Xingui Yang <yangxingui@huawei.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, niklas.cassel@wdc.com,
        damien.lemoal@opensource.wdc.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com, prime.zeng@hisilicon.com,
        kangfenglong@huawei.com
References: <20221220125349.45091-1-yangxingui@huawei.com>
From:   John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20221220125349.45091-1-yangxingui@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tlp0V0cvR1ZJeVQ3ZmtEN09aQ1FkMHdxQTFrV0RrSUZLUEtRakVGbjRiN09W?=
 =?utf-8?B?UFoySUZrUjBqSFh0SlQ2M3I4Qit0R3Y2RDZyZENBRDQ3ajdZdFhaNit0OW50?=
 =?utf-8?B?RGJ3dkFQd3h5NGRiZENHWjFnUExWdjlWdC9mcUhkc0xHNlc3M0c2TFRYL1hH?=
 =?utf-8?B?NjVTQU81SkFCc0VXNUpwdnpYSlFicWxhNEg1QklXRE9RdFdGSWw4L3Z1MExl?=
 =?utf-8?B?eU8za3ZZMUVZV1FXNStmZ1pGaUl0dWNaMDQ4TDZLblFoVFR2S2J5ajZBYVVM?=
 =?utf-8?B?YzhibTJGc1g5ckVsY25ieTBZMHlNZ2JwdE9qbjV4Yms4YTNMbDhSdnUzaXgv?=
 =?utf-8?B?eWZRT3pZTCsyN1p0SWhNMWczOUtZT29lNXJiZE90a3lZRHZYbEtkRmVIRnhk?=
 =?utf-8?B?RStCL0lVVllKejJ0bFlPZUxaWWRyUXIrUGQ3Z1lFWGNmalBGZkxLQkpWYStJ?=
 =?utf-8?B?dVlidjRZRWNtMXpoNGoxSmw5WEFlanBZVjBFaFlGU1FDWmIzVlF6MnYxZnA2?=
 =?utf-8?B?c3dMSE5qWWMwTDdDWmpqY0wyeWtaWXVLTWM4OFJYa2hCWVBHNUI0NlRaRUlS?=
 =?utf-8?B?Szg2ejVPQnpyTjBkM0tuam1iT0VSYjduSlY0bHZUSERtbzEvUEY5Yjk3bGR0?=
 =?utf-8?B?a2lKYTJkQllTS25DSFdFNStseXl5L0Noa1pGQUxZZU45SFlhaW5pQnRaQ2hF?=
 =?utf-8?B?R1B3OWVNbnBXRmlzK2g3SkZXb3FNRDF5V05DM0hKN20rNkoxMVZ3VjUzYmR3?=
 =?utf-8?B?aUFrbzlENzBOa3NjMFNtQnU2V2NNSmFXczArRmhpZ2pIbk5XR080V0FuUlN3?=
 =?utf-8?B?NVd5blFxdC9ZOFJqdDRxYWVOcnUxN3JmLzhmcmdscjlZWCtjTzZTSjQyVVY4?=
 =?utf-8?B?U2ZkQWtaRFprektQSGdjekIzbnByc0QxRDVGa3d5SWprMVhveHhXSjJncVVP?=
 =?utf-8?B?SU1ZUE50Ukc3TUwvZVN4RHZJRDRxQTB1a0pTbytpc2JJdWlTdDdGek1nWXQx?=
 =?utf-8?B?dVNwcWd0QkJiN21JMFpRMlk5N3NJKzROWUhiMCtTRkNXRFNibW8wakpPbFhh?=
 =?utf-8?B?N3VEbVlac1FtTXZzU2FWNktmWlJ2YUxGRFFKYUJ3eVAwZ01CUXQvSnhkRUhO?=
 =?utf-8?B?MllJSlFwemVFL2s0TnVpNWtiWXZsRkVOdkNqanlVUzZXQVRCTlFDcEU2czJm?=
 =?utf-8?B?NUVIQ2tHK0tkdjNPbFlWSHNVRUFxOW4rYWwrVjBMTXRadlNhSElYaERSNHh3?=
 =?utf-8?B?SytvVWt5dXA3N2ZkdktlOStwb1FiRGY1YUJkdU1sWEE5OWFETlovNnBIaWJa?=
 =?utf-8?B?QVQ0cHpjZERaTVdQeEM5UnExZWpqN01YSlZiRk1HTHJlZ0N3TEFUbGY4bzVN?=
 =?utf-8?B?NEVvNk5TSjVLaExlWm9LREZYdmpzblZKQ1ZTelduVlkxQVBBWThrZDBNa1A0?=
 =?utf-8?B?M3kxSTU3QnVsQXhaejhPOS90S1BpQ21tT0JvSXNpTVhSR1hPYWpmRElwQWJq?=
 =?utf-8?B?UG5adkVKcjJUdGNodUNtNWtzanp4THk3RlpPRWJJMjdpT1dodGNUaytaT0sr?=
 =?utf-8?B?SnpmS0tXZTlvNUw4RDVZTFVwU3FhTWFQZnN0eXNwQm5NR2laemdUSi9FMnZU?=
 =?utf-8?B?VUdudUNFV0ZmYlM1QjRVeXlUMnJVMXNxM3Zvc2R6UTdmK3ZMd2dGVkdvWWph?=
 =?utf-8?B?RUdxK0hpR3kvbVd5cjJsYi9WYzNnc2pibjRDRG5jUWFmL3NwRFY3REZwYlJk?=
 =?utf-8?B?cWNIN25OQUVOV1RHd1FtQWpCZHgyUUI3RFpPeFkyTXlIT3U4R25HZmM1THBQ?=
 =?utf-8?B?RjBxbDFTOFRCWUQrUGRvTGpoeWFPLzhQMVJQbEpFbWtxZUxpUDBERStKVzBa?=
 =?utf-8?B?QjBwMTZVcnBXOXZMZU0xSExLQW45TnhFLzkzaGtIVVB4cG1HMmNHSlFncU1y?=
 =?utf-8?B?bUE0aERyZ1h4UU1WM295NXJLeUwrRHY0aGljYkhYeUN0S0JQNnJpMjRWVEVK?=
 =?utf-8?B?TzJXUDJCekY5VkQ3TlppSGFoUnB4dlpWU0E4NTJvbWdGNW1hV2JkTnB0a1A0?=
 =?utf-8?B?SFlkOU5QdkdzNlA0K2VPSVpWRVF4d1dEVUluZXExWFl4dHJGbnJzeDJNNUxt?=
 =?utf-8?Q?jxFgkZQAETS+sF3Z+/1Tg+ny8?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 601fb6ca-e7e9-4f72-5d14-08dae29ac5ad
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2022 14:59:19.7703
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jBouSxGxFCURhEzRjbSyMqsWzSJJe+jJft1unobkE5XJlWZDumbrUROA+Z/8utAuT5azsMzNHEpBEfpWhiiiRA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6467
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-20_05,2022-12-20_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxlogscore=999
 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 adultscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2212070000 definitions=main-2212200124
X-Proofpoint-GUID: RVDK7yXE_e3eYipk1jgVeiIaSZKcYApA
X-Proofpoint-ORIG-GUID: RVDK7yXE_e3eYipk1jgVeiIaSZKcYApA
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 20/12/2022 12:53, Xingui Yang wrote:
> Grab the host lock in sas_ata_device_link_abort() before calling

This is should be the ata port lock, right? I know that the ata comments 
say differently.

> ata_link_abort(), as the comment in ata_link_abort() mentions.
> 

Can you please add a fixes tag?

> Signed-off-by: Xingui Yang <yangxingui@huawei.com>

Reviewed-by: John Garry <john.g.garry@oracle.com>

> ---
>   drivers/scsi/libsas/sas_ata.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
> index f7439bf9cdc6..4f2017b21e6d 100644
> --- a/drivers/scsi/libsas/sas_ata.c
> +++ b/drivers/scsi/libsas/sas_ata.c
> @@ -889,7 +889,9 @@ void sas_ata_device_link_abort(struct domain_device *device, bool force_reset)
>   {
>   	struct ata_port *ap = device->sata_dev.ap;
>   	struct ata_link *link = &ap->link;
> +	unsigned long flags;
>   
> +	spin_lock_irqsave(ap->lock, flags);
>   	device->sata_dev.fis[2] = ATA_ERR | ATA_DRDY; /* tf status */
>   	device->sata_dev.fis[3] = ATA_ABORTED; /* tf error */
>   
> @@ -897,6 +899,7 @@ void sas_ata_device_link_abort(struct domain_device *device, bool force_reset)
>   	if (force_reset)
>   		link->eh_info.action |= ATA_EH_RESET;
>   	ata_link_abort(link);
> +	spin_unlock_irqrestore(ap->lock, flags);
>   }
>   EXPORT_SYMBOL_GPL(sas_ata_device_link_abort);
>