Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Dec 2022 15:32:15 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Allen Webb <allenwebb@google.com>
Cc:     "linux-modules@vger.kernel.org" <linux-modules@vger.kernel.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Luis Chamberlain <mcgrof@kernel.org>,
        "Rafael J. Wysocki" <rafael@kernel.org>, stable@vger.kernel.org,
        kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v9 01/10] imx: Fix typo
Message-ID: <Y6HHb8alGpMHLpM/@kroah.com>
References: <20221219191855.2010466-1-allenwebb@google.com>
 <20221219204619.2205248-1-allenwebb@google.com>
 <20221219204619.2205248-2-allenwebb@google.com>
 <Y6FZWOC1DSHHZNWy@kroah.com>
 <CAJzde06et8qZPmu=zF13rJt8=v_etMjgTRhv9y75wdrX7doC0g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJzde06et8qZPmu=zF13rJt8=v_etMjgTRhv9y75wdrX7doC0g@mail.gmail.com>
Precedence: bulk

On Tue, Dec 20, 2022 at 08:26:06AM -0600, Allen Webb wrote:
> On Mon, Dec 19, 2022 at 3:23 PM Luis Chamberlain <mcgrof@kernel.org> wrote:
> >
> > On Mon, Dec 19, 2022 at 02:46:09PM -0600, Allen Webb wrote:
> > > A one character difference in the name supplied to MODULE_DEVICE_TABLE
> > > breaks a future patch set, so fix the typo.
> >
> > What behaviour is broken here for older kernels? What would not work
> > that makes this patch worthy of consideration for stable? The commit
> > log should be clear on that.
> >
> > In the future, it may be useful for you to wait at least 1 week or so
> > before sending a new series becuase just a couple of days is not enough
> > if you are getting feedback.
> >
> > So before sending a v10, please give it at least a few days or a week.
> >
> >   Luis
> 
> On Tue, Dec 20, 2022 at 12:42 AM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Mon, Dec 19, 2022 at 02:46:09PM -0600, Allen Webb wrote:
> > > A one character difference in the name supplied to MODULE_DEVICE_TABLE
> > > breaks a future patch set, so fix the typo.
> >
> > Breaking a future change is not worth a stable backport, right?  Doesn't
> > this fix a real issue now?  If so, please explain that.
> >
> > thanks,
> >
> > greg k-h
> 
> I will update the commit message to say that it breaks compilation
> when building imx8mp-blk-ctrl as a module (and so forth for the other
> similar patches).

Can that code be built as a module?  Same for the other changes...