Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221216133125.3159406-1-peternewman@google.com>
In-Reply-To: <20221216133125.3159406-1-peternewman@google.com>
From:   Peter Newman <peternewman@google.com>
Date:   Tue, 20 Dec 2022 17:07:17 +0100
Message-ID: <CALPaoCiQmh-t_Wj8mzr6+_EUo_9x2=xVQOYh0_NSP+sVHGvCtA@mail.gmail.com>
Subject: Re: [PATCH v6] x86/resctrl: Fix task CLOSID/RMID update race
To:     reinette.chatre@intel.com, fenghua.yu@intel.com
Cc:     bp@alien8.de, derkling@google.com, eranian@google.com,
        hpa@zytor.com, james.morse@arm.com, jannh@google.com,
        kpsingh@google.com, linux-kernel@vger.kernel.org, mingo@redhat.com,
        tglx@linutronix.de, x86@kernel.org, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Dec 16, 2022 at 2:31 PM Peter Newman <peternewman@google.com> wrote:
> In a memory bandwidth-metered compute host, malicious jobs could exploit
> this race to remain in a previous CLOSID or RMID in order to dodge a
> class-of-service downgrade imposed by an admin or to steal bandwidth.

After discussing with Reinette some more[1], I think the payoff of
exploiting this is too little for this to concern me, so I'll remove
the paragraph above.

[1] https://lore.kernel.org/lkml/CALPaoCi8hcFzNN9O9fS9Etri_KMdU32UU1tJsfeO1OxR-i1j7g@mail.gmail.com/

Consequently I don't think this fix is critical enough to be needed on
stable, so I'll drop the CC: stable from the update.