Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <02d9ecbd-9b08-9777-f93d-0811edc79b6d@intel.com>
Date:   Tue, 20 Dec 2022 09:32:01 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.0
Subject: Re: [PATCH v9 10/13] x86/resctrl: Add sysfs interface to write
 mbm_total_bytes_config
To:     "Moger, Babu" <Babu.Moger@amd.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>
CC:     "fenghua.yu@intel.com" <fenghua.yu@intel.com>,
        "dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
        "x86@kernel.org" <x86@kernel.org>, "hpa@zytor.com" <hpa@zytor.com>,
        "paulmck@kernel.org" <paulmck@kernel.org>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "quic_neeraju@quicinc.com" <quic_neeraju@quicinc.com>,
        "rdunlap@infradead.org" <rdunlap@infradead.org>,
        "damien.lemoal@opensource.wdc.com" <damien.lemoal@opensource.wdc.com>,
        "songmuchun@bytedance.com" <songmuchun@bytedance.com>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "jpoimboe@kernel.org" <jpoimboe@kernel.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "chang.seok.bae@intel.com" <chang.seok.bae@intel.com>,
        "pawan.kumar.gupta@linux.intel.com" 
        <pawan.kumar.gupta@linux.intel.com>,
        "jmattson@google.com" <jmattson@google.com>,
        "daniel.sneddon@linux.intel.com" <daniel.sneddon@linux.intel.com>,
        "Das1, Sandipan" <Sandipan.Das@amd.com>,
        "tony.luck@intel.com" <tony.luck@intel.com>,
        "james.morse@arm.com" <james.morse@arm.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bagasdotme@gmail.com" <bagasdotme@gmail.com>,
        "eranian@google.com" <eranian@google.com>,
        "christophe.leroy@csgroup.eu" <christophe.leroy@csgroup.eu>,
        "jarkko@kernel.org" <jarkko@kernel.org>,
        "adrian.hunter@intel.com" <adrian.hunter@intel.com>,
        "quic_jiles@quicinc.com" <quic_jiles@quicinc.com>,
        "peternewman@google.com" <peternewman@google.com>
References: <166990882621.17806.16780480657453071426.stgit@bmoger-ubuntu>
 <166990903030.17806.5106229901730558377.stgit@bmoger-ubuntu>
 <084224cb-271f-a1c8-6665-1953b2574495@intel.com>
 <MW3PR12MB4553A194B951DAFBA116894995E59@MW3PR12MB4553.namprd12.prod.outlook.com>
Content-Language: en-US
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <MW3PR12MB4553A194B951DAFBA116894995E59@MW3PR12MB4553.namprd12.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGlyMUM4NHAyZE9MRnFmcklCVmZMclRvMGlielVVNkJ0YUMrd21FdW50V09w?=
 =?utf-8?B?TERYMzBKbGJtMlBJM2ZPM3BGYmlzMXE2L0tpSmhpQkVXV3FPUVlqODFsQm5I?=
 =?utf-8?B?SS9XZzF3MXVnemRMNGlLUTk4bjRuTVE5MGRZS0dGVVhkcmhpY0kwTXBFRWxs?=
 =?utf-8?B?bjN0b25GWDl3Z01oSlg5R0doWXJ2Q3NEd1hPOGhueE92SGtCb0RXOUZCOFIv?=
 =?utf-8?B?a3BaMGVwVkFKU1RRRzdkYy9xYVo5aGNFT2JsczNHU0dWN0ZxZG5Fak5WLzRa?=
 =?utf-8?B?bDlBTWJiWjlzdCt2SkdiYkNPbGRjcy9aUG9MSTN4UWRlSUZYM3pWTUM3cDYw?=
 =?utf-8?B?K0RmNEc0a0NHb29tcU5OVjJBa05sUFBLTzB1M0ViazJiMkcxS0o5c0dxaUxQ?=
 =?utf-8?B?VCtpNE9KeUtyK0xCTVpPUlI0T3lKTVl6UVBwaE9yK0g2bzNpSmRYTDVtdXlK?=
 =?utf-8?B?MGozRDhMK3NuSTBLczFlOXY3T3NBYWdSZTFUTUV2MWlmeWVzU0dabnRvV1U3?=
 =?utf-8?B?Vjd2cXQzM1NsVVVDWDgvTitKdlBIM2daUHhVWkszbEIxVFJXRDBPTUVZcmkz?=
 =?utf-8?B?YWRLYVAwUG11eTlhcWRKSkY0a0FoNnoweGFPN3RnVnhBN3AvVXlGVTVSSHFL?=
 =?utf-8?B?S1RwUVFINHg5MU1LQ0xqa0VaWThXNTlJNklFMzhnKzFLMG1zVTRVTHRWZ293?=
 =?utf-8?B?TDRUeVhGQURCTGp4MksvZGlWTkl4RklKaUFVdndpN1E0OHE3N3cxOUNaUUMz?=
 =?utf-8?B?NGhscUlMVHVwUjVHVzZ1b3FnUVBBb1RPSDB3ek9TSUNQcVVGQ1gvaWx0Nm11?=
 =?utf-8?B?M1gyME5URzN1ZHBpY1ZMeVlHdDFBdFk5dGN2RWpFSlpaMVd5Wi8zb1FQUW1q?=
 =?utf-8?B?U3M5WEJsWjBRbzF3OFhyVWplUWJHazBNY3RVRkRna0pFWVcwSUFudHVqSW9w?=
 =?utf-8?B?L2FHaWJqQ1kxTUk4NEgvKzZEUW9McVF0c1E2Y0xwQkRlRzFNQ0JqNmRLRHlX?=
 =?utf-8?B?TzdmRzg0SEtnbktPWE1qWG12UDllTHI3UDI0bE1mbDN1b25XbkEwdDltVzVn?=
 =?utf-8?B?UEVrN0ZmZGVMcFAybHdKeEtWM1ZoeThVWDhMWHN1cEFxeGllRzFmQ0FsVlMw?=
 =?utf-8?B?UnBJQlBEdzlLRVI1STBxeGRzZjMvcm5ERGNtZVhlbkxsVXlobXN1L1ppVzlY?=
 =?utf-8?B?MkdvZC9WdTNGMlJweDgydjQ0QUcwM094TmZoajdqMERhNVloWGppMm4xN0xp?=
 =?utf-8?B?TzV3YUkzNXNxYk1wYXhMYURnbFNKcHg0RkZmQ2wzeEprR3pid0pVQkc0d1JR?=
 =?utf-8?B?U2dacDY4SGtOb3IrRWFDci80RjlKUnJjblo1RTd4Y3JlUGhjS2JxWUxxbzV0?=
 =?utf-8?B?ankySDFSWmFRb0tiZXZ0Uk5CeEgwQTh3VE1YZlpQTm5YQmpiUmpTeUN1dmlT?=
 =?utf-8?B?UHFyRjZKbUQrZE1EVmo5NGthRlNabDFDNS9pR21xd1JiVXh3a3lRQThYanhJ?=
 =?utf-8?B?ZG1nd3JuOXp0YTUxT0xDRGx0THdlWG96TFRsNUVscHRVU21vSDIxaHZzUkZ2?=
 =?utf-8?B?WGR3a0JCdlNRNnpvbDZJU04yWDFlZGprMmoyKzBxeEN2T1ZiRC9FMjh3Q2dT?=
 =?utf-8?B?bGZxQmVrVnBMbDFjRFNzUzZqZTQvWlRxbnFTbnh0eDlDL2c3V09CZzNjU3pK?=
 =?utf-8?B?enpPQUlRbURUckZNN0RyU21IYkpQaCt1YzUycU9lRm4rQUJtbW84VEJHZVNk?=
 =?utf-8?B?cjB6UExzVVUwZFdNV3VlbURCRUw2cnZNT3NQMHMrQk56MW9ScXYxVmxidHZF?=
 =?utf-8?B?RWJJbGdXcjdBaDBlNmhTODJxYjhJK0lUNnMrblkxZUZScXZyc1Ixc0tkWm1W?=
 =?utf-8?B?Q1lEVDcvNENOdHdHSExwREhIVnJZeUVHYVdRKyt4UEM5YzI4bkttS0NBVmpL?=
 =?utf-8?B?SjFUTXZDdzc2WnNxWUFBNXJEOHN4UGhlQm9vOCtEUk1hUWJDTFlwZzFvVmFF?=
 =?utf-8?B?dmNSOTRMdy9SMXhnamN3MzVJdUMrZVJmL1dwWTVDUkJROHRQMS9Wa3BHTXZs?=
 =?utf-8?B?NEJ2OFRoemZnOWVaYnhKYTZVWTZNb0hqK0tUTmZDNmY3cWE5R1NwZlZ2UGNx?=
 =?utf-8?B?WktRWldLU2VJcTdYaUkveGg1Nk5CVi9obTBKWXdtSXRWUnJ4eE5HOVc2NDd0?=
 =?utf-8?B?Q3c9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: de44cb85-b9ee-41b7-06e1-08dae2b01d50
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2022 17:32:06.2595
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kaTTycL07SUXou8YIO75oq+oLSrsGoB63mrd6urL1mYsgAmh6+9XBpa590gtdZ4WkBRUlDfZr3z2BhNicHcDSd/wttkrLHFvEbwVAc39jl4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6288
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Babu,

On 12/19/2022 11:28 AM, Moger, Babu wrote:
> [AMD Official Use Only - General]
> 
> Hi Reinette,
> 
>> -----Original Message-----
>> From: Reinette Chatre <reinette.chatre@intel.com>
>> Sent: Thursday, December 15, 2022 12:25 PM
>> To: Moger, Babu <Babu.Moger@amd.com>; corbet@lwn.net;
>> tglx@linutronix.de; mingo@redhat.com; bp@alien8.de
>> Cc: fenghua.yu@intel.com; dave.hansen@linux.intel.com; x86@kernel.org;
>> hpa@zytor.com; paulmck@kernel.org; akpm@linux-foundation.org;
>> quic_neeraju@quicinc.com; rdunlap@infradead.org;
>> damien.lemoal@opensource.wdc.com; songmuchun@bytedance.com;
>> peterz@infradead.org; jpoimboe@kernel.org; pbonzini@redhat.com;
>> chang.seok.bae@intel.com; pawan.kumar.gupta@linux.intel.com;
>> jmattson@google.com; daniel.sneddon@linux.intel.com; Das1, Sandipan
>> <Sandipan.Das@amd.com>; tony.luck@intel.com; james.morse@arm.com;
>> linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org;
>> bagasdotme@gmail.com; eranian@google.com; christophe.leroy@csgroup.eu;
>> jarkko@kernel.org; adrian.hunter@intel.com; quic_jiles@quicinc.com;
>> peternewman@google.com
>> Subject: Re: [PATCH v9 10/13] x86/resctrl: Add sysfs interface to write
>> mbm_total_bytes_config
>>
>> Hi Babu,
>>
>> On 12/1/2022 7:37 AM, Babu Moger wrote:

...

>>> +	/*
>>> +	 * When an Event Configuration is changed, the bandwidth counters
>>> +	 * for all RMIDs and Events will be cleared by the hardware. The
>>> +	 * hardware also sets MSR_IA32_QM_CTR.Unavailable (bit 62) for
>>> +	 * every RMID on the next read to any event for every RMID.
>>> +	 * Subsequent reads will have MSR_IA32_QM_CTR.Unavailable (bit 62)
>>> +	 * cleared while it is tracked by the hardware. Clear the
>>> +	 * mbm_local and mbm_total counts for all the RMIDs.
>>> +	 */
>>> +	resctrl_arch_reset_rmid_all(r, d);
>>
>> If I understand correctly the expectation is that when user space read counters
>> (via mon_data files) right after the configuration was changed then this read
>> will return "Unavailable" and then the next read will return data.
>>
>> If this is the case then I think a snippet about this user experience would be
>> helpful to add to the documentation.
> 
> Ok.  How about this in the documentation?
> 
> "When an event configuration is changed, the bandwidth counters for all the RMIDs and the events will be cleared for that domain.
> The next read for every RMID will report "Unavailable" and subsequent reads will report the valid value."
> 
> 

Thinking about this more ... why are the counters for all eventids cleared
when only one eventid's configuration is changed?

Reinette