Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp4552142rwj;
        Tue, 20 Dec 2022 11:42:13 -0800 (PST)
X-Google-Smtp-Source: AA0mqf4Uwctl+hqEHLb5Kd9u39xwGcITj4ePzmk4RUq9PnYyWyOAl9I3CCMuoX5p4dJmOoC6Elad
X-Received: by 2002:a17:902:6e0f:b0:189:361f:89ac with SMTP id u15-20020a1709026e0f00b00189361f89acmr43880214plk.64.1671565333710;
        Tue, 20 Dec 2022 11:42:13 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1671565333; cv=none;
        d=google.com; s=arc-20160816;
        b=ClH/s4GJMkvXFjLrg5bVqDoXEWZwhEyZaTNEqvI3mjLFXmz/a0nsbY/WzSrfc8GAFM
         NT1TI+wZHOK+K/3MEcUPz2s7BiP20syPd9a7CwHJJ/3iMc0CY7NeObpM1Q5/o5d1i8eX
         paMI2w1jE/kACE3Hqt94LcLTjokBwUuJuxiTQ+CDOXedo6v6+ZfeGV/pjkr8oWtec8M+
         vjBHtwDcitbpTUF5R4V0SQqtdP1x7xIJvmQLQP/fVR7X8RDclj1xiuql9UGQC1OolAgw
         6WCRFScgF9Znr9cLFSmX1PiQlJXkmPA+77qcAudrK06bPKuIxJaDJwDbAKXfKXepdCKQ
         d0BQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=oOT3ARrLvll03d+kSmHrwqXzIDmQS/iM+t/VcCGIQpM=;
        b=zR3mLIcKyh+PvYqlBln6Aw1yvSHL/HJjuYz9s6cO3oUVnI/BFg139fQau/j3HbFtk+
         pdpxNnFF+v585VzcPtcCjvz8wIZ20zf/BuRf8nmxyWl7kEFzll27FxKflulq3LmZDRyf
         BhJUQTGiUFA78AengBFC5naaOKwxGNSDU7zJJ/UWcKysAQrRXy9JerEIzibnk+R9KKrf
         OiW0OI3uVaAlVn8LJdbozFGBkQr2avIfhLim/hetq5Ybyru6iLutBzzT1xxvxKZ2dA7p
         JaWcTkQ7NkO+SFEI03atkA4UQnWmNfyg2Fh55vM72cpnDpVk7FxSDEd8Jv7PCxORVhMV
         mvAw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nHYuuUgT;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id jk18-20020a170903331200b0018010c3d7e3si3682531plb.404.2022.12.20.11.42.04;
        Tue, 20 Dec 2022 11:42:13 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=k20201202 header.b=nHYuuUgT;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S233938AbiLTTi1 (ORCPT <rfc822;4ak.abc@gmail.com> + 68 others);
        Tue, 20 Dec 2022 14:38:27 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60724 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S233763AbiLTTiZ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 20 Dec 2022 14:38:25 -0500
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E9F810D1;
        Tue, 20 Dec 2022 11:38:24 -0800 (PST)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by dfw.source.kernel.org (Postfix) with ESMTPS id 1515C61585;
        Tue, 20 Dec 2022 19:38:24 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 13068C433EF;
        Tue, 20 Dec 2022 19:38:23 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1671565103;
        bh=oOT3ARrLvll03d+kSmHrwqXzIDmQS/iM+t/VcCGIQpM=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=nHYuuUgT9cgr8RMs6+8zv1Elzmla2x8xW/5e34YG3sGX1oXJhhX+BKVHfoVW95P9V
         uZPvFYSznhaujhQNOnwJMi5G62Z8JQb1Hfmmb+pkFcOVlgVqSb+UBHZqyhb0KRqaoD
         oAydkA7Am3pqi9KRZFT4KbT+T73mgNfWuxY+y2KK0/oX20/ec+TargtCPi35JwAkFJ
         snG1jQmnFgji3bKo3dpaBSYB9vWTTC0yqVhXuGzRqoeuODsy+Lg7x489L8utqg1+bB
         5GcnAIGOZZY2Y9+Hn1exTF/uo4tFAbAq0AUJaxRAuih7H+ZS0iBeRx4TgASCYh6JYP
         p94ISDlpnuvDA==
Date:   Tue, 20 Dec 2022 11:38:22 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Paul Gazzillo <paul@pgazz.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Zheng Bin <zhengbin13@huawei.com>,
        Suman Ghosh <sumang@marvell.com>,
        Sunil Goutham <sgoutham@marvell.com>,
        Subbaraya Sundeep <sbhatta@marvell.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] octeontx2_pf: Select NET_DEVLINK when enabling
 OCTEONTX2_PF
Message-ID: <20221220113822.4efe142e@kernel.org>
In-Reply-To: <20221219171918.834772-1-paul@pgazz.com>
References: <20221219171918.834772-1-paul@pgazz.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 19 Dec 2022 12:19:11 -0500 Paul Gazzillo wrote:
> When using COMPILE_TEST, the driver controlled by OCTEONTX2_PF does
> not select NET_DEVLINK while the related OCTEONTX2_AF driver does.
> This means that when OCTEONTX2_PF is enabled from a default
> configuration, linker errors will occur due to undefined references to
> code controlled by NET_DEVLINK.

This has been fixed a long time ago by 9cbc3367968d ("octeontx2-pf:
select CONFIG_NET_DEVLINK") no?