Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v3 1/1] i2c: Set pinctrl recovery info to device pinctrl
Message-ID: <a82ba757-3b9c-d54b-76bf-ceef84239295@amazon.com>
Date:   Tue, 20 Dec 2022 21:32:11 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.0
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC:     <wsa@kernel.org>, <linus.walleij@linaro.org>,
        <linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-gpio@vger.kernel.org>, <dwmw@amazon.co.uk>,
        <benh@amazon.com>, <ronenk@amazon.com>, <talel@amazon.com>,
        <jonnyc@amazon.com>, <hanochu@amazon.com>, <farbere@amazon.com>,
        <itamark@amazon.com>
References: <20221219193228.35078-1-hhhawa@amazon.com>
 <Y6GUKf5TCumM1Swy@smile.fi.intel.com>
 <4344f575-65f5-2fde-e2d5-3dd5a18d13cb@amazon.com>
 <Y6IKit5XMcSLBgpO@smile.fi.intel.com>
From:   "Hawa, Hanna" <hhhawa@amazon.com>
In-Reply-To: <Y6IKit5XMcSLBgpO@smile.fi.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/20/2022 9:18 PM, Andy Shevchenko wrote:
>> How you suggest to simplify this?
> Using Elvis operator, which is ?:.

Are you refer to use 'return dev->pins && dev->pins->p ?: NULL;' ?
Can't use Elvis operator in this way, because it will return the result 
of 'dev->pins && dev->pins->p' and not the value of 'dev->pins->p'

> 
>> I can use 'return dev->pins ? dev->pins->p ?: dev->pins->p : NULL;'
> Have you even try to compile this?
Yup, the code compiled, but i think the first suggestion is more readable.

>