Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Dec 2022 11:51:41 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     Luis Chamberlain <mcgrof@kernel.org>,
        Dan Williams <dan.j.williams@intel.com>
CC:     <alison.schofield@intel.com>, <vishal.l.verma@intel.com>,
        <ira.weiny@intel.com>, <bwidawsk@kernel.org>, <dave@stgolabs.net>,
        <a.manzanares@samsung.com>, <linux-cxl@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] cxl_test: upgrade as a first class citizen selftests
 capable driver
Message-ID: <63a2124db0877_1bf229440@dwillia2-xfh.jf.intel.com.notmuch>
References: <20221217034947.1174795-1-mcgrof@kernel.org>
 <639d4bb71bada_b41e329452@dwillia2-xfh.jf.intel.com.notmuch>
 <Y6DDPGnwszUAiNh2@bombadil.infradead.org>
 <63a1015e6ec4a_1bf22944c@dwillia2-xfh.jf.intel.com.notmuch>
 <Y6Ehi2ihIgQd/aoR@bombadil.infradead.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <Y6Ehi2ihIgQd/aoR@bombadil.infradead.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?P+Z4KFEY5avuE53nC3uImOeg8u8gllKmzyWuDr2rQrCnWyqa8fO/go4dt2OZ?=
 =?us-ascii?Q?2PSJQeDTMd7HFxRQeHhCDwUs4UUnbtNb85b5NtXYFxEdcEeWFMUR22UcEjif?=
 =?us-ascii?Q?iCccNnI6IsugYjVSfWKIYVFUZ8go9q/3XtR1FFbhKCH5GWyiE1Y5iozjRhiY?=
 =?us-ascii?Q?ZwRnbvzr5DWNQhc4+i10YSZ1GY4EHE/VNNacQgpbHOplksPZ20rECXm5pCYe?=
 =?us-ascii?Q?ScquZW39XpINWuqYu5hko3zq0eMGDZcHL6IKn8fczA0SPdgLr5PU0ASuR3C3?=
 =?us-ascii?Q?DElWeIO4L/D9AV62rkbq6FYp+3TI3teQz8mhxAotqlYWNgD8q9eSdbOyY+ev?=
 =?us-ascii?Q?rDQdl58j/KfZG9UkLIDt+nKGK12ZFPqZ6NfNDwybEA1nhGTGolmRpHzSiBG3?=
 =?us-ascii?Q?D491w5+E6kIszsI2hISFqEUbDwtSjBWFAfCS4gltAw4Uu1o7djoD/ArMVZ8L?=
 =?us-ascii?Q?eK5wCEBaazt6gdggUd+5XPoEULj5Q4gacnoT07KiPXpsNMC8wSnxk7y7ehmC?=
 =?us-ascii?Q?bzrKpd0DHtMvlbXOlk2OjPFyYVTKRw6OXAx1AzN+0xwHGOI9jCO68iSdZcfE?=
 =?us-ascii?Q?71JPhEyh8D9/M9NzBLcve9AGbuKKJ1HFnn4F+3Z6TcdJ/PTCsJ6TdpPJh2dF?=
 =?us-ascii?Q?EbQ5BvIhC8au7dvk7vdLyH9nSDPs4Z40vWXSmNuYdlpNKLkvkcuVuQy0KlQs?=
 =?us-ascii?Q?H1Rt2FtMCO/q+4QNy6U/erVp1fI44Bh8M1/VBcuCr4t8lczZzLnPdEQXo/eS?=
 =?us-ascii?Q?x8PeuPhfp2j+s9V2KCuVeQ3Z+Zeby8d7TwFmlIUHTK1XRP/ftsBAcNa2cpwU?=
 =?us-ascii?Q?sEa6qe4SH7UiHo+4CyC2XpgXJhghiIUN6823aNBbWiiNFZiEQLaXRq0DXZvX?=
 =?us-ascii?Q?LwFbQhdu3RT9N27WZ+M0BULqnOH2EgDLPS91pvL8QrvsXHtJAdODZsGwyC79?=
 =?us-ascii?Q?2VAY6E+DZYxQhyVYh1h24tlGTe/Qy+mEnpxCvPYnMP8Ux2ASZCx7NcRWjM6n?=
 =?us-ascii?Q?1LCS8xqOpZBKzYee9GVUlYK7eASbNVjINgxr8Xs6TihbGHdS/mSE87OTYwk4?=
 =?us-ascii?Q?gRMkYirYVj8+VZQL8hN1VrkVMsta8sJliQdyw7CUOSyVzvANDrvIzsX3/mBg?=
 =?us-ascii?Q?VTIPVirPIvicEZiIkikkGFfjVdRkRhiNxW6QWCXIEUgVTGyKzGOnXNV+npJz?=
 =?us-ascii?Q?d/1mF66sTT8TAPDSUUGsY5iQ0H7UWGHICo93xkcxh68dHsqsrq6rTffd0X8x?=
 =?us-ascii?Q?ubFHafQh1z2BxlljCriTWm78farVD3fCdU2Y1nAdcGaK2MODwPqq4iexmvxh?=
 =?us-ascii?Q?GX4EUL+vz8GGtX0z1/AuaNQGc/RWWPBLPBx3TIP98Dy+oR3IPe0wJpQF73nv?=
 =?us-ascii?Q?BzY8D6RZpR8KvocxhYXfBYd5JnI5F8YPkZZYphkxBJUq65ORcXAM1XdOLwTz?=
 =?us-ascii?Q?6si/7hUBYbGWpWP2qsLLkDgIU2rbKLUwBxnMPvCHUty+2i4vn6aSvyyHPTET?=
 =?us-ascii?Q?KAq0WSqs5etsZAr7FbNy0Kak9qLTAeWIRqaSfM8CzNxagCh1Sdp0r8ungnuv?=
 =?us-ascii?Q?Vlk1CAfYW9lrwmIAyF6eN40pl6DJ+PoOSHnGNyxoRPG30zalP0qSDLsVNaQ/?=
 =?us-ascii?Q?8A=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d359cc6-5c09-40ef-6db4-08dae2c39f69
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1101MB2121.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2022 19:51:44.9520
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: eUCW9bQB1n8dq3uHzJu2E2UoeulcaQ/44UvXLquutI/pVl5Mqd/PcxJ1luJg0RoRRDM8HWMAbT6yZ3MULMrZ4CNlJ/dDHN4LvJWnurUi4ac=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7808
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Luis Chamberlain wrote:
> On Mon, Dec 19, 2022 at 04:27:10PM -0800, Dan Williams wrote:
> > Luis Chamberlain wrote:
> > > On Fri, Dec 16, 2022 at 08:55:19PM -0800, Dan Williams wrote:
> > > > In other words the suggestion that the current
> > > > organization ultimately leads to bit rot has not been substantiated in
> > > > practice.
> > > 
> > > On top of this patch I just added a custom debug patch to my tree which
> > > enables CXL_BUS and CXL_TEST by default when this is currently allowed
> > > and it got quite a bit of kernel build warnings. Although some of these
> > > are specific to my change, some of them do not seem to be related to
> > > that and likely could benefit from fixing:
> > > 
> > > https://gist.github.com/mcgrof/73dce72939590c6edc9413b0384ae4c2
> > > 
> > > And so although you may not see some build warnings so far, it does not
> > > negate my suggestion that having cxl_test as a proper upstream driver strategy
> > > gets you more build testing / coverage.
> > 
> > If autobuild coverage of test components is the main concern then
> > cxl_test can copy what nfit_test is doing with CONFIG_NVDIMM_TEST_BUILD.
> > No need for disruptive redesign of how this facility is integrated.
> 
> I've itemized a list of gains of having this properly integrated. What
> gains are there of this being an external module other than a few folks
> are used to it and it been done before for other subsystems?

Your crash report is a prime example of why this needs to stay an
external module. Any redefinition of what a symbol does via --wrap= is a
fragile proposition. The fact that crash signatures with cxl_test loaded
have the external module taint flag set is a feature. The --wrap= option
has no business within the main tree because it violates the valid
assumptions of other cxl_test-innocent developers.

The benefit that resonated with me during this discussion was more
compile test coverage for cxl_test components. However, that is achieved
by tools/testing/cxl/ adopting the same compile coverage scheme that
tools/testing/nvdimm/ has with CONFIG_NVDIMM_TEST_BUILD.