Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761495AbXHPOHk (ORCPT ); Thu, 16 Aug 2007 10:07:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759428AbXHPOH1 (ORCPT ); Thu, 16 Aug 2007 10:07:27 -0400 Received: from hellhawk.shadowen.org ([80.68.90.175]:1423 "EHLO hellhawk.shadowen.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759309AbXHPOHZ (ORCPT ); Thu, 16 Aug 2007 10:07:25 -0400 Message-ID: <46C45996.6060802@shadowen.org> Date: Thu, 16 Aug 2007 15:05:10 +0100 From: Andy Whitcroft User-Agent: Icedove 1.5.0.9 (X11/20061220) MIME-Version: 1.0 To: "Kok, Auke" CC: Joe Perches , "Randy.Dunlap" , Joel Schopp , Dave Jones , Linux Kernel , rolandd@cisco.com, Chas Williams , Paul Mundt , isdn4linux@listserv.isdn4linux.de, mikep@linuxtr.net, netdev@vger.kernel.org, swen@vnet.ibm.com, linux390@de.ibm.com, linux-s390@vger.kernel.org, jdike@karaya.com, user-mode-linux-devel@lists.sourceforge.net, user-mode-linux-user@lists.sourceforge.net, netfilter-devel@lists.netfilter.org, coreteam@netfilter.org Subject: Re: drivers/infiniband/mlx/mad.c misplaced ; References: <20070815235825.GB17004@redhat.com> <1187224811.5906.55.camel@localhost> <46C3B428.4000003@intel.com> In-Reply-To: <46C3B428.4000003@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SPF-Guess: neutral Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1816 Lines: 45 Kok, Auke wrote: > Joe Perches wrote: >> On Wed, 2007-08-15 at 19:58 -0400, Dave Jones wrote: >>> Signed-off-by: Dave Jones >>> >>> diff --git a/drivers/infiniband/hw/mlx4/mad.c >>> b/drivers/infiniband/hw/mlx4/mad.c >>> index 3330917..0ed02b7 100644 >>> --- a/drivers/infiniband/hw/mlx4/mad.c >>> +++ b/drivers/infiniband/hw/mlx4/mad.c >>> @@ -109,7 +109,7 @@ int mlx4_MAD_IFC(struct mlx4_ib_dev *dev, int >>> ignore_mkey, int ignore_bkey, >>> in_modifier, op_modifier, >>> MLX4_CMD_MAD_IFC, MLX4_CMD_TIME_CLASS_C); >>> >>> - if (!err); >>> + if (!err) >> >> There's more than a few of these (not inspected). >> >> $ egrep -r --include=*.c "\bif[[:space:]]*\([^\)]*\)[[:space:]]*\;" * >> arch/sh/boards/se/7343/io.c: if (0) ; >> drivers/atm/iphase.c: if (!desc1) ; >> drivers/infiniband/hw/mlx4/mad.c: if (!err); >> drivers/isdn/capi/capiutil.c: else if (c <= 0x0f); >> drivers/net/tokenring/ibmtr.c: else if (ti->shared_ram_paging == >> 0xf); /* No paging in adapter */ >> drivers/s390/scsi/zfcp_erp.c: if (status == >> ZFCP_ERP_SUCCEEDED) ; /* no further action */ >> fs/hostfs/hostfs_user.c: if(attrs->ia_valid & HOSTFS_ATTR_CTIME) ; >> net/netfilter/xt_u32.c: if (skb->len < 4 || pos > skb->len - 4); >> sound/pci/au88x0/au88x0_synth.c: if >> (eax == 0) ; > > sounds like an excellent candidate check for checkpatch.pl !!! Yep. My scan of 2.6.23-rc3 with a checkpatch with this new test added, found 6 which seemed wrong. -apw - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/