Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 20 Dec 2022 14:49:18 -0500
From:   Paul Gazzillo <paul@pgazz.com>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Yang Yingliang <yangyingliang@huawei.com>,
        Zheng Bin <zhengbin13@huawei.com>,
        Suman Ghosh <sumang@marvell.com>,
        Sunil Goutham <sgoutham@marvell.com>,
        Subbaraya Sundeep <sbhatta@marvell.com>,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] octeontx2_pf: Select NET_DEVLINK when enabling
 OCTEONTX2_PF
Message-ID: <20221220194918.4mrrbbjcpj5dvps3@device>
References: <20221219171918.834772-1-paul@pgazz.com>
 <20221220113822.4efe142e@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221220113822.4efe142e@kernel.org>
Precedence: bulk

On 12/20/2022, Jakub Kicinski wrote:
> On Mon, 19 Dec 2022 12:19:11 -0500 Paul Gazzillo wrote:
> > When using COMPILE_TEST, the driver controlled by OCTEONTX2_PF does
> > not select NET_DEVLINK while the related OCTEONTX2_AF driver does.
> > This means that when OCTEONTX2_PF is enabled from a default
> > configuration, linker errors will occur due to undefined references to
> > code controlled by NET_DEVLINK.
> 
> This has been fixed a long time ago by 9cbc3367968d ("octeontx2-pf:
> select CONFIG_NET_DEVLINK") no?

You are right.  My apologies.  I was looking at an older kernel.