Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9e1390c5-844c-9fa5-693e-da9d10c64e21@siddh.me>
Date:   Wed, 21 Dec 2022 02:01:04 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
From:   Siddh Raman Pant <code@siddh.me>
Subject: Re: [PATCH] selftests: Add missing <sys/syscall.h> to mount_setattr
 test
To:     Daan De Meyer <daan.j.demeyer@gmail.com>
Cc:     Christian Brauner <brauner@kernel.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-kselftests <linux-kselftest@vger.kernel.org>,
        Seth Forshee <sforshee@kernel.org>,
        Shuah Khan <shuah@kernel.org>
References: <20221201150218.2374366-1-daan.j.demeyer@gmail.com>
Content-Language: en-US, en-GB, hi-IN
In-Reply-To: <20221201150218.2374366-1-daan.j.demeyer@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, Dec 01 2022 at 20:32:18 +0530, Daan De Meyer wrote:
> Including <sys/syscall.h> is required to define __NR_mount_setattr
> and __NR_open_tree which the mount_setattr test relies on.
> 
> Signed-off-by: Daan De Meyer <daan.j.demeyer@gmail.com>
> ---
>  tools/testing/selftests/mount_setattr/mount_setattr_test.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/mount_setattr/mount_setattr_test.c b/tools/testing/selftests/mount_setattr/mount_setattr_test.c
> index 8c5fea68ae67..da85f8af482c 100644
> --- a/tools/testing/selftests/mount_setattr/mount_setattr_test.c
> +++ b/tools/testing/selftests/mount_setattr/mount_setattr_test.c
> @@ -11,6 +11,7 @@
>  #include <sys/wait.h>
>  #include <sys/vfs.h>
>  #include <sys/statvfs.h>
> +#include <sys/syscall.h>
>  #include <sys/sysinfo.h>
>  #include <stdlib.h>
>  #include <unistd.h>

Tested-by: Siddh Raman Pant <code@siddh.me>

Though this oversight actually led to gcc detecting another
another error [1], as it entered the #ifndef __NR_mount_setattr
block.

Thanks,
Siddh

[1] https://lore.kernel.org/all/20221211092820.85527-1-code@siddh.me/