Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Fabrizio Castro <fabrizio.castro.jz@renesas.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Bartosz Golaszewski <brgl@bgdev.pl>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Sebastian Reichel <sre@kernel.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>
CC:     Lee Jones <lee@kernel.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        Chris Paterson <Chris.Paterson2@renesas.com>,
        Biju Das <biju.das@bp.renesas.com>,
        "linux-renesas-soc@vger.kernel.org" 
        <linux-renesas-soc@vger.kernel.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Jacopo Mondi <jacopo@jmondi.org>
Subject: RE: [PATCH 2/5] dt-bindings: power: reset: Add RZ/V2M PWC Power OFF
 bindings
Thread-Topic: [PATCH 2/5] dt-bindings: power: reset: Add RZ/V2M PWC Power OFF
 bindings
Thread-Index: AQHZD0RTibrnAoAXK0KZj5lZ2/4nUq5utr4AgAichIA=
Date:   Tue, 20 Dec 2022 21:22:12 +0000
Message-ID: <TYWPR01MB8775F68FD5F270350045EDD3C2EA9@TYWPR01MB8775.jpnprd01.prod.outlook.com>
References: <20221213224310.543243-1-fabrizio.castro.jz@renesas.com>
 <20221213224310.543243-3-fabrizio.castro.jz@renesas.com>
 <0161902f-1a0c-0be2-2141-3c14d6e6fe54@linaro.org>
In-Reply-To: <0161902f-1a0c-0be2-2141-3c14d6e6fe54@linaro.org>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tTD1elBYoi23ovnt/NDjLZwM2koTVq3tKi+r5YmWWgZ0CpseQQ5aRsdg0uFd?=
 =?us-ascii?Q?TYQnoFiu0zjHJcQHxgZ9PqDK7HfTrkg4LWJ14qoT3Oc2JdTSLg0rg5y60vxZ?=
 =?us-ascii?Q?fSMQ63YaS3yr50Y4uYzI9xrXaEJRYnoD/ybwv4gqRB0/CpDPTl8d0eJZuAt2?=
 =?us-ascii?Q?rGKin7NiZxWVr3g25y//vSfeY1PDLPiyzpSxTNPV0O5xPsWFrJuHv9Ab3Ofk?=
 =?us-ascii?Q?tmFltmtm+TihZd4ZqH/NEz4V6wgl6sNYnWraGUwtyqFILOY98yX6UE+tAZps?=
 =?us-ascii?Q?luXJ4O/UcxkZjzlWKFaWtzNnHBgTJGU/Vvkr2RUDif8tpukB/4qlj5v6jfNJ?=
 =?us-ascii?Q?+55dRlhAubGfQNIXDlOyY/Y3G66+rlVFez0Cr1SZGQRVC7WOvPTYT32eLNlE?=
 =?us-ascii?Q?9S5bSK1KnDjTjC7ktOe210rJg/A6kTpjW8RmpgRJbW3fID/Q4uqysXAEsfTo?=
 =?us-ascii?Q?AUFAsVoeBDXgiet9WBgXXFP7snkX9GoyiWIVRxXQBCNze3LvhYhppRVhwF2X?=
 =?us-ascii?Q?kv3Kouo2K6ANO7zGilf4H4HP+IunSLvHgNnZAMceO4qJHwYTbVuVy4wpElaN?=
 =?us-ascii?Q?WhM+pNXePg3D4a7QbRHww3gyxnFt9Vif8l5fLqHbE02Tf8DrmPPyTXnmy1RS?=
 =?us-ascii?Q?VV1UlT7Lv6g6wKMXRqh0j9TFVIKjz4tlcHfKl7vomV4jm3kyd9L2WwLemSNp?=
 =?us-ascii?Q?EBnV4CbfudtNLn19KXBTbeJg2x5o6w/tnyfUApsLw0SdKP/S6T5hZdOnDAjg?=
 =?us-ascii?Q?WSFjQyt3/iSK2ykvmqzyLF6Q9V/Lu6wGtVI23eoOUG9VLcq+kwEs6YQ1j7Gp?=
 =?us-ascii?Q?g/qCbNwAS73Rf8X5D3DpmMgwfeFLqO2wF8EvZx2MQw2GOyxYlLQKvRGp6G9k?=
 =?us-ascii?Q?lSbe1s4Zvx0GZypkWC1eAuFHocXQ7as+U0HhlD2pMwubFgMMEYe40GuYbYqW?=
 =?us-ascii?Q?efLAu9LgWf+LLSk7x0BuXsUubczgcecj2PSjNqdiQig9O15VP5W7zxgEQePe?=
 =?us-ascii?Q?Jbp11GeyTsFodjrBY+7/HBTnwgPh/xhiiz70lx55zKSJWIKHqKjQDWGqYhf6?=
 =?us-ascii?Q?OGzIhrkf98zDQctE96SUzqj74OYgn0ROi5vRcCAI61iK71OqMxDKkfY9aCCm?=
 =?us-ascii?Q?YzWQQYt85iSULa4wBiSknSFbJIuX8zBsxT8yMPY0i+0nnVjAFFAYSNm05A0a?=
 =?us-ascii?Q?FgO9tkg710uqvPyJVBYbrtByFqEzD6NYTz2aqLHPYTUjMc489XklAB3r43KE?=
 =?us-ascii?Q?cNo8hhhAlF0opMI8QSIO4cpKnwchwo9fT5sShBVCDwKN8WRK3RWFkq4f56X9?=
 =?us-ascii?Q?vw//vYnG2nJGSy8tYw9WzR17/x11gcJl3ahpnF0GbeUA08Qs7ojhsNpklebF?=
 =?us-ascii?Q?wxVsXP+DcZYOlzfCm4QQ0PojFkyPfTUAYgFlktg+COmL1XiPWI2jPon+YONr?=
 =?us-ascii?Q?OilqyErMzsPZ2L31nSSmOORkv9h4Q6tqYmKXNN8zb1QGpPEMmW5cum/Ul4H+?=
 =?us-ascii?Q?1vwy/5JNFK0Wuzg31wt8gJUve7iRO0uezzNM+XR/01gh4BFmuaVBy9RQYPm5?=
 =?us-ascii?Q?fzJVVyj02ikSI5vpaUfhIYikVUnJW2WWa6g+boxbSTCLVK0dQ+Kppp14Lhil?=
 =?us-ascii?Q?Jg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: renesas.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: TYWPR01MB8775.jpnprd01.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4b52c876-5d1e-452f-715e-08dae2d04287
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Dec 2022 21:22:12.3437
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bO/kg8+AatXTQefI/W26KOMPGx6kSTG8EanUCokgEd1lSITCe6g/vnYzzoTRnRHSJ01g8jThTr/XbLI7pAYK2+GRONm3SE5QDCke+2pbQks=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB9422
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Krzysztof,

Thanks for your feedback.

> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: 15 December 2022 09:50
> To: Fabrizio Castro <fabrizio.castro.jz@renesas.com>;
> Subject: Re: [PATCH 2/5] dt-bindings: power: reset: Add RZ/V2M PWC Power
> OFF bindings
>=20
> On 13/12/2022 23:43, Fabrizio Castro wrote:
> > Add dt-bindings document for the RZ/V2M PWC Power OFF driver.
>=20
> Drop driver.
>=20
> Subject: drop second, redundant "bindings".

Thanks

>=20
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > ---
> >  .../reset/renesas,rzv2m-pwc-poweroff.yaml     | 48 +++++++++++++++++++
> >  1 file changed, 48 insertions(+)
> >  create mode 100644
> Documentation/devicetree/bindings/power/reset/renesas,rzv2m-pwc-
> poweroff.yaml
> >
> > diff --git
> a/Documentation/devicetree/bindings/power/reset/renesas,rzv2m-pwc-
> poweroff.yaml
> b/Documentation/devicetree/bindings/power/reset/renesas,rzv2m-pwc-
> poweroff.yaml
> > new file mode 100644
> > index 000000000000..12456e3e93e6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/reset/renesas,rzv2m-pwc-
> poweroff.yaml
> > @@ -0,0 +1,48 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +
> > +title: Renesas RZ/V2M External Power Sequence Controller (PWC) Power
> OFF
> > +
> > +description: |+
> > +  The PWC IP found in the RZ/V2M family of chips comes with the below
> > +  capabilities
> > +    - external power supply on/off sequence generation
> > +    - on/off signal generation for the LPDDR4 core power supply (LPVDD=
)
> > +    - key input signals processing
> > +    - general-purpose output pins
> > +  This node uses syscon to map the registers relevant to Power OFF (th=
e
> > +  register map is retrieved from the parent dt-node), and the node
> should be
> > +  represented as a sub node of a "syscon", "simple-mfd" node.
> > +
> > +maintainers:
> > +  - Fabrizio Castro <fabrizio.castro.jz@renesas.com>
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - renesas,r9a09g011-pwc-poweroff # RZ/V2M
> > +          - renesas,r9a09g055-pwc-poweroff # RZ/V2MA
> > +      - const: renesas,rzv2m-pwc-poweroff
> > +
> > +  regmap:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description: |
> > +      Phandle to the register map node.
>=20
> This also has to go.

It'll go

>=20
> > +
> > +required:
> > +  - compatible
> > +  - regmap
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    poweroff {
> > +            compatible =3D "renesas,r9a09g011-pwc-poweroff",
>=20
> Use 4 spaces for example indentation.

Doh, I'll be more careful next time.

Thanks,
Fab

>=20
> > +                         "renesas,rzv2m-pwc-poweroff";
> > +            regmap =3D <&regmapnode>;
> > +    };
>=20
> Best regards,
> Krzysztof