Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: xqTFZ48FgyhJT52pDsRjs/vRTPn2znilihPmtRknrIQfrBMckqh4t9EvzJf+pcJP2RZ2HCMawX
 wAuyvKKym5RJhhajMlG+K3CmnvRf8qYqn03yBUr/L02VHE8COhgzBs74u5WK1NBq2fOP+Kjspo
 NbHjrViRbaZMCHlh8MTaWVedTlhHHKEU90ng6CbiZlMmiMdq3LRpLKRgzBuPCIa/QQpCNpxh5Z
 HijCnetOLc7eMRGG8WZUS5wkSxnffDKyEzJgRKMtJ/ufOqMtnRD7ExzwDXqb9gukS35gGcE62C
 /W4=
IronPort-SDR: h4Iw0CETRfvVkS2A+Vscw79S0xGHDyVTUaSVn8jd+PHM1nrrSrrN4Tfyt514Ru6TUy5gMwbhgP
 yvpQf2+XBjY9Zg19HgjeNHf3sFC9oqXS7K6ZPOQXTJ2eLnNeOu+OoWjvCdNnyMHA3pOswWr9SG
 ySLEtn1JK4F/xqymHENS4RXx8g3/FVRdtFkbAybYgbSR9ij8voNBUiY6XgaEyjofp8qpmIRXZG
 zG81LoV0Xg5azjWsg3dwY1icQaJXIKMoAquLOgtFNUyGrS2OPOe7V5CfCut0VdQF5UGWn8LrO8
 K2A=
WDCIronportException: Internal
Message-ID: <c8387766-2ca0-51f3-e332-71492b13e5c1@opensource.wdc.com>
Date:   Wed, 21 Dec 2022 09:36:03 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.6.0
Subject: Re: [PATCH] scsi: libsas: Grab the host lock in
 sas_ata_device_link_abort()
Content-Language: en-US
To:     John Garry <john.g.garry@oracle.com>,
        Xingui Yang <yangxingui@huawei.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, niklas.cassel@wdc.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com, prime.zeng@hisilicon.com,
        kangfenglong@huawei.com
References: <20221220125349.45091-1-yangxingui@huawei.com>
 <4ec9dbed-1758-d6b4-dc1d-ac42e8c22731@oracle.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <4ec9dbed-1758-d6b4-dc1d-ac42e8c22731@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/12/20 23:59, John Garry wrote:
> On 20/12/2022 12:53, Xingui Yang wrote:
>> Grab the host lock in sas_ata_device_link_abort() before calling
> 
> This is should be the ata port lock, right? I know that the ata comments 
> say differently.
> 
>> ata_link_abort(), as the comment in ata_link_abort() mentions.
>>
> 
> Can you please add a fixes tag?
> 
>> Signed-off-by: Xingui Yang <yangxingui@huawei.com>
> 
> Reviewed-by: John Garry <john.g.garry@oracle.com>
> 
>> ---
>>   drivers/scsi/libsas/sas_ata.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
>> index f7439bf9cdc6..4f2017b21e6d 100644
>> --- a/drivers/scsi/libsas/sas_ata.c
>> +++ b/drivers/scsi/libsas/sas_ata.c
>> @@ -889,7 +889,9 @@ void sas_ata_device_link_abort(struct domain_device *device, bool force_reset)
>>   {
>>   	struct ata_port *ap = device->sata_dev.ap;
>>   	struct ata_link *link = &ap->link;
>> +	unsigned long flags;
>>   
>> +	spin_lock_irqsave(ap->lock, flags);
>>   	device->sata_dev.fis[2] = ATA_ERR | ATA_DRDY; /* tf status */
>>   	device->sata_dev.fis[3] = ATA_ABORTED; /* tf error */
>>   
>> @@ -897,6 +899,7 @@ void sas_ata_device_link_abort(struct domain_device *device, bool force_reset)
>>   	if (force_reset)
>>   		link->eh_info.action |= ATA_EH_RESET;
>>   	ata_link_abort(link);

Really need to add lockdep annotations in libata to avoid/catch such bugs...
Will work on that.

>> +	spin_unlock_irqrestore(ap->lock, flags);
>>   }
>>   EXPORT_SYMBOL_GPL(sas_ata_device_link_abort);
>>   
> 

-- 
Damien Le Moal
Western Digital Research