Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp5009883rwj; Tue, 20 Dec 2022 18:59:35 -0800 (PST) X-Google-Smtp-Source: AMrXdXvkRwukSFxlyVjz8eYz3jzCGt9T37s3wTUk16TlBR4n2EseRFKVyV7HeaRDDLMgPG0jhliP X-Received: by 2002:a17:90b:944:b0:219:3bd:c32e with SMTP id dw4-20020a17090b094400b0021903bdc32emr276868pjb.49.1671591575546; Tue, 20 Dec 2022 18:59:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671591575; cv=none; d=google.com; s=arc-20160816; b=bUUkAO45DcCV7ZI8V06D97K3OLxnOJQvXkkxLyMjOs4V8VPCM8zPD6w/OzKZNk5nR+ AOvqhUXP/u99bBS1G4rhCpq7FgBQGFOl5R3mUvpQUB91pCY8t9sSYwdj6//Fux+cCaRF g/zxtktAfNy++KnoiUx3OSko4mbUR2WmAfpajVyTXOaERZFtU6VfmPw6WkdlE/Z9noDL Masp/oqsD9uU9j9+GMt0bttJB9Pa2Xw/+NOQEcVw/cAVIfEI4zIM/1KvXfNQh0qVSXKG tcvE/N6V2qjhcMX7fMxTU7zlwy9B2Ewgnm8Em5B1wWJOjn2Ln9+KJh016tPQBdOpNQ2e g1UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=ckM7Od4qIOxKiANOhKXHYr3zPmAQiUynaHISDIiIlRQ=; b=w1U3CQp7HccUtJyg6ZMuGyx86bc5lRbb0u8bC8Dii9wqgTK1MR0npLPThGEXWVyr/J buvr9nIF7iAnh1HW3KH9+Zn5/7TTei2lkUHuKpkQsdib1DdvrkXJM6akTLKa8A1qvF9w NyIs7wo3lydwVAhHHQaWoEyaZIf2xoXXRbRpZRyczaoFJYFB2mYDp23VphEGTtKVyLoh 9y6jfszijt1I01c7xndCXv7nVRtlrAAL4OfBZcPnldgtcC1E76DgF+EoZhN/kHdOiH0+ upO1fmm/WCwNDeRzRJfUwW/h8bU0J6kIlFEdwQzJWysozSS5Sq0qYwbUxCoFFrGuWO8u nhSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pi3-20020a17090b1e4300b001f31da6b2d2si616220pjb.154.2022.12.20.18.59.26; Tue, 20 Dec 2022 18:59:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234296AbiLUCuw (ORCPT + 70 others); Tue, 20 Dec 2022 21:50:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229451AbiLUCus (ORCPT ); Tue, 20 Dec 2022 21:50:48 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25E402734; Tue, 20 Dec 2022 18:50:47 -0800 (PST) Received: from canpemm500004.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NcHwH1TRyzRq7G; Wed, 21 Dec 2022 10:49:35 +0800 (CST) Received: from [10.174.179.14] (10.174.179.14) by canpemm500004.china.huawei.com (7.192.104.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 21 Dec 2022 10:50:45 +0800 Subject: Re: [PATCH v2] scsi: libsas: Fix did not grab the ata port lock in sas_ata_device_link_abort() To: Xingui Yang , , , CC: , , , , References: <20221221015203.46367-1-yangxingui@huawei.com> From: Jason Yan Message-ID: Date: Wed, 21 Dec 2022 10:50:45 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20221221015203.46367-1-yangxingui@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.179.14] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To canpemm500004.china.huawei.com (7.192.104.92) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/12/21 9:52, Xingui Yang wrote: > Grab the ata port lock in sas_ata_device_link_abort() before calling > ata_link_abort(), as the comment in ata_link_abort() mentions. > > Fixes: 44112922674b ("scsi: libsas: Add sas_ata_device_link_abort()") > Signed-off-by: Xingui Yang > Reviewed-by: John Garry > --- > Changes to v1: > - Add a fixes tag > - Update commit message > --- > drivers/scsi/libsas/sas_ata.c | 3 +++ > 1 file changed, 3 insertions(+) Looks good, Reviewed-by: Jason Yan