Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Dec 2022 09:44:07 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     Ricardo Ribalda <ribalda@chromium.org>
Cc:     Christoph Hellwig <hch@lst.de>,
        Alan Stern <stern@rowland.harvard.edu>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] USB: Improve usb_fill_* documentation
Message-ID: <Y6Jy90O38E25QgN6@debian.me>
References: <20221220-usb-dmadoc-v2-0-4dd4f198113e@chromium.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="hNraL9BI9bJyuoZF"
Content-Disposition: inline
In-Reply-To: <20221220-usb-dmadoc-v2-0-4dd4f198113e@chromium.org>
Precedence: bulk


--hNraL9BI9bJyuoZF
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Dec 21, 2022 at 12:13:08AM +0100, Ricardo Ribalda wrote:
> Make the developer aware of the requirements of transfer buffer.
>=20
> The buffer must be DMAble, if the developer uses an invalid buffer, data
> corruption might happen.

Better say:

```
Document the transfer buffer requirement. That is, the buffer must be
DMAble - otherwise data corruption might occur.
```

> - * @transfer_buffer: pointer to the transfer buffer
> + * @transfer_buffer: pointer to the transfer buffer. Must be suitable fo=
r DMA.

"... The buffer must be ..."

> - * @transfer_buffer: pointer to the transfer buffer
> + * @transfer_buffer: pointer to the transfer buffer. Must be suitable fo=
r DMA.

Same here.

The rest is LGTM, thanks.

--=20
An old man doll... just what I always wanted! - Clara

--hNraL9BI9bJyuoZF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY6Jy8AAKCRD2uYlJVVFO
oyu4AP9RGvSyV5sX7yoqWF3dHrsRR+M4rQJ2i3D6CPVgp3/t9AD+Pmacn28PzDkQ
GL575b2RdKJ8bAecfEy3HFHXqCnW7QE=
=bOKJ
-----END PGP SIGNATURE-----

--hNraL9BI9bJyuoZF--