Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Dec 2022 12:28:39 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     "Joel Fernandes (Google)" <joel@joelfernandes.org>
CC:     <linux-kernel@vger.kernel.org>, Ben Segall <bsegall@google.com>,
        "Daniel Bristot de Oliveira" <bristot@redhat.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Ingo Molnar <mingo@redhat.com>,
        Josh Triplett <josh@joshtriplett.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Mel Gorman <mgorman@suse.de>,
        "Paul E. McKenney" <paulmck@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Valentin Schneider <vschneid@redhat.com>,
        "Vincent Guittot" <vincent.guittot@linaro.org>,
        <kernel-team@android.com>, John Stultz <jstultz@google.com>,
        Joel Fernandes <joelaf@google.com>,
        Qais Yousef <qais.yousef@arm.com>,
        Will Deacon <will@kernel.org>,
        Waiman Long <longman@redhat.com>,
        Boqun Feng <boqun.feng@gmail.com>,
        Connor O'Brien <connoro@google.com>
Subject: Re: [PATCH RFC 3/3] locktorture: Make the rt_boost factor a tunable
Message-ID: <Y6KLd0X0aJxxyNLJ@chenyu5-mobl1>
References: <20221123012104.3317665-1-joel@joelfernandes.org>
 <20221123012104.3317665-4-joel@joelfernandes.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221123012104.3317665-4-joel@joelfernandes.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4szjev4a54g/rvlZQZhZXSef2d/b1wL/Zm87+IrjbSVE/LIpv6fRRgO7jpxt?=
 =?us-ascii?Q?0xj9VxB8dodWQHXVD7M74F9lLBAn3p4e+MmUkaya5LV9errBE8Nj6KGWGVha?=
 =?us-ascii?Q?XmdVMBEP6eCn41iiNNEmvvLfIfgaIyS1xCm3sC7vivofAqO0O59/czyovD1B?=
 =?us-ascii?Q?HdvbBCQSu2hoOLSCIEq5Eef0GisJXUFwFbB743XvfouXE3Bi9iIUBUIQLm6r?=
 =?us-ascii?Q?qjMymWZhpe4DFgFwZP44ZEKgbzV6ZS8UQ55Ze2zazcx1g/h+Y2rFzowr0QFs?=
 =?us-ascii?Q?B5mHZaCl0wQHGoAXZhO/a5HzteW9OKxD5r5i3gLFGX7r4LMr+XOSJj5OHjtd?=
 =?us-ascii?Q?5cKP5hfnJvSw9wikDGkhJY9bUREv/LWcs+df8AFaOmb0NgD3qOwvBiiQQhKS?=
 =?us-ascii?Q?acfCKs5AxKhem0f8eG5pv4Hdd03CIMhBdP6ZxHZu7jJIK86byAok72SVt85u?=
 =?us-ascii?Q?BSS1xEKL7jsDoXF7Z2WAxYwzy4gKRpIP95hxcG7dx6RbDxqOz4jfjOULMO7A?=
 =?us-ascii?Q?0EpnQlorRZNBtqvUStaEyX44l10rsOmJj6p9ucyh4T526mVaJv9OGyGh02i/?=
 =?us-ascii?Q?SJt0N77w6oxnvxEjBa60gzB96RWYJFk3r0EKeiEF7SEAsIMsB3PsQ8aW1GZi?=
 =?us-ascii?Q?b8dSi83evkHAJUdRDHqOXRfM2f8q3saHDE56Y28IApcZaA3lmWaioL//TaUx?=
 =?us-ascii?Q?yP6KSwGrcyEQRiIEEKWEpWese+95/QoOHfh6DIOudlLlmjyeRGNkbjMqdimz?=
 =?us-ascii?Q?ICsUZtGOGDBcyhMeqnO0Rmhf8FEET8ynMpLPm+6URf2+XeKO8tsUznr+cEKr?=
 =?us-ascii?Q?bk3XiOmMYn224mQNaZSytBpgT3Xn2vxKon+zWVWRTUJkapx5YaTamhdXHDVy?=
 =?us-ascii?Q?ygramhkNFv8VF/Wab30Spf8kMijT0/2ynqaEKE8otKeGXkglrES8JC7DIel0?=
 =?us-ascii?Q?NnA6Cq0rpyW+2pR0593mh+WmyLyRnfauLnitKnIHolLCce1+WPX+wjJIkKQJ?=
 =?us-ascii?Q?jYNI/zWhjZnlIyiyibkTQNv2iQwMNOmqWyxfCxy0MxIyorl5/SRI3g9CApKZ?=
 =?us-ascii?Q?bT3fCKBzsfnW9OKGeyMi7isLJCHhflOqKcFKyoD5y55mfEFt5mHh3mlikqf8?=
 =?us-ascii?Q?DqcIzNfiCsggvrXGGwHi+AIwVI+GRwSrecrCAaPrIYnPejUn4v8LIm8xpf3C?=
 =?us-ascii?Q?QhZoKx1WO0Sxu7Hq8ZwiNhUHEJX47LIVZtsIMkHUgwzp0/jTZynCl/HgGp0/?=
 =?us-ascii?Q?JCt+VJ5pgWSGBSqwBJVJiOuLqSAvHOUa//xdp4TDPyrMmGqpqFqSqih0wc7F?=
 =?us-ascii?Q?01zpYfU2j1ZL8hrjhAkinKEhQVe/ilukci2ic6CD3XwXj8ABKwRfwrxC41P6?=
 =?us-ascii?Q?FMq4YjnLBtD/XeHWUbEJfcrXU9MrhVj0O6avJg/4OdwoQVBQom4RljlPrtQh?=
 =?us-ascii?Q?ibzcacceuSTd6e+VQr2WyQ9thwdQ68GXvICZ1n4On8nvSQk7tG2rxkV+WKTs?=
 =?us-ascii?Q?xEm8WJoJMTKxwwoyTNlkTyA3mdx2SiPje8Mrbww5hCggEUTIyoHsxQLI9kJj?=
 =?us-ascii?Q?ZAAsY2AXZxRKD5PbQOCcfHQlDMv6fzqtN8UH7XSq?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 623b4167-5ba2-449c-85ea-08dae30be0a6
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 04:28:58.1532
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i3GNN6SJpJ2NbGUVQQkNOn92lLiyeJNsXNMsKT1pf6o1NimgwMRQBJjK5UFDbQahEVwTl9yb+xCxnkGaawGJbQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB6289
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-11-23 at 01:21:04 +0000, Joel Fernandes (Google) wrote:
> The rt boosting in locktorture has a factor variable large enough that
> boosting only happens once every minute or so. Add a tunable to educe
> the factor so that boosting happens more often, to test paths and arrive
> at failure modes earlier. With this change, I can set the factor to
> like 50 and have the boosting happens every 10 seconds or so.
> 
> Tested with boot parameters:
> locktorture.torture_type=mutex_lock
> locktorture.onoff_interval=1
> locktorture.nwriters_stress=8
> locktorture.stutter=0
> locktorture.rt_boost=1
> locktorture.rt_boost_factor=50
> locktorture.nlocks=3
> 
> Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
> ---
>  kernel/locking/locktorture.c | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
> index 5a388ac96a9b..e4529c2166e9 100644
> --- a/kernel/locking/locktorture.c
> +++ b/kernel/locking/locktorture.c
> @@ -47,6 +47,7 @@ torture_param(int, stat_interval, 60,
>  	     "Number of seconds between stats printk()s");
>  torture_param(int, stutter, 5, "Number of jiffies to run/halt test, 0=disable");
>  torture_param(int, rt_boost, 0, "Perform an rt-boost from the writer, always 1 for rtmutex_lock");
> +torture_param(int, rt_boost_factor, 50000, "A factor determining how often rt-boost happens");
>  torture_param(int, verbose, 1,
>  	     "Enable verbose debugging printk()s");
>  torture_param(int, nlocks, 1,
> @@ -132,15 +133,15 @@ static void torture_lock_busted_write_unlock(int tid __maybe_unused)
>  
>  static void torture_rt_boost(struct torture_random_state *trsp)
>  {
> -	const unsigned int factor = 50000; /* yes, quite arbitrary */
> +	const unsigned int factor = rt_boost_factor; /* yes, quite arbitrary */
>  
>  	if (!rt_boost)
>  		return;
>  
>  	if (!rt_task(current)) {
>  		/*
> -		 * Boost priority once every ~50k operations. When the
> -		 * task tries to take the lock, the rtmutex it will account
> +		 * Boost priority once every rt_boost_factor operations. When
> +		 * the task tries to take the lock, the rtmutex it will account
>  		 * for the new priority, and do any corresponding pi-dance.
>  		 */
>  		if (trsp && !(torture_random(trsp) %
> @@ -150,8 +151,9 @@ static void torture_rt_boost(struct torture_random_state *trsp)
>  			return;
>  	} else {
>  		/*
> -		 * The task will remain boosted for another ~500k operations,
> -		 * then restored back to its original prio, and so forth.
> +		 * The task will remain boosted for another 10*rt_boost_factor
Maybe I understand incorrectly, the code is
cxt.nrealwriters_stress * factor * 2, should it be 2 rather than 10?
May I know where the 10 comes from?

thanks,
Chenyu