Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp5206016rwj; Tue, 20 Dec 2022 22:37:22 -0800 (PST) X-Google-Smtp-Source: AMrXdXvRBnXBaQJNyCSy5yLtv8WMeg0IzcrECzdFq87oZXb+P3wtq3qVsJ5dwupxWzzm6fLOe77v X-Received: by 2002:a17:907:8c0c:b0:7c0:ad62:a25f with SMTP id ta12-20020a1709078c0c00b007c0ad62a25fmr377396ejc.51.1671604642334; Tue, 20 Dec 2022 22:37:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671604642; cv=none; d=google.com; s=arc-20160816; b=TfAzVdFxyGby6wGn17ytEYq5j/S0LE6+Cn9GpwAVkGcK7y/JJndyMDjWiQLgQoAg9Q BqffjrTGQzBiMY7Q3GS3ByQJ6VAzP/d/GfNoMysDbkU+ShPQC2FhyKDSMseNgvKsYQAq UqprA7/JXHZ+BpOHxbhGRF+QvfTgcz8biOo2NWs93WdEd0xG0dBLIcJBfaNr7JJi11Le rq2NTXWwk+D217QdAQ4BX+q68nsN2S1A5AjoIyW3/IsEleutIH6OTd9hxAvsrvlKQEmC oQeomCDKyJzdpTWOmTS132cuIW5XrB6Jm7I412LEbc9KXPy3suSZIZStLCDC6f3yDncg AUag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xFARvs3vX7F5UIgsIk8mEBbeBoqPfv+G3BzvbbBHE5g=; b=MRHrWVHDDXWKZCiy6Bf+nNhO4J8NkjxklQS5Nx7tTgbxbYV3LtJsKg7GH29np8R3tL U4hTyYOD8FiejPZiLVjy7Ka5N4znz12f4P8RGR/f6Km3le3Oe2g/d2DqShlEfCoZgc5C aaPzKf4ZNMGoq18HLp2DVwOugEOvwSvChH/T5UFLeqCK8TSmDZB4Q2ABtTLdO4g+woPS KhDBl/9b8ye/XL5jFzE/dsoE0liQRtovoogM2zGzEP5Uh8/9bgiK8Vk4wtSMj5MctQcj Ndzt3oQg1DHFFMlDCGZ6KbkQK2e+aisU/rwjGRxuvPWZki8fWpaTQFoKN4ws2Ms0mAn8 od3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AxeJLbeC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id eg18-20020a056402289200b0046db4826047si11615227edb.341.2022.12.20.22.37.06; Tue, 20 Dec 2022 22:37:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=AxeJLbeC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234490AbiLUGDw (ORCPT + 69 others); Wed, 21 Dec 2022 01:03:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234466AbiLUGDr (ORCPT ); Wed, 21 Dec 2022 01:03:47 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4025921240 for ; Tue, 20 Dec 2022 22:02:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671602545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xFARvs3vX7F5UIgsIk8mEBbeBoqPfv+G3BzvbbBHE5g=; b=AxeJLbeC2q2KjRkpfVxrcacdHhLBz7P2AsCcEbfCXdrOMpugnn1z3IWZb75w/3QPqJwkt/ ydCbgEX34sAno8Obc3o2q3we963H7G6QJENs9RDZY+tX/loXAxC+xHUgmlniiXwINUvO1w XedjzOL49BH8VGHt219vTaeb1Iaiwy4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-540-H8M4KejGNnGeLNOea66BPA-1; Wed, 21 Dec 2022 01:02:22 -0500 X-MC-Unique: H8M4KejGNnGeLNOea66BPA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8B042858F09; Wed, 21 Dec 2022 06:02:21 +0000 (UTC) Received: from localhost (ovpn-12-50.pek2.redhat.com [10.72.12.50]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AFB5040C2064; Wed, 21 Dec 2022 06:02:20 +0000 (UTC) Date: Wed, 21 Dec 2022 14:02:17 +0800 From: Baoquan He To: Bjorn Helgaas Cc: Eric Biederman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , x86@kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: Re: [PATCH 0/2] kexec: Remove unnecessary arch hook Message-ID: References: <20221217155842.GA389338@bhelgaas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221217155842.GA389338@bhelgaas> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/17/22 at 09:58am, Bjorn Helgaas wrote: > On Sat, Dec 17, 2022 at 05:48:51PM +0800, Baoquan He wrote: > > On 12/15/22 at 12:23pm, Bjorn Helgaas wrote: > > > From: Bjorn Helgaas > > > > > > There are no arch-specific things in arch_kexec_kernel_image_load(), so > > > remove it and just use the generic version. > > > > I ever posted below patch to do the same thing, Andrew only picked the > > memory leak fixing patch. > > > > [PATCH v2 2/2] kexec_file: clean up arch_kexec_kernel_image_load > > https://lore.kernel.org/all/20220223113225.63106-3-bhe@redhat.com/T/#u > > Indeed! Sorry, I wasn't aware of your previous work. If you repost > it, cc me and I'll be glad to help review it. When tried to rebase my old patch to the latest kernel, I realized this patchset is what I can end up with. I would like to ack this patchset to make it merged. Thanks a lot for the effort.