Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp5333374rwj; Wed, 21 Dec 2022 00:53:56 -0800 (PST) X-Google-Smtp-Source: AMrXdXvThE4Yuz/pLLVYx3+ythqd3iJVvrIdyPh6tNY9qRc+/EBC8pPDn/eTHxiXo0mqADQRMHfF X-Received: by 2002:a17:907:2587:b0:7c0:e7ad:fb0f with SMTP id ad7-20020a170907258700b007c0e7adfb0fmr656319ejc.20.1671612835870; Wed, 21 Dec 2022 00:53:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671612835; cv=none; d=google.com; s=arc-20160816; b=gL1mnQiVaP4H6ErayFmYXLpkx9QpqXPSILeXa7v8kFy1p2HHxYl5XIT5uFD0spBBbw 0tnAUORNLqfiEjlmv10DpvTwicb3Q05HAKeCmR02kS05PvBszVZMcZdfYru82plHO3nC 1D0fflO61wmK7lSwD7G94QXo9COAAxydlXwZGuZWGIrdgpdQ7enRun1wiBOhEYAZ2OHJ /lu//mLv5cyT+L7O0tNlWEdi0I5nz/tpfbNNuAkBPX/TFr/3cs0ToTQVA89F8eFIYBCq SnO2YRCxuNY4NBHOzwAwI9nSDe5l62xz+vgHFukB+2omTSdiBF9Kpk+yIAfuhDpwkOOW 8tYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=GEujgPXyVUyXcR4f+rtL/Iiz4wUPIySdkUNBGuXBVMs=; b=icUoqrrtyLI1Pj/jN0vA6/LsJUQ3gM7z1aTRbmryQacoXCzUgzXUYCsOIgBmezG3o/ 8Nkg3uDwk+crX9WiFbT02nO2EEjknl3xsNGetUFrVL1xWGg976wcGsOI3rFR8TDcLT3G TW4GgXk3qX/zCG9GmfAPpp2jdFsgEQxYSCSKzWW/7Kpw0lEKY4xRTSgw642kdFwtgyYo zMAt7aVOt4cUeD8xY+FU6VFkixZF4qiaTe5LQAcnFsl7ynGV5qIz6A7zzcBhuBDJpltt i2/kWP0TyUSljo94TDz3ypXRHWlRHRN1rpOVb2PDAVFu02XYrLp8sByyNQomVIvL75+0 xp1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NA4C4PGk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p8-20020a17090635c800b007c0bc7057ddsi10422782ejb.909.2022.12.21.00.53.37; Wed, 21 Dec 2022 00:53:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NA4C4PGk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232082AbiLUI3J (ORCPT + 69 others); Wed, 21 Dec 2022 03:29:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229472AbiLUI3H (ORCPT ); Wed, 21 Dec 2022 03:29:07 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05E631DF37 for ; Wed, 21 Dec 2022 00:28:57 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9EAEDB811F6 for ; Wed, 21 Dec 2022 08:28:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10B3EC433D2; Wed, 21 Dec 2022 08:28:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671611333; bh=Rn7MkbT6UsUL4kZ1Ldi0pJvoV9nUIf59eDilGtdiyGw=; h=From:To:Cc:Subject:Date:From; b=NA4C4PGkWi8RDz0b2dTZ8emvF8Zrm4PoWOmwuHVjcC2ZIBB4/6ZuQZQXU/zMr+cTs LWX6ISoV264Bmh5eg43Q6lgpH20p1q5Eplyos2KuItFq4f+zD8RPf7jEap8D5h2PaQ +Vt0g5OGRanIugpUcGyRvfLW1pnULfoLIuH+rx+pXTCMPVB+Dxz2AhtxUiF+yTc7W+ CDXea5QpGP9H64BtmYXt1YgQxr3Vcz1B6TsTHS7RaTZ++rOuZRU5lu2C8tM6excYjc RTxPUCgxLwyx2dkxNRa0KziUTjDCxcxFz6N2reX0kuwbCUGAZbXjwmoJxmgHA/FN38 b2+a0pSSUEw+Q== From: Oded Gabbay To: linux-kernel@vger.kernel.org Cc: Ofir Bitton Subject: [PATCH 1/2] habanalabs/gaudi2: dump event description even if no cause Date: Wed, 21 Dec 2022 10:28:45 +0200 Message-Id: <20221221082846.3164-1-ogabbay@kernel.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ofir Bitton In order to have the no-cause error print be more informative, we add the event description in addition to the event id. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/gaudi2/gaudi2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/misc/habanalabs/gaudi2/gaudi2.c b/drivers/misc/habanalabs/gaudi2/gaudi2.c index 987ec44fa378..7df1a68dd403 100644 --- a/drivers/misc/habanalabs/gaudi2/gaudi2.c +++ b/drivers/misc/habanalabs/gaudi2/gaudi2.c @@ -9271,8 +9271,8 @@ static void gaudi2_handle_eqe(struct hl_device *hdev, struct hl_eq_entry *eq_ent if (error_count == GAUDI2_NA_EVENT_CAUSE && !is_info_event(event_type)) gaudi2_print_event(hdev, event_type, true, "%d", event_type); else if (error_count == 0) - dev_err_ratelimited(hdev->dev, - "No Error cause for H/W event %d\n", event_type); + gaudi2_print_event(hdev, event_type, true, + "No error cause for H/W event %u\n", event_type); if ((gaudi2_irq_map_table[event_type].reset || reset_required) && (hdev->hard_reset_on_fw_events || -- 2.34.1