Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Wed, 21 Dec 2022 10:33:29 +0100
Message-Id: <CP7E4XY0O87Z.1JFRPGL7BMGZ3@vincent>
Cc:     <rust-for-linux@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <patches@lists.linux.dev>
Subject: Re: [PATCH] rust: prelude: prevent doc inline of external imports
From:   "Vincenzo" <vincenzopalazzodev@gmail.com>
To:     "Finn Behrens" <fin@nyantec.com>,
        "Miguel Ojeda" <ojeda@kernel.org>,
        "Wedson Almeida Filho" <wedsonaf@gmail.com>,
        "Alex Gaynor" <alex.gaynor@gmail.com>,
        "Boqun Feng" <boqun.feng@gmail.com>, "Gary Guo" <gary@garyguo.net>,
        =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= <bjorn3_gh@protonmail.com>
References: <20221214093451.zdyhmdyxwz73n6pe@imap.mailbox.org>
In-Reply-To: <20221214093451.zdyhmdyxwz73n6pe@imap.mailbox.org>
Precedence: bulk

IMOHO this make sense.

Reviewed-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>=20

On Wed Dec 14, 2022 at 10:34 AM CET, Finn Behrens wrote:
> This shows exactly where the items are from, previously the items from
> macros, alloc and core where shown as a decleration from the kernel crate=
,
> this shows the correct path.
>
> Signed-off-by: Finn Behrens <fin@nyantec.com>
> ---
>  rust/kernel/prelude.rs | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/rust/kernel/prelude.rs b/rust/kernel/prelude.rs
> index 7a90249ee9b9..917721e791b6 100644
> --- a/rust/kernel/prelude.rs
> +++ b/rust/kernel/prelude.rs
> @@ -11,15 +11,21 @@
>  //! use kernel::prelude::*;
>  //! ```
> =20
> +#[doc(no_inline)]
>  pub use core::pin::Pin;
> =20
> +#[doc(no_inline)]
>  pub use alloc::{boxed::Box, vec::Vec};
> =20
> +#[doc(no_inline)]
>  pub use macros::{module, vtable};
> =20
>  pub use super::build_assert;
> =20
> -pub use super::{dbg, pr_alert, pr_crit, pr_debug, pr_emerg, pr_err, pr_i=
nfo, pr_notice, pr_warn};
> +// super::std_vendor is hidden, which makes the macro inline for some re=
ason
> +#[doc(no_inline)]
> +pub use super::dbg;
> +pub use super::{pr_alert, pr_crit, pr_debug, pr_emerg, pr_err, pr_info, =
pr_notice, pr_warn};
> =20
>  pub use super::static_assert;
> =20
> --=20
> 2.31.1