Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Damien Le Moal <damien.lemoal@opensource.wdc.com>
CC:     Jason Yan <yanaijie@huawei.com>,
        John Garry <john.g.garry@oracle.com>,
        Xingui Yang <yangxingui@huawei.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linuxarm@huawei.com" <linuxarm@huawei.com>,
        "prime.zeng@hisilicon.com" <prime.zeng@hisilicon.com>,
        "kangfenglong@huawei.com" <kangfenglong@huawei.com>
Subject: Re: [PATCH] scsi: libsas: Grab the host lock in
 sas_ata_device_link_abort()
Thread-Topic: [PATCH] scsi: libsas: Grab the host lock in
 sas_ata_device_link_abort()
Thread-Index: AQHZFIO30NsjJ+GmMUOn/YRyM/YoSq53f2GAgAAjbwCAABWFAIAAK2AAgAAgpYCAABQpAA==
Date:   Wed, 21 Dec 2022 09:44:09 +0000
Message-ID: <Y6LVaE5e9iZNAYrF@x1-carbon>
References: <20221220125349.45091-1-yangxingui@huawei.com>
 <4ec9dbed-1758-d6b4-dc1d-ac42e8c22731@oracle.com>
 <c8387766-2ca0-51f3-e332-71492b13e5c1@opensource.wdc.com>
 <7347d117-6e0b-dd18-90a8-25685f757689@huawei.com>
 <4ff0ca00-31f5-2867-ff59-cecb5d6d1048@opensource.wdc.com>
 <755d7a9c-427e-024a-8509-449ebc5a00e6@huawei.com>
 <f77c7872-3711-2216-c17c-e23591f745c7@opensource.wdc.com>
In-Reply-To: <f77c7872-3711-2216-c17c-e23591f745c7@opensource.wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5Lull3Lz5U48/xYqQvHAxttXgNQvFjx4JCzEf0sd1T8GTS1lR8N7PxVYmt2e?=
 =?us-ascii?Q?LEQPSu+L031N5RttkgNovSiCUryzYXQK8XslxMfQGUAa9VWcQtS6Q9grZznz?=
 =?us-ascii?Q?nlfKQPoKA2H9+8HsYW3sqy/ic6iez7/gwFjOfbcy3HgN4onLBomfvJsx4Gh0?=
 =?us-ascii?Q?NSQsSfVRI/5VBmhYgqydK1YqD6rYbon/hGG92zaJh6W9KxuxMeeWsibVxiKi?=
 =?us-ascii?Q?HMP3RGyTSsykrzFzev1VzdgEm1zeM3N5Wlsa1Me61XCRC4ZYeS/nR54o+rKd?=
 =?us-ascii?Q?fWgpJH4lfLRkHcJyH+K9RM9OIukNi/mJowJXHETC59XqONE04QMXJ8G2UWI0?=
 =?us-ascii?Q?2cBqU6RZ99C+ItyKAhuoLcFh5AW2R7dzqJFQa8wEJ7fIBcWjXIwkm4xk86UE?=
 =?us-ascii?Q?XvaPf8LcgBVCBgae6DQnMWu7vzCD7FvBliufNXMnU6FfzIjED64WfEDUC+Ii?=
 =?us-ascii?Q?vTaH1DRilSX2afBz28RYMhedKleYL5sAgEhPMY1n0l2RAdn6JUD5ovYwgmiP?=
 =?us-ascii?Q?qSg0GXOfQ2RPqGX8evdHufg3wlOegBbOH32lELrkbf0ZzyaNcnIS/+qNduYJ?=
 =?us-ascii?Q?L1epgY3fh8uvyB005C29Je+KpMjSrysIfX/PhQbN1daljVswhUy4ju8tNjs7?=
 =?us-ascii?Q?CdI5Az3dsZnrVjkJ22OH/c8xhpQop/3Ie+UWZJoJhZJpnIOxiwjsSQDdvuZc?=
 =?us-ascii?Q?wmFtd1WkOjdXjQ6qnJuMmcQKp5f1PEAOCySqsHJ70s79TV8QRtBUPlrdIQDI?=
 =?us-ascii?Q?7f7AbBnWxF02C0SMi36XX9qEoCHZ0NTjiuVFYIORZ49B7JTadtQPQYyDjtnm?=
 =?us-ascii?Q?YPpmZyzkBM3NwgnRuoRJe69RcF9DRrbJe7k4mCbKMzW80Rzuj076tFyu9T2B?=
 =?us-ascii?Q?1EUY/hsbNIyM+LZ67KkY2v7/il8+2QZNBYPB6Km3TSQUE96D0AhaR06na6Zz?=
 =?us-ascii?Q?kv49G/0W6OtvNuHvWxK0Mh2G7nl8B1IGywVDNVQHaL4eonMb+KqWaF9SY50A?=
 =?us-ascii?Q?TFqk6bPEesXKLvhBUsFBqPRNSLYMdj/1lmXeJdqW/R+zMf+BVZYBuHtfHTbc?=
 =?us-ascii?Q?TAtQqy11vD3FaAOeQUV+Vo/ovixuVeZDa1+PpoCMAUyRQIXvdNOxM1r4ai8D?=
 =?us-ascii?Q?o7hayWgGGCy+0fPBHIGK//TkK3CDCUmEDlBPzXm5WBf9mUGapO+YUQ+qg7zx?=
 =?us-ascii?Q?aWNsfPxANBNM8pIinX2m+m7d8avNwaQ6p7pWp8UlAxfBaixLG9xTDFQwR1gG?=
 =?us-ascii?Q?CDJUqeL54uPfwa69RlzsjyZF0buBieyWRtrMr5bYmVYeq0aYm/IEaTD/qXZQ?=
 =?us-ascii?Q?a/ettR/EhkdabGuFNkp8LmP6oMFclVqlgxKWzSNPOkKhoPvwfJFItBCASz80?=
 =?us-ascii?Q?kIGW1XZZDrbULp5EuksNWs9kjRTOrjMux9TbUUK9XJJUDc67+lqoILLq4XiH?=
 =?us-ascii?Q?YOqdpaMGvHW5zGKoRqbjIDA7EWZleqp0r5g6Md78En0iWlTeFJ075Cv+NJ+l?=
 =?us-ascii?Q?itlFkD3gZn9X/mtCe5iG2/Udfb96JjO20CqqgzEBnmODLGc5Y7kCr8EDEs88?=
 =?us-ascii?Q?h+URVEKYUEUlPH9jWQp51C74OrIkJpM7ZH0GHERAT7AckrnikXNEgVKVA4u5?=
 =?us-ascii?Q?JA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F3868AF68ABB744E9D3684C2BFAD596C@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: MN2PR04MB6272.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e19b6e84-08b7-4779-5c70-08dae337e8df
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2022 09:44:09.5536
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gPKUrOdV3oIHOcH6Sq7Uq15lT3z+gPtjvhymP1WguqHHsqiZah5PCrK2Ke+jK/+bpdEX+2gnqUDrXJVGZ8ynbQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB5787
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 21, 2022 at 05:31:59PM +0900, Damien Le Moal wrote:
> >=20
> > What about the interrupt handler such as ahci_error_intr()? I didn't se=
e
> > the callers hold the port lock too. Do they need the port lock?
>=20
> It looks like it is missing for ahci_thunderx_irq_handler() but that one
> takes the host lock. Same for xgene_ahci_irq_intr(), again no port lock
> but host lock taken. And again for ahci_single_level_irq_intr() for the
> non MSI case. For modern MSI adapters, the port lock is taken in
>=20
> For other cases, ahci_multi_irqs_intr_hard) takes the port lock.
>=20
> So it looks like ahci_port_intr() needs to take the lock and some
> cleanups overall (the host lock should not be necessary in the command
> path. But nobody seems to have issues with the "bad" cases... Probably
> because they are not mainstream adapters.
>=20
> Definitely some work needed here.

ahci_multi_irqs_intr_hard() takes the ap->lock before calling
ahci_handle_port_interrupt(), which calls ahci_port_intr(),
so I don't think there is any work needed for multi IRQ AHCI.

For ahci_single_level_irq_intr() the host lock is taken before
calling ahci_handle_port_intr(), so I don't see why we need any
extra work for single IRQ AHCI.


Remember, while the default is that:
	ap->lock =3D &host->lock;
see:
https://github.com/torvalds/linux/blob/v6.1/drivers/ata/libata-core.c#L5305

In case of MULTI MSI, the ap->lock is using its own lock:
https://github.com/torvalds/linux/blob/v6.1/drivers/ata/libahci.c#L2460


So what is it that needs to be fixed for AHCI?

I haven't looked at ahci_thunderx_irq_handler() and xgene_ahci_irq_intr()
so I can't speak for these.


Kind regards,
Niklas=