Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933661AbXHPQVL (ORCPT ); Thu, 16 Aug 2007 12:21:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1764833AbXHPQUt (ORCPT ); Thu, 16 Aug 2007 12:20:49 -0400 Received: from smtp.ocgnet.org ([64.20.243.3]:33346 "EHLO smtp.ocgnet.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764719AbXHPQUq (ORCPT ); Thu, 16 Aug 2007 12:20:46 -0400 Date: Fri, 17 Aug 2007 01:19:37 +0900 From: Paul Mundt To: Joe Perches , Andy Whitcroft Cc: Dave Jones , Linux Kernel , rolandd@cisco.com, Chas Williams , isdn4linux@listserv.isdn4linux.de, mikep@linuxtr.net, netdev@vger.kernel.org, swen@vnet.ibm.com, linux390@de.ibm.com, linux-s390@vger.kernel.org, jdike@karaya.com, user-mode-linux-devel@lists.sourceforge.net, user-mode-linux-user@lists.sourceforge.net, netfilter-devel@lists.netfilter.org, coreteam@netfilter.org, Randy Dunlap , Andrew Morton Subject: Re: drivers/infiniband/mlx/mad.c misplaced ; Message-ID: <20070816161937.GA15530@linux-sh.org> Mail-Followup-To: Paul Mundt , Joe Perches , Andy Whitcroft , Dave Jones , Linux Kernel , rolandd@cisco.com, Chas Williams , isdn4linux@listserv.isdn4linux.de, mikep@linuxtr.net, netdev@vger.kernel.org, swen@vnet.ibm.com, linux390@de.ibm.com, linux-s390@vger.kernel.org, jdike@karaya.com, user-mode-linux-devel@lists.sourceforge.net, user-mode-linux-user@lists.sourceforge.net, netfilter-devel@lists.netfilter.org, coreteam@netfilter.org, Randy Dunlap , Andrew Morton References: <20070815235825.GB17004@redhat.com> <1187224811.5906.55.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1187224811.5906.55.camel@localhost> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1817 Lines: 36 On Wed, Aug 15, 2007 at 05:40:11PM -0700, Joe Perches wrote: > $ egrep -r --include=*.c "\bif[[:space:]]*\([^\)]*\)[[:space:]]*\;" * > arch/sh/boards/se/7343/io.c: if (0) ; > drivers/atm/iphase.c: if (!desc1) ; > drivers/infiniband/hw/mlx4/mad.c: if (!err); > drivers/isdn/capi/capiutil.c: else if (c <= 0x0f); > drivers/net/tokenring/ibmtr.c: else if (ti->shared_ram_paging == 0xf); /* No paging in adapter */ > drivers/s390/scsi/zfcp_erp.c: if (status == ZFCP_ERP_SUCCEEDED) ; /* no further action */ > fs/hostfs/hostfs_user.c: if(attrs->ia_valid & HOSTFS_ATTR_CTIME) ; > net/netfilter/xt_u32.c: if (skb->len < 4 || pos > skb->len - 4); > sound/pci/au88x0/au88x0_synth.c: if (eax == 0) ; On Thu, Aug 16, 2007 at 02:18:40PM +0100, Andy Whitcroft wrote: > A couple of people suggested adding checks to checkpatch for trailing > semicolons on conditionals, where the conditional block may not be > actually conditional: > > if (err); > return err; > > While regression testing the changes, I ran these checks across the > whole of 2.6.23-rc3 and there appear to be 5 places where this is > occurs (above and beyond the IPv6 one which triggered this effort) > and a benign use which could be confused later which it seems safest > to fix. > > Following this email are 6 patches for these issues, relevant > maintainers cc'd. All against 2.6.23-rc3 > It looks like you may want to refine your search parameters to match the above, as there are at least a few cases where the space exists. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/