Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp5431825rwj; Wed, 21 Dec 2022 02:33:51 -0800 (PST) X-Google-Smtp-Source: AMrXdXusJusoae7FIsaNzvo2j1+0NtjMDWZv0Z/WmCU5mOAZkU9v3P7dtKdi7XdW+Uinuar8TQxO X-Received: by 2002:a17:907:d004:b0:7c0:f213:4485 with SMTP id va4-20020a170907d00400b007c0f2134485mr841762ejc.73.1671618831780; Wed, 21 Dec 2022 02:33:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671618831; cv=none; d=google.com; s=arc-20160816; b=s/YhHw+1uPrHgMcgIrwUEiW5ZaJTG88P4FvfH9TTngwITwPh0IHeagTmuYmsUSSLQE mmqBonrhikQjhd4Gmxjpm6X6yiXAWiP8TrfGjoKJwUY+g/GouTpPBW7iMa6G4FEc7XoB VvuGd8ZAW5cjiLpluWLp+Ep/DWAkdp2QwC1qEe64w6FYm9XYy1sGNgGnGHSZcAh6Spo8 h3VEbkfhdMsBUJ4xSaPPXVbu8MsbbUBaiO5FwXNEzv1JHTNcjgMT0LRpT9gACLFp6fe3 nCpkWOpnHnouMyhp4ZkVsMez9iuWLkTp4VVmDExuwfp1UmCq26UPawu8hrGkV5roSy7p ryNw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ejmzE0+gt6sbqJx4ubFmKEMWFy6oPY+65/ra5E7kQbw=; b=iUu6hGFlpYyW5/mvb/UTjo59LHa/zq/0jcjbFF/ejSY58+/l7QagT3Wz3JwT3F/ieB G+9W4xjOD9zvOT/ZDB0hIY3Sczym69UHax8FKwY9mhJ+p6lvCq6jjOnqQDhVtTk7O2Jl Zd5k3iMBaQRH7pcRVnoQgsiTekU1WNiSMiyyAJAcdD8RGbt44w7r3V7IdDtHGS8IpSQC ZJU7yQmJlypwixsWmgknfho8xIN2pKTyPrUnnM+jmcicmhbEoRIzs+YypPCOxzMTeVh/ SJ6rNgh1LmeO5QcVlGYd9k4v2ccBnkRW4jSq2REwdWhN72GrU4jj6lRfbVfiQnxkQYwv Nlpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ho2NGsQ1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y11-20020a056402270b00b00479bca1a9d7si7889687edd.444.2022.12.21.02.33.35; Wed, 21 Dec 2022 02:33:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=ho2NGsQ1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234468AbiLUKLo (ORCPT + 69 others); Wed, 21 Dec 2022 05:11:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232975AbiLUKLm (ORCPT ); Wed, 21 Dec 2022 05:11:42 -0500 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3262BB5; Wed, 21 Dec 2022 02:11:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671617502; x=1703153502; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=dYD+UOcopJsu69rx7QvL08so4v21YBItNo/dRI4ekMA=; b=ho2NGsQ163r/HmBwTLdePkULKfGUx6F9jDZ2Ynd8ppBmXy7N7ATYKGwh rQ2LFG1Yemiqp1T9HO2U/apIHZG56OhUtpLXlMqQBB1PLyzq8p5Vm95Lo BtZRiJU+WOEPx+4aJzqUU9/XCoCwULRk38EzRmZaQxF297ZE/IClXf51R 60y3xAo7NT/lJGJ9MxhRKuVmbFBK3v5SskpROhsCPu6aplCouvVEV3pQL jMl1jxTl6kZHozNKSMEdyOmmmsXb8Yc45AZRcEsa+wJkJKKIbr1sAsx2B vlloLZvMzM0aSD8T1tkoEkto9MoOW5GWbEIbM8bjn6Uh5rdh/LPX0f9L0 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="321014536" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="321014536" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2022 02:11:41 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10567"; a="793653088" X-IronPort-AV: E=Sophos;i="5.96,262,1665471600"; d="scan'208";a="793653088" Received: from unknown (HELO localhost.localdomain) ([10.237.112.144]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Dec 2022 02:11:38 -0800 Date: Wed, 21 Dec 2022 11:11:29 +0100 From: Michal Swiatkowski To: Aaron Conole Cc: netdev@vger.kernel.org, Pravin B Shelar , Jakub Kicinski , "David S. Miller" , Paolo Abeni , Eric Dumazet , Thomas Graf , dev@openvswitch.org, Eelco Chaudron , Ilya Maximets , wangchuanlei , linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: openvswitch: release vport resources on failure Message-ID: References: <20221220212717.526780-1-aconole@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221220212717.526780-1-aconole@redhat.com> X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 20, 2022 at 04:27:17PM -0500, Aaron Conole wrote: > A recent commit introducing upcall packet accounting failed to properly > release the vport object when the per-cpu stats struct couldn't be > allocated. This can cause dangling pointers to dp objects long after > they've been released. > > Cc: Eelco Chaudron > Cc: wangchuanlei > Fixes: 1933ea365aa7 ("net: openvswitch: Add support to count upcall packets") > Reported-by: syzbot+8f4e2dcfcb3209ac35f9@syzkaller.appspotmail.com > Signed-off-by: Aaron Conole > --- Looks good, thanks Reviewed-by: Michal Swiatkowski > -- > 2.31.1 >