Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <32ae9221-0b5c-f12e-4795-5fe1f725cb2c@kernel.org>
Date:   Wed, 21 Dec 2022 20:16:36 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.6.1
To:     Yangtao Li <frank.li@vivo.com>, jaegeuk@kernel.org
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
References: <20221220115602.6715-1-chao@kernel.org>
 <20221221035931.41027-1-frank.li@vivo.com>
Content-Language: en-US
From:   Chao Yu <chao@kernel.org>
Subject: Re: [PATCH] f2fs: remove unused PAGE_PRIVATE_ATOMIC_WRITE
In-Reply-To: <20221221035931.41027-1-frank.li@vivo.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 2022/12/21 11:59, Yangtao Li wrote:
>>   PAGE_PRIVATE_GET_FUNC(reference, REF_RESOURCE);
>   
>>   PAGE_PRIVATE_CLEAR_FUNC(reference, REF_RESOURCE);
> 
> Delete those two too?

Oh, thank for checking PAGE_PRIVATE_REF_RESOURCE's usage, I found we
need clear_page_private_reference(), see “[PATCH] f2fs: fix to call
clear_page_private_reference in .{release,invalid}_folio”

Thanks,

> 
> Otherwise, looks good to me.
> 
> Thx,
> Yangtao