Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ce8c2208-b4a2-70ea-bf87-a2baba292a28@quicinc.com>
Date:   Wed, 21 Dec 2022 17:57:52 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH 1/2] dt-bindings: clock: SC7280: Add resets for LPASS
 audio clock controller
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <swboyd@chromium.org>, <agross@kernel.org>, <andersson@kernel.org>,
        <robh+dt@kernel.org>, <broonie@kernel.org>,
        <quic_plai@quicinc.com>, <krzysztof.kozlowski+dt@linaro.org>,
        <konrad.dybcio@somainline.org>, <mturquette@baylibre.com>,
        <sboyd@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-clk@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <quic_rohkumar@quicinc.com>
References: <1671618061-6329-1-git-send-email-quic_srivasam@quicinc.com>
 <1671618061-6329-2-git-send-email-quic_srivasam@quicinc.com>
 <f138f9de-4ecf-3126-97bd-668c96612913@linaro.org>
 <b6172e20-114a-b7e2-2200-0932f803cb20@quicinc.com>
 <5ff6e569-ad9f-f884-ea0e-41114afcaf7d@linaro.org>
From:   Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>
Organization: Qualcomm
In-Reply-To: <5ff6e569-ad9f-f884-ea0e-41114afcaf7d@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 12/21/2022 5:54 PM, Krzysztof Kozlowski wrote:
> On 21/12/2022 13:22, Srinivasa Rao Mandadapu wrote:
>> On 12/21/2022 4:12 PM, Krzysztof Kozlowski wrote:
>> Thanks for your time Krzyszto!!!
>>> On 21/12/2022 11:21, Srinivasa Rao Mandadapu wrote:
>>>> Add support for LPASS audio clock gating for RX/TX/SWA core bus clocks
>>>> for audioreach based SC7280 platforms.
>>> Use subject prefixes matching the subsystem (git log --oneline -- ...).
>>> The final prefix should be "qcom,sc7280-lpasscc" and then the actual
>                                  ^^^^^^^ it's written here
>
>>> subject should drop redundant pieces.
>> Sorry. I didn't understand much from your statement.
>>
>> Do you mean subject should something like below?
>>
>>    dt-bindings: clock: qcom: sc7280-lpasscc: Add resets for audio clock
>> controller
> 1. The last prefix should be "qcom,sc7280-lpasscc:".
> 2. And then drop "audio clock controller" because it is obvious, isn't it?
Okay!. Thanks for clarifying. I will change accordingly. Actually I 
followed previous similar commits.
>
>>>>    ...
>>> Best regards,
>>> Krzysztof
>>>
> Best regards,
> Krzysztof
>