Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp5582282rwj; Wed, 21 Dec 2022 04:40:32 -0800 (PST) X-Google-Smtp-Source: AMrXdXvlKAlUChJvDoOr1amYPRImpUHCnCKdCtukDep1pdHH3qTxQ0I0oLi270WdZbdUaQjE3TLK X-Received: by 2002:a05:6402:34f:b0:461:7c4e:c437 with SMTP id r15-20020a056402034f00b004617c4ec437mr1431007edw.1.1671626432201; Wed, 21 Dec 2022 04:40:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671626432; cv=none; d=google.com; s=arc-20160816; b=DFvUeMysa4ubAHSVk5ZFz2pAYvLdKGs7wEgycMgE83bc1cVO3OdvnFc+vGwg3LLUlb MJDcRgi7K/pMvfR6iPNsC8C6vVWLv4vrVu/Ntkl/V8zsquyIQvVND892MLYHskjtc+dH 6sqvmCBh5AT7M9Z5PISqHAgKlshpgbEyMIMqtrGjf5HtvlkD+Byst2vVDiedMkkQSGIf RfUdob04h0eNYZmEJ6gkwXy/lZN7d5aVAtVeBubV70iPBuP5qWbi0zmNprnP1POoT5hX 8SS5NfIAEedPv+eIfSSVWv6hC5BhPMggRBy5qBw+9R2E/fG+OPNSnMTmnG/FKk6KwLF2 8Cgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=fRZOrty5MgfXDX5Qq5G+s7U6FuXGETTST3AS0wLJyjE=; b=d444jA8l2Y1eeoczTCPUKh3Ew5MU28JM3w642rFBYuU7hwyX9iowLp3Njs/FVXqPqb rTwp9bnhBCYorCPmqWvu8SJXyRt3hrxFhONo9eD4tOKNhyxhgsUT6SAD+FHR5t6lUHox rQBVmwIVQAVEDHr9YOFsCZTzDj8NcHEfeaT0XCAOUZRTN1zhiKvWyr6BSAclBrocqrmL FCeaNdn4/RMVun0eJfCNJU3hIukms6h9OWC3E+uDQN4bt/BtNv08yV4XN1tN8rW2Eq1h ItDRM6OTz5wK/6NfUW2qIP1ox5fo3t/89zhBsORG2V94z+KOhXqpije3iquxh0CDDZ1h y1VQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=w9bW7mJQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c20-20020a05640227d400b0046af62544a0si3149289ede.401.2022.12.21.04.40.16; Wed, 21 Dec 2022 04:40:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=w9bW7mJQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231263AbiLUMaT (ORCPT + 69 others); Wed, 21 Dec 2022 07:30:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231550AbiLUMaQ (ORCPT ); Wed, 21 Dec 2022 07:30:16 -0500 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 753A723159 for ; Wed, 21 Dec 2022 04:30:15 -0800 (PST) Received: by mail-lj1-x22a.google.com with SMTP id n1so15475638ljg.3 for ; Wed, 21 Dec 2022 04:30:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fRZOrty5MgfXDX5Qq5G+s7U6FuXGETTST3AS0wLJyjE=; b=w9bW7mJQ98C/1sGABi6FE2EoLYodXp1Ksn/JipkCzZfM889fycz/RIRqNqm44kiCWB 1sbFIoW6x3xebfswBOAaLnKnLXONK8QGGKC1mSjSA/qXNKUdath+1GDuPieQjAP1QDjX hPB4UBehx0gYO0kOMcA8sty7QwKWZ37V0TvJ5U4iVCIOAeG9MDiISrARxKiYbrtLfJlJ u9tDXRVUU+pCQn4axbnhUROiNqY25nUl87nu70F+WaUjsfQvcFGBTgSUIbLM0DcOQ0jB gEAw+M8S6wgJYdQNfugQaMMyMjHCp3wGFw7VB68jrdLPB0nsT81i8DcWxfUx8Rxn0hQ1 rOGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fRZOrty5MgfXDX5Qq5G+s7U6FuXGETTST3AS0wLJyjE=; b=qMJCGrx6qhKer+s1KhGeY5K/rnpahaTUWdyd5FYiHvf4wgH2OVLHI1FXatHYTLW+IH /rjMNVhtdnPOHNp7pMa08n3of7bgRVzHE3MyMPRKQhX0BuHcPVLVlUJn1Uc0qm6PTtL0 p73CK5gr+0VNxXMygBMST+kryYdcfK+xWYgo96KQlgDBpTFBGV6w8Iwo8fETHUl3EYca DndRCFhLfqFcnr6ZYMyiuZ3mTkl0hcEXC3+O18C/4aAjODp14TgjPN9yk1c/1adEdns9 Lg/G/PkZIHQ48+mzhOUPDDxRzZ9vYnzu1K8Pa4ElnyMJgFGQRjG6118IDhemd0ScYvu8 5ytA== X-Gm-Message-State: AFqh2koAraGT1jT/zzsVOOfa2Fi1nYZEV2HPYti0QRGq9K1tfSqtHXT4 VMGUJdW76znCmjAgeWPDhhLLKA== X-Received: by 2002:a2e:f19:0:b0:277:3de:f78a with SMTP id 25-20020a2e0f19000000b0027703def78amr379185ljp.27.1671625813877; Wed, 21 Dec 2022 04:30:13 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id m23-20020a2e97d7000000b0027973ba8718sm1284085ljj.37.2022.12.21.04.30.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Dec 2022 04:30:13 -0800 (PST) Message-ID: <5c0e7f2f-94e1-c6d4-d848-f90e29eead10@linaro.org> Date: Wed, 21 Dec 2022 13:30:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs Content-Language: en-US To: Andrei Stefanescu , Chester Lin , Rob Herring , Linus Walleij , Krzysztof Kozlowski , =?UTF-8?Q?Andreas_F=c3=a4rber?= Cc: dl-S32 , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Larisa Ileana Grigore , "Ghennadi Procopciuc (OSS)" , Matthias Brugger References: <20221221073232.21888-1-clin@suse.com> <20221221073232.21888-2-clin@suse.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/12/2022 13:28, Andrei Stefanescu wrote: > Hi Chester, > >> +patternProperties: >> + '-pins$': > > Sorry, I missed this in the previous versions. Could you change it to '_pins' (underscore)? In our .dts files we use underscore in the names for pinctrl configuration nodes e.g. i2c4_pins, usbotg_pins. You cannot have underscores as node names, so what do you mean here? You need to fix your DTS not introduce bad practices to mainline kernel. Best regards, Krzysztof