Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <191928a9-ef60-e274-6678-963b187752ec@amd.com>
Date:   Wed, 21 Dec 2022 18:00:48 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH V2 1/4] ASoC: amd: ps: implement api to retrieve acp
 device config
Content-Language: en-US
To:     broonie@kernel.org, alsa-devel@alsa-project.org
Cc:     Basavaraj.Hiregoudar@amd.com, Sunil-kumar.Dommati@amd.com,
        Mario.Limonciello@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>,
        Syed Saba Kareem <Syed.SabaKareem@amd.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20221221112611.1373278-1-Vijendar.Mukunda@amd.com>
From:   "Mukunda,Vijendar" <vijendar.mukunda@amd.com>
In-Reply-To: <20221221112611.1373278-1-Vijendar.Mukunda@amd.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TmNmenlPOWRiSTJmZ0RaTHJuaDV5N0FPU3Y4TEpTYkFBc2V3Rmx3U0FxZW03?=
 =?utf-8?B?OTkrbHNVdnVaeTNoT0hXQktWZ0owNU80bWlPdk5JbnVTaU5YUEMrSjBxUUl1?=
 =?utf-8?B?bmUvL2lwK1R1Q3BVYzZLdUJPY21TaWdiRW4vcG82VS9UU2xycW5EOE1kRVJI?=
 =?utf-8?B?a2w5NldzY2pvYkN1SHNKMFcvNHFqRzErYmlXVXFjQ1I1eXdsQkQ5RHI5SXIv?=
 =?utf-8?B?LzdQM2dZVWdLWGdiU2ljcWlqZ2toanJYbXR4UFhYd2lBZG12czFEYy8yUXFm?=
 =?utf-8?B?MXhVQjRZTE5MbWFvRUM5UkxUY25YVUtxSEIvdGtCMWQvTzMrSGNiRkwvclRM?=
 =?utf-8?B?U0hCZmlNVExYdkdhbkwyeFQ4eWw4WmhKMkZsYzhUTXIvRU9MMHpOS1Y0MWdl?=
 =?utf-8?B?WjBIaVZvOHRsME1tT2JOdzZGeHVVa1M4dXpRd29palgvNCtSRTlIWVM4NXlJ?=
 =?utf-8?B?SkM1dDh3N0RXN294bTFSMnFEazNMRC8zbVVVWDZHU2RjdVFFYzFsVVpzZDFh?=
 =?utf-8?B?VnMvSjIxWVE1QTd2S0R3akRBYkZwczVNYUNkVGxkR0d1Q3A0QU9heUhVdk1H?=
 =?utf-8?B?TmFkdnducHIrYjdYcE5XTG1NSy9MSHl0MTIzVXFYQWZvWjJrek9oQWlFb1dy?=
 =?utf-8?B?c21ZN3pJeXpJSy93bkN0RDBTTmhPVnFJNzhoc3JOSVJMSkFjaTd5REVFcC8y?=
 =?utf-8?B?eEpJMnlPS2k3bUxkZmxCL2N3VkdWVERzS25zeU1uTUFFcUNETjd0ZmpKemRz?=
 =?utf-8?B?ZkQwMGQzT3NuRm0rKzRHdWxTZ1lQQzF3VXYxcGsxcHVDQTRJQ1RRWDFnSXRj?=
 =?utf-8?B?OWJhNlpwcENnR2lOSDN6VUFYZDNkWUxtbUhtNkJuSnB4bG9pQWI5cVdsdTNm?=
 =?utf-8?B?eVFZQi9JMGNOVjRZOElTOUJPODB0d3ZJVGY3R3MyZ2ZBOUNxUVpvdFFkZnFs?=
 =?utf-8?B?aXY4bjhYT1JXeEx3RlQ2QndOZjk5dHNoblQ0clcxeW1CWXV1bys0RnBLMkVr?=
 =?utf-8?B?UlZ6STM3ekg4YUxRbEIyWXJYL3F2bzd3T3M4eHlYOHM2cXZ3bExaYU83dStv?=
 =?utf-8?B?VXNEMWNDSUttSmUya09mK2JML1I5aHRCeVprSjRkWFdIOWhPRHJmdE0zZndT?=
 =?utf-8?B?cFlhY09oSFI3VzRHQkQ0UlBjRUk0d3RuRk1DZW1oM2c4MGljcnNqSkZVdkcw?=
 =?utf-8?B?SlVEZW9sbktEWm9MZ0Z5cG52Wk1OWFJkM3h6bzFITVZra2RQYlJxT0xIbXZo?=
 =?utf-8?B?Q0ZWc1duUW1EL1pUNjNZM2NwdlNzWUtUME1NRFVTamFjTXNPcE5YSUw5U0ho?=
 =?utf-8?B?Umd2d0g1bVY4UGFWaFdqMDh4L3BNOXc0Tms2MkRUeUh3b0JLNlFsajNjWExO?=
 =?utf-8?B?UnVacDZKRGVlN2VCWk9DNXBMYmxwVDA4UnlrZkNad25GUGtadllPSWZDaVAw?=
 =?utf-8?B?Z3hPVHZOZDdhVXovRnlXOUQ5dzBvZm5vWnBpWGR1YVE4QjlPZTcxck9uSDVQ?=
 =?utf-8?B?dXkxdGNiWmdzM0xCL2hOUnZrb3pUM1AwRjVKTFl6ZjFPRVo5R29pT3NRa3FD?=
 =?utf-8?B?UHczUkFOdlZsMEhLTm1qa25HU2xQQ3V4c0tSejJVTEpEVnNnelJXUXphVFUv?=
 =?utf-8?B?UC80TEw1NmZIc0U0aXc2b2NMVTV6dUNiQkg4ckVoSzJZK2VadEV0SlFaRUdW?=
 =?utf-8?B?bmYxUDJ1NWM2bmZ0aEtQWi9ZTUthcE41clpZNkR2Sk0vQWErbHJmQWIyTGRE?=
 =?utf-8?B?djBvMS9kRWZGTHpqTTZFc2hWS2JsVDUxMithcDREdTVEZU1NWFZCOEg1NlB2?=
 =?utf-8?B?VmU1Y1YrVDZJOWwvUDFFZy9pVVZKajdaWjczNHFxR1R6eFVuazI3RDMrUlFP?=
 =?utf-8?B?K0JmRlNaSmdVTU5rU1REMnNNNTcyTVF5VjFyQnErKzRjWUhlYWs2Szg5VWpX?=
 =?utf-8?B?QThZc3hrN0RuejZmL0hLOURpNXBoN1hyUmtyd0xQUVZpb2NqL0RFdndvVDE4?=
 =?utf-8?B?N2N3azNMZ0xxWElnWThrc0p0SEhQbEplNTNXZnFQL1d5WUZoZ213R3QrMWtn?=
 =?utf-8?B?eHY2Z2EvTlNuLzU1bTl0ZHh4YVNXM292MVFQZ3Z0M2ltUDZRaUlHWmhqWWJz?=
 =?utf-8?Q?F+8HRTyxm1xJjxnuDRcheYKdc?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f1369e9c-9eb9-4d0f-ca73-08dae34ed624
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB4123.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 12:28:16.9641
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LBk6TMKozWhCPBi2TCcbLLcvQeNYCJ+2bqEAiLkuGxuIy2xf8a9Wnzwmb+HvmlSfc14YUCPr0l3H/yROE9Q68g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4520
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 21/12/22 16:56, Vijendar Mukunda wrote:
> Implement API to retrieve acp device config and calculate platform
> device count and dev mask for platform device node creation.
>
> Currently for DMIC configuration, mask and dev count are calculated.
> Same api will be used to extend support for different ACP device
> configurations.

By mistake, patch series was sent as V2 instead of V1.
>
> Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
> ---
> v1->v2:
>     - used ACP_DMIC_DEV macro instead of hard coded value
>     - changed is_dmic_dev variable initialization
>     - changed debug level
>
>  sound/soc/amd/ps/acp63.h  |  7 +++++++
>  sound/soc/amd/ps/pci-ps.c | 37 +++++++++++++++++++++++++++++++++++--
>  2 files changed, 42 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/amd/ps/acp63.h b/sound/soc/amd/ps/acp63.h
> index 5e7f9c1c1b0e..b015e845e5fa 100644
> --- a/sound/soc/amd/ps/acp63.h
> +++ b/sound/soc/amd/ps/acp63.h
> @@ -54,6 +54,11 @@
>  /* time in ms for runtime suspend delay */
>  #define ACP_SUSPEND_DELAY_MS	2000
>  
> +#define ACP63_DMIC_ADDR		2
> +#define ACP63_PDM_MODE_DEVS		3
> +#define ACP63_PDM_DEV_MASK		1
> +#define ACP_DMIC_DEV	2
> +
>  enum acp_config {
>  	ACP_CONFIG_0 = 0,
>  	ACP_CONFIG_1,
> @@ -102,4 +107,6 @@ struct acp63_dev_data {
>  	struct resource *res;
>  	bool acp63_audio_mode;
>  	struct platform_device *pdev[ACP63_DEVS];
> +	u16 pdev_mask;
> +	u16 pdev_count;
>  };
> diff --git a/sound/soc/amd/ps/pci-ps.c b/sound/soc/amd/ps/pci-ps.c
> index 489f01a20699..9066a625e501 100644
> --- a/sound/soc/amd/ps/pci-ps.c
> +++ b/sound/soc/amd/ps/pci-ps.c
> @@ -132,6 +132,38 @@ static irqreturn_t acp63_irq_handler(int irq, void *dev_id)
>  	return IRQ_NONE;
>  }
>  
> +void get_acp63_device_config(u32 config, struct pci_dev *pci, struct acp63_dev_data *acp_data)
> +{
> +	struct acpi_device *dmic_dev;
> +	const union acpi_object *obj;
> +	bool is_dmic_dev = false;
> +
> +	dmic_dev = acpi_find_child_device(ACPI_COMPANION(&pci->dev), ACP63_DMIC_ADDR, 0);
> +	if (dmic_dev) {
> +		if (!acpi_dev_get_property(dmic_dev, "acp-audio-device-type",
> +					   ACPI_TYPE_INTEGER, &obj) &&
> +					   obj->integer.value == ACP_DMIC_DEV)
> +			is_dmic_dev = true;
> +	}
> +
> +	switch (config) {
> +	case ACP_CONFIG_0:
> +	case ACP_CONFIG_1:
> +	case ACP_CONFIG_2:
> +	case ACP_CONFIG_3:
> +	case ACP_CONFIG_9:
> +	case ACP_CONFIG_15:
> +		dev_dbg(&pci->dev, "Audio Mode %d\n", config);
> +		break;
> +	default:
> +		if (is_dmic_dev) {
> +			acp_data->pdev_mask = ACP63_PDM_DEV_MASK;
> +			acp_data->pdev_count = ACP63_PDM_MODE_DEVS;
> +		}
> +		break;
> +	}
> +}
> +
>  static int snd_acp63_probe(struct pci_dev *pci,
>  			   const struct pci_device_id *pci_id)
>  {
> @@ -183,6 +215,7 @@ static int snd_acp63_probe(struct pci_dev *pci,
>  	if (ret)
>  		goto release_regions;
>  	val = acp63_readl(adata->acp63_base + ACP_PIN_CONFIG);
> +	get_acp63_device_config(val, pci, adata);
>  	switch (val) {
>  	case ACP_CONFIG_0:
>  	case ACP_CONFIG_1:
> @@ -195,14 +228,14 @@ static int snd_acp63_probe(struct pci_dev *pci,
>  	default:
>  
>  		/* Checking DMIC hardware*/
> -		adev = acpi_find_child_device(ACPI_COMPANION(&pci->dev), 0x02, 0);
> +		adev = acpi_find_child_device(ACPI_COMPANION(&pci->dev), ACP_DMIC_ADDR, 0);
>  
>  		if (!adev)
>  			break;
>  
>  		if (!acpi_dev_get_property(adev, "acp-audio-device-type",
>  					   ACPI_TYPE_INTEGER, &obj) &&
> -					   obj->integer.value == 2) {
> +					   obj->integer.value == ACP_DMIC_DEV) {
>  			adata->res = devm_kzalloc(&pci->dev, sizeof(struct resource), GFP_KERNEL);
>  			if (!adata->res) {
>  				ret = -ENOMEM;