Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20221221074047.233473-1-umang.jain@ideasonboard.com>
References: <20221221074047.233473-1-umang.jain@ideasonboard.com>
Subject: Re: [PATCH] staging: vchiq_arm: Remove extra struct vchiq_instance declaration
From:   Kieran Bingham <kieran.bingham@ideasonboard.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Adrien Thierry <athierry@redhat.com>,
        Stefan Wahren <stefan.wahren@i2se.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Umang Jain <umang.jain@ideasonboard.com>
To:     Umang Jain <umang.jain@ideasonboard.com>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-rpi-kernel@lists.infradead.org, linux-staging@lists.linux.dev
Date:   Wed, 21 Dec 2022 12:33:22 +0000
Message-ID: <167162600273.3944359.9522944722768752331@Monstersaurus>
User-Agent: alot/0.10
Precedence: bulk

Quoting Umang Jain (2022-12-21 07:40:47)
> Additional declaration of struct vchiq_instance was introduced in the
> commit 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to
> service callbacks"). Drop the extra declaration.
>=20
> Fixes: 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to service =
callbacks")
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>

It's tempting to move the other instance up to near the top of the file
too, but not necessary.

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

> ---
>  drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h | 2 --
>  1 file changed, 2 deletions(-)
>=20
> diff --git a/drivers/staging/vc04_services/include/linux/raspberrypi/vchi=
q.h b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h
> index 66965da11443..52e106f117da 100644
> --- a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h
> +++ b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h
> @@ -78,8 +78,6 @@ struct vchiq_service_params_kernel {
>         short version_min;   /* Update for incompatible changes */
>  };
> =20
> -struct vchiq_instance;
> -
>  extern int vchiq_initialise(struct vchiq_instance **pinstance);
>  extern int vchiq_shutdown(struct vchiq_instance *instance);
>  extern int vchiq_connect(struct vchiq_instance *instance);
> --=20
> 2.38.1
>