Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp5620472rwj;
        Wed, 21 Dec 2022 05:08:48 -0800 (PST)
X-Google-Smtp-Source: AMrXdXt63wmiPt+k7lGOTGn8D0Dqjw/v/TaRV+zBJD+OQNBDNHXsh472te56vN7W2ZM5FGSyMeB9
X-Received: by 2002:a17:902:da86:b0:188:f570:7bdf with SMTP id j6-20020a170902da8600b00188f5707bdfmr2753250plx.40.1671628128364;
        Wed, 21 Dec 2022 05:08:48 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1671628128; cv=none;
        d=google.com; s=arc-20160816;
        b=qmf3uCX41tKvMVHpNpNM2svdkolCg8pEYEBm0uDIBkFXcy3h/+BZjSRMU2XTk0NvBR
         OTOrtdz9xho71V+Z+SGgptz9m+Wiyou9SfNKyMX/ePhxpm4PoNOWT2B3+XzwA44cmRpP
         N++vTDdznQTuh+aU5Xn9jRPD9Jpwe9K2NrNSY/dz7cl6yGEH8a6xyR3djmdHXXESntko
         778mGWBfrOXcao3JgqUwvX48XD5Cqskg25N6eEtdbRFVDHFJaSk+L8Xi6X9d8wbaC6/W
         YdRlMr7LgPenonXucT5K06i92a6pNT98tqcsPH6L32PqETM46UfJlwDqP0FgKbPh0wAg
         uibg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=QOrX1kzmd2Q/ZTwN75VlBeovPM2Shk8Xt9TZZkXuO1g=;
        b=L6qNKpZinoXxRZfzQX0zxMJgWJh926nZ93fXMxYzWjP/1ox2yp4tlOSio2U/CIS8gc
         esWnFuQ1uVaXNhWlLIu/+S4WGt9pZuZ5ejXn0qJyH1Gs/AZB/98j5oA+nzU1tCW6rBqX
         mLfmvJeYKuRl4f234aEKHkYBfKHJlEAVwaHwfijEZlARnQcKBaETRhyekY2ZJvys4p/s
         w5iuI/M7xCIcewm/TKiRVaEwY863pjO3GhJg7MaT0frPlL8XUY1wFU7wPw7h9GNfNB98
         zG5zCo/9DsW8PcEDfe3gerCzWd2Ly2WDTSon1Wn4xK8o72yr7RaaO9KnVW6F/5Lup+Ym
         C0HA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=Lw1khhZ7;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
        by mx.google.com with ESMTP id e14-20020a170902784e00b001854f631c8esi14310772pln.221.2022.12.21.05.08.39;
        Wed, 21 Dec 2022 05:08:48 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@lunn.ch header.s=20171124 header.b=Lw1khhZ7;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=lunn.ch
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232901AbiLUNAC (ORCPT <rfc822;5losepatience@gmail.com>
        + 69 others); Wed, 21 Dec 2022 08:00:02 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50980 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229596AbiLUNAA (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Dec 2022 08:00:00 -0500
Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 438DA22BEF;
        Wed, 21 Dec 2022 04:59:54 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:
        Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
        Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;
        bh=QOrX1kzmd2Q/ZTwN75VlBeovPM2Shk8Xt9TZZkXuO1g=; b=Lw1khhZ7eRqd6SSnAAu7tA9eaT
        aYHhPYv9wp1o8VrLceaoH2/Tx1Pnwq+X6WxAYMA8aH5e8mLrgoKJ6C0ctFh2VYfOklrL/l6+maNYI
        GQwVFz0YDmYe4JMxaFTko3S6EuXCE9oEUHnNXSBBzdmK+P6Yf2HDJ/Xh4xGqyV8wHPKU=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1p7yh6-000B6G-M5; Wed, 21 Dec 2022 13:59:36 +0100
Date:   Wed, 21 Dec 2022 13:59:36 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Christian Marangi <ansuelsmth@gmail.com>
Cc:     Rob Herring <robh@kernel.org>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Jonathan Corbet <corbet@lwn.net>, Pavel Machek <pavel@ucw.cz>,
        "Russell King (Oracle)" <rmk+kernel@armlinux.org.uk>,
        John Crispin <john@phrozen.org>, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-leds@vger.kernel.org,
        Tim Harvey <tharvey@gateworks.com>,
        Alexander Stein <alexander.stein@ew.tq-group.com>,
        Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Subject: Re: [PATCH v7 11/11] dt-bindings: net: dsa: qca8k: add LEDs
 definition example
Message-ID: <Y6MDOOK3Z8Kz+iOx@lunn.ch>
References: <20221214235438.30271-1-ansuelsmth@gmail.com>
 <20221214235438.30271-12-ansuelsmth@gmail.com>
 <20221220173958.GA784285-robh@kernel.org>
 <Y6JDOFmcEQ3FjFKq@lunn.ch>
 <Y6JkXnp0/lF4p0N1@lunn.ch>
 <63a30221.050a0220.16e5f.653a@mx.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <63a30221.050a0220.16e5f.653a@mx.google.com>
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> An alternative way would be set the reg to be the global led number in
> the switch and deatch the phy from the calculation.
> 
> Something like
> port 0 led 0 = reg 0
> port 0 led 1 = reg 1
> port 1 led 0 = reg 2
> port 1 led 1 = reg 3

I would not do this. It will make LED controllers embedded in switches
different to LEDs controllers embedded in PHYs. Ideally we want them
identical. One binding to rule them all.

	   Andrew