Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Dec 2022 14:07:53 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Cc:     Herve Codina <herve.codina@bootlin.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Magnus Damm <magnus.damm@gmail.com>,
        Gareth Williams <gareth.williams.jx@renesas.com>,
        linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v4 3/5] usb: gadget: udc: add Renesas RZ/N1 USBF
 controller support
Message-ID: <Y6MFKdOU4IUQo70L@kroah.com>
References: <20221213133302.218955-1-herve.codina@bootlin.com>
 <20221213133302.218955-4-herve.codina@bootlin.com>
 <CAMuHMdV7QNZ8Rv6iFLhj_MmBHL-vGWuWZdKB=REWba1UAWgkHw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAMuHMdV7QNZ8Rv6iFLhj_MmBHL-vGWuWZdKB=REWba1UAWgkHw@mail.gmail.com>
Precedence: bulk

On Wed, Dec 21, 2022 at 02:03:43PM +0100, Geert Uytterhoeven wrote:
> Hi Herv?,
> 
> On Tue, Dec 13, 2022 at 2:33 PM Herve Codina <herve.codina@bootlin.com> wrote:
> > Add support for the Renesas USBF controller.
> > This controller is an USB2.0 UDC controller available in the
> > Renesas r9a06g032 SoC (RZ/N1 family).
> >
> > Signed-off-by: Herve Codina <herve.codina@bootlin.com>
> 
> Thanks for your patch!
> 
> > --- /dev/null
> > +++ b/drivers/usb/gadget/udc/renesas_usbf.c
> 
> > +#ifdef DEBUG
> > +#define TRACE(_fmt, ...) trace_printk("%s: " _fmt, __func__, ##__VA_ARGS__)
> > +#define USBF_TRACE_EP_MASK 0x0ffff /* All the 16 endpoints */
> > +#define TRACEEP(_ep, _fmt, ...)                                             \
> > +       do {                                                                \
> > +               if ((1 << (_ep)->id) & USBF_TRACE_EP_MASK)                  \
> > +                       trace_printk("%s: " _fmt, __func__, ##__VA_ARGS__); \
> > +       } while (0)
> > +#else
> > +#define TRACE(_fmt, ...) do { } while (0)
> > +#define TRACEEP(_ep, _fmt, ...) do { } while (0)
> 
> Please use "no_printk(fmt, ##__VA_ARGS__)" instead of dummy loops,
> to avoid bad callers going unnoticed if DEBUG is not defined.

Even better, do NOT define custom debug/trace macros for a single
driver, just use the ones that the rest of the kernel uses instead
please.

thanks,

greg k-h