Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Dec 2022 21:52:28 +0800
From:   Chester Lin <clin@suse.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc:     Andrei Stefanescu <andrei.stefanescu@nxp.com>,
        Rob Herring <robh+dt@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Andreas =?iso-8859-1?Q?F=E4rber?= <afaerber@suse.de>,
        dl-S32 <S32@nxp.com>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Larisa Ileana Grigore <larisa.grigore@nxp.com>,
        "Ghennadi Procopciuc (OSS)" <ghennadi.procopciuc@oss.nxp.com>,
        Matthias Brugger <mbrugger@suse.com>
Subject: Re: [PATCH v3 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs
Message-ID: <Y6MPnJ27IKFiNltl@linux-8mug>
References: <20221221073232.21888-1-clin@suse.com>
 <20221221073232.21888-2-clin@suse.com>
 <AM9PR04MB8487286EC9EE4AE3F2FD382CE3EB9@AM9PR04MB8487.eurprd04.prod.outlook.com>
 <5c0e7f2f-94e1-c6d4-d848-f90e29eead10@linaro.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5c0e7f2f-94e1-c6d4-d848-f90e29eead10@linaro.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SCaXkKQahmWfhMI+92R4QKWFRZWZZSBn56dXmAw8e3FwFjAjkD/aiSOfteK7?=
 =?us-ascii?Q?BBkFp1KL/g8HzDip59wqwACi3+3Klkocaq8ddX7GEjYbq5RYUQEpZdfiSGke?=
 =?us-ascii?Q?Wbv42u+i4awirSKdz3pdZ+R0uWdcxCnT2TdZoaMgaOa6ln1/grPyfz2iFTij?=
 =?us-ascii?Q?Mm41eaNOFx+INQqPCQZ/RszgCruT9mh6DY2PsVmL1I6XAybH84P6lv9Dcg0d?=
 =?us-ascii?Q?6lPP9Ytyf787uOrZhkNqGDPJyGdkwMGBiI8GV27t+7gQsxWw9Knf+TcS2FbY?=
 =?us-ascii?Q?ocMQ5ser5rY/oIFL5e+c+y+1Jw10Bhw5PvK6mRKLXSF5fnF9jBiuksT8BO4r?=
 =?us-ascii?Q?4qYiaFVV9Fv51UNFdCNgloJiebrXYeCYcPTKqLNglOb7W/4UU3B1alZUTKEk?=
 =?us-ascii?Q?/QdxljRxk4a6BNopCs0KYxMXNbzEm8JqXcqOHawe6d+UgJn37Zw4oPzqaJA9?=
 =?us-ascii?Q?URGFULWXuWsiZMk+gxQt6zKBFr+rU3NgaO0ibN1PUfPcI8OIrWvpUoGjOqw2?=
 =?us-ascii?Q?EE5J8W6vIyhkNr4vJJ/H0ZadpikBESWHOqDJrAOdzPI0u7f3+FpFAPFYRPhy?=
 =?us-ascii?Q?FrAf/LvZxRkmCUfNzBRNranLl4wSbhe2x0QDAkQKaBkWqexLaWbISsAKIpiB?=
 =?us-ascii?Q?eHL6WLG6r1+ik5uOzdJ4E7FJMcTbC4su1hgx1vYj8PdkXogVqgbZqYGD/r6L?=
 =?us-ascii?Q?z/465Xs5dVYTSBvUCsWnHSIwpXDb/jg8o8cvVZ6hEgbQgAonJgRrsq3VNndT?=
 =?us-ascii?Q?AJ62cGf6gaaHGXTdtEbXGajdSX8RLxYCVa1Nkx+f6Sgcj6EsYWR/HohlqQED?=
 =?us-ascii?Q?kcfstO+8YXg1nLGXsrnuXDJWtIUgwUZONBjDjGAH7QhQTXMt5+rKarnBfzd4?=
 =?us-ascii?Q?Mxcqr7MHVgcJQDcXVcVKZoNL1jtLfIBzePPjGAWHWHZCq5fUERJx9B1ha2gK?=
 =?us-ascii?Q?znJzC5MUcXG4DmEKvcVYq4QqpwrwJb0TeAPLxzyhbhNunHXHAihueiwFTib+?=
 =?us-ascii?Q?VFRr1w7m64KykqiCh8C/DoTyqbH67eClqUtzBfEz4Y+w7imFJQ7c4SrlVw6J?=
 =?us-ascii?Q?ajhgvKynUFCrBJrEET2WYofUSN8cSN3awta+3R8tilk19Rg5q+jb+cBnETOs?=
 =?us-ascii?Q?gkj0DIN9Z/twkY6eB7HwC4kDsi7X48S25o3ik53jtTbhvOBK3YdZJvACs3c/?=
 =?us-ascii?Q?h59qTNQBSHmCoWMno/bvtDinEgSiY1oAFzNFZZtVAfnukctPdF4wC5GclZma?=
 =?us-ascii?Q?lZQObmGIe23mLFTHpMCc8nyJmTmEsrZ3n1bgGr3pHU99bwrzbFtYFMAg2tg4?=
 =?us-ascii?Q?P61HCSfnL4+vPn0Ur0ftqK1YDBnHtvm2LLtGlmVFpczF6yTES/xMt9OghIbl?=
 =?us-ascii?Q?GAqzZNGzVCYbxnMJoDr6CYIiKWfrRcVqCgfGAYpvOzJl4/bSokT9M8Jyw2HV?=
 =?us-ascii?Q?GT7+9wEZ38d0dyYsmgNUjiI/aba9T1gWwx/gJx/qgLQGR6iToPP7xwZIUtEx?=
 =?us-ascii?Q?rF6uAOKC0XkDpMuNoab5fcdug7MlrwWzVuJGEc8k5k/jaR2PYqIXWn1m7Lc4?=
 =?us-ascii?Q?chyBPh9rxv7hDT0NEKQ=3D?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a13cb59-2fe9-4676-b03c-08dae35a9fae
X-MS-Exchange-CrossTenant-AuthSource: VI1PR0402MB3439.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 13:52:39.4121
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /eeP3HInNqrBKiCGy36GMZ+WLujcpkEs+l44GoK/DNBVelAZKN4i9StCOdgquj05
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7542
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Krzysztof and Andrei,

Thanks for reviewing this patch!

On Wed, Dec 21, 2022 at 01:30:12PM +0100, Krzysztof Kozlowski wrote:
> On 21/12/2022 13:28, Andrei Stefanescu wrote:
> > Hi Chester,
> > 
> >> +patternProperties:
> >> +  '-pins$':
> > 
> > Sorry, I missed this in the previous versions. Could you change it to '_pins' (underscore)? In our .dts files we use underscore in the names for pinctrl configuration nodes e.g. i2c4_pins, usbotg_pins.
> 
> You cannot have underscores as node names, so what do you mean here? You

Krzysztof is right, and Rob also reminded me in his comments in v1:

https://lore.kernel.org/linux-arm-kernel/20221102154903.GA3726664-robh@kernel.org/

Regards,
Chester

> need to fix your DTS not introduce bad practices to mainline kernel.
> 
> Best regards,
> Krzysztof
>