Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp5783974rwj; Wed, 21 Dec 2022 07:04:10 -0800 (PST) X-Google-Smtp-Source: AMrXdXt+TEG92KOZr0YC7GvsWtZuOj0bhoSPx56usI3tuSivQZWyzuEvcAn6v+4aXD65gjWZ1Ai2 X-Received: by 2002:a17:906:281b:b0:7c1:5863:f8c4 with SMTP id r27-20020a170906281b00b007c15863f8c4mr1567753ejc.21.1671635050501; Wed, 21 Dec 2022 07:04:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671635050; cv=none; d=google.com; s=arc-20160816; b=lDjtGk4wbJ1Fho/IrTijRVGmg+OGUczeuEn9607UQjTFIjF06eA+ZKy2/umYwTcbtT 5In8TlsF1zUFp6W8J5AdeiAT6ugXP4+GZF491+04dBmT6VL/ME2r/sBTwuBOvWgGH9LZ mkg//bh7Q6U7rZOkr6eIU9pAIeWq8qbFI0XpzBVi+XvuAONYoeub9iOlk8WSksV5v6QR Ft2s4eyz2D+qtKNHTLQ2yEkVLOF6bncpcx3iKKQ+1j6sTXDApouFJTtHRbhgr9T8JbIB 3ohWVn6d4xfnLiLcYnQgIxHF9Avo0MLjHlzYJ4Li4/KGURpPsvE73b++ofvfrOX7zlJ1 oAxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:organization :references:cc:to:from:subject; bh=dkEG6SlM6YIZUppIk216cZuxEpA+E+9JzJf5gooV6iU=; b=rwQ/K50uIqvMXU/3uNEuEwubQpedvOJb6CFfiyR1tBJ2qRJPj6u0UTZxhPe9f6LX7L Bffwr4KCiuRRY+PBuJh4+k6rWoE8DJXEyIuxgdnR1+w9mln6AB1vJejzVsGOmYrNACnq wZ+3OftobIk9T6VOwcCdNcWlG28cJc3E7LXrdOs0xXkxjOG04nJ8gqcIoVTmCg5Wifz4 rmwKbwRM1q/XaAwF4/6oTkiLgx5AXqefu53JD56c1lmEyMxriQKQu0OFRreTiPsuY48i KzO6Y21K47Be8FftBoX6hldLgNFIVoq0MPjyieG1uhbI64tP12RFauIsBrI8MhDwj6o3 HfAg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sd38-20020a1709076e2600b007c08bfea555si14415099ejc.121.2022.12.21.07.03.51; Wed, 21 Dec 2022 07:04:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231698AbiLUOub (ORCPT + 69 others); Wed, 21 Dec 2022 09:50:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231569AbiLUOu0 (ORCPT ); Wed, 21 Dec 2022 09:50:26 -0500 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 916E6233B6 for ; Wed, 21 Dec 2022 06:50:25 -0800 (PST) Received: from [192.168.1.103] (178.176.72.202) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.14; Wed, 21 Dec 2022 17:50:18 +0300 Subject: Re: [PATCH REPOST] f2fs: file: drop useless initializer in expand_inode_data() From: Sergey Shtylyov To: Yangtao Li , , CC: , References: <20221221033021.36615-1-frank.li@vivo.com> <07bca981-edb0-aa85-28e2-ceaf58b6a519@omp.ru> Organization: Open Mobile Platform Message-ID: <87767c57-c50f-6a78-044e-9724bf7a272b@omp.ru> Date: Wed, 21 Dec 2022 17:50:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <07bca981-edb0-aa85-28e2-ceaf58b6a519@omp.ru> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [178.176.72.202] X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.59, Database issued on: 12/21/2022 14:38:06 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 174331 [Dec 21 2022] X-KSE-AntiSpam-Info: Version: 5.9.59.0 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 502 502 69dee8ef46717dd3cb3eeb129cb7cc8dab9e30f6 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_arrow_text} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.72.202 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.72.202 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: 178.176.72.202:7.7.3,7.4.1,7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;omp.ru:7.1.1;127.0.0.199:7.1.2 X-KSE-AntiSpam-Info: {iprep_blacklist} X-KSE-AntiSpam-Info: ApMailHostAddress: 178.176.72.202 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 12/21/2022 14:41:00 X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 12/21/2022 10:52:00 AM X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/21/22 5:46 PM, Sergey Shtylyov wrote: >>> In expand_inode_data(), the 'new_size' local variable is initialized to >>> the result of i_size_read(), however this value isn't ever used, so we >>> can drop this initializer... >>> >>> Found by Linux Verification Center (linuxtesting.org) with the SVACE static >>> analysis tool. >>> >>> Signed-off-by: Sergey Shtylyov >>> >>> --- >>> This patch is against the 'dev' branch of Jaegeuk Kim's F2FS repo... >>> Reposting with ISP RAS mailing lists CC'ed now... >> >> Why do you repeatedly send a patch Sorry, 1st time I forgot to do the internal CC dance -- CCing couple SVACE (static analyzer) specific mailing lists... [...] >> Thx, >> Yangtao MBR, Sergey