Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 21 Dec 2022 15:28:39 +0100
From:   Simon Horman <simon.horman@corigine.com>
To:     Aldas =?utf-8?B?VGFyYcWha2V2acSNaXVz?= <aldas60@gmail.com>
Cc:     manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com,
        gregkh@linuxfoundation.org, netdev@vger.kernel.org,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: qlge: remove unnecessary spaces before function
 pointer args
Message-ID: <Y6MYF02RgdtA3SJK@corigine.com>
References: <20221214205147.2172-1-aldas60@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20221214205147.2172-1-aldas60@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RmREdUFKME41SDg1aXJCOFBZdkJNUTNTMHliSTQrVGt1cDMyQTExOGVvNWZp?=
 =?utf-8?B?MzdibFNvRmlTdStxRzR2ZE9JTEV1bHJiNXVLa0RveGo5WkdFOXVibERuSXhk?=
 =?utf-8?B?YXd5d1hzanAxZ1p6YkJsTE95cWdQWU9lNzgzVmNiQUh1bkJQWUxYV0I3V0Na?=
 =?utf-8?B?Q2dlZXVzN3NrZXhEYzR0SG5rVm9DUkk2ZS9SU1hKVzhPSHhJZDRncXY4UUpt?=
 =?utf-8?B?ekFNYXE4ajZ5dEdsdVVwelV3YWoxUUp4djRtVFRON2tWVGZzOXZlcXVwUTdH?=
 =?utf-8?B?UCtrTlF6eXVYbjVYN2hwTVlDRDRTSHY3MzVWWS9JWlpZamh2TDVxWTN0RjJn?=
 =?utf-8?B?dWZWSzFGUHQ2WWdKNlB3eUFjRVJtWHVNaW4yQkNaNjByTnlVWkRTa3BPS0tj?=
 =?utf-8?B?WVJINFh0b1hBZGE4NFhXMHladzRadkQwNzkyMm94UUNaRHFqa0ttNkdLOEpu?=
 =?utf-8?B?UzgxeE1JYWNlcEczTDNPMWwwNXk1Q1YzSURGeEYycXRhTkMxakdqSHlPWi9s?=
 =?utf-8?B?VFV5U0xOVW1tWWNoYUI1cTdRbnpOaTI4UlZXMjVtL3p3ZFJIb0lRY1FjbXdD?=
 =?utf-8?B?L0d5bm1QL2NQQUNHRFhndWhXWkNTdmJJZ3h4RmRUdVBuemZWN2wzQzkxRkVq?=
 =?utf-8?B?Y3E0N0RWVE4yZm5oZ2s5YlhBek45MHZkTldrT0FMMjV4cHltcndSS0d4VkVK?=
 =?utf-8?B?NTZTODNlNnBENDlTN1Z1MEJaWkh5MmRVcDA2a2o2aUtSTVd5dGtNRXdod2Qw?=
 =?utf-8?B?RU15eGZTU1Y5WkdZYlk5RHBVc1FVUDFuSjRLbVNSNk5LVEFHZEVoN1hXcVAz?=
 =?utf-8?B?TnBUd1YzaUxhaWJaNTF4QnBBb0tZV2NlN0FjOUkrT1orK3RVc0cvNDVFTlkx?=
 =?utf-8?B?WFd0WDE0S21uN0dISmF3Z3haL2ZwZ21vamJPK1I4QllqeHV6d2dkWkVpdFBR?=
 =?utf-8?B?ZzVWNmF3Z3ZIdHIyWm8wNkIyU3ZWQnl0YkVnN3lFQkVvS1U1cS9Ob0JFa2pm?=
 =?utf-8?B?SUFBbVhIWnNTWE95SkhvQkdlVTRnWjdSaDhhVG0zUHgxZkd0ZmRhbFVSbktC?=
 =?utf-8?B?cXEyd1JVRFpWZlFnNTF1M0tGaXBXVDd0b3JvcTJiY3R3VkJMdnFLdy9lUHFG?=
 =?utf-8?B?NWlMMUlqWHkvVGtSamJKaW1aUUw3TlMvL0Q4bTVyMzkyRXNjUUltSDM5bVMw?=
 =?utf-8?B?VDhqdjlzM3B5U3NlU01iZW9NaFVtWXhxRDhqQyt4V0VCVThyd2cwT3Z1TUZZ?=
 =?utf-8?B?Z05kank5UjNZNlJmNTM0TGhlaTcrSnd1UWsyMVoxTE1zLzZydTZ3M0JMOUhG?=
 =?utf-8?B?ZTlTTWR0THl2K3BabVMwOFFtOFd3Yy94YllpclBEYklwNkdMYUErTnV1cFRw?=
 =?utf-8?B?cTNBWVJFVWNON3JZVU4yYXN2Vzg5Q1dhR011d3NaS2tjeHB0R0RuU3lkd1ly?=
 =?utf-8?B?aExtRnhwMGphQWMzMjNzSG1TKzdqdGRpdy9XWmdmS25SSm9kUmVmdGxOU3Nw?=
 =?utf-8?B?eTdpbXhqUzc4akFkZFBrRlBCT094cjNTR0ZhZEdEd1JqVForR004NUtYNk5C?=
 =?utf-8?B?WENjYzUxcVpJV01MejQwYUtsczBjc1Y3SjdVZVhBWTBncmF0YWtRbjBoc3ZT?=
 =?utf-8?B?aHh3a1k5ZDFORVNQSFlFVDdsMThoNXJMMTBwQUZ2a3k5bHRJeHF5U2ZDY2Rq?=
 =?utf-8?B?ejJpM3VtSHpLRWVQT2dlN1ozcDl5eGFWWGFnekRMT3c1S0FPeXR5VFNiV0c2?=
 =?utf-8?B?S0RSSXlDbnNjNmY0ZXIwT2JKY0NidTRNeXBZWE5Nb3orZnVnSVhrOGxhb092?=
 =?utf-8?B?TVpYV2RMeEdmemxrVlgyRmZ3blNDV3hDekhxMUk1SUdxV1VUTDdXZERFSmgz?=
 =?utf-8?B?Tmx0Rm1aeWJHTDVxMVI1NFhlRTV1YmlkczZUTFduYUZWZ2tBanBRcVY2SjZY?=
 =?utf-8?B?ZXBxL2FELzk1UlliYXQvNEd5L0RVUkNtcDByeWE2cWdxNWNDN2gvZnoxNmxl?=
 =?utf-8?B?Y3pTKytFZXM5Zm40UXVqZisxQ2o2a3VmeW9Cc0svOXplQTNEOW4wVmQ1NG1o?=
 =?utf-8?B?U0JaUGFHMVVGT2dXd3kvQ3RWczVEU2RnR1ROcGhOckNST0MzTVdvWHAwN1ZL?=
 =?utf-8?B?SUNQTWtIdDJxcGxuKzM2RS9uZjFYWUlQUGwvbW9DUElRTXF1Szh0TnRCMjVR?=
 =?utf-8?B?TFAxR1NJWXExZjQxUEFSS1M5UU0yUCtFVVJFTHZScldjaVpKeEtRNVJma2J4?=
 =?utf-8?B?VTFUak5UUzgycGFDbWJFRU5VZ1ZBPT0=?=
X-OriginatorOrg: corigine.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ffe2513-f0b1-4723-d900-08dae35fab6a
X-MS-Exchange-CrossTenant-AuthSource: PH0PR13MB4842.namprd13.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2022 14:28:46.5838
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: C6B612CgCUGfVq0YKniZsKYISnDZWQUtOa5AOSyxgiK7FVGOwCs8GxxqN36+DwJUTX8s7By0L2Iya1D90DxsJRisNTJeiY1ZwU+XBnNKHss=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR13MB3886
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Dec 14, 2022 at 10:51:47PM +0200, Aldas Taraškevičius wrote:
> Remove unnecessary spaces before the function pointer arguments as
> warned by checkpatch.
> 
> Signed-off-by: Aldas Taraškevičius <aldas60@gmail.com>
> ---
>  drivers/staging/qlge/qlge.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/qlge/qlge.h b/drivers/staging/qlge/qlge.h
> index fc8c5ca89..05e4f4744 100644
> --- a/drivers/staging/qlge/qlge.h
> +++ b/drivers/staging/qlge/qlge.h
> @@ -2057,8 +2057,8 @@ enum {
>  };
>  
>  struct nic_operations {
> -	int (*get_flash) (struct ql_adapter *);
> -	int (*port_initialize) (struct ql_adapter *);
> +	int (*get_flash)(struct ql_adapter *);
> +	int (*port_initialize)(struct ql_adapter *);
>  };

I'm not clear if there is consensus on the style issue at play here.
And so I am neutral on this patch.

But perhaps if these lines are being updated then the following check patch
warnings could be addressed.

$ scripts/checkpatch.pl --strict this.patch
WARNING: function definition argument 'struct ql_adapter *' should also have an identifier name
#122: FILE: drivers/staging/qlge/qlge.h:2060:
+	int (*get_flash)(struct ql_adapter *);

WARNING: function definition argument 'struct ql_adapter *' should also have an identifier name
#123: FILE: drivers/staging/qlge/qlge.h:2061:
+	int (*port_initialize)(struct ql_adapter *);

total: 0 errors, 2 warnings, 0 checks, 10 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] staging: qlge: remove unnecessary spaces before function pointer args" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.