DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=UwblxnUz0BAClKzAplFqVE/qQRFV1VdvKZA8l7tKaCWn8+ByV4deMEubrQ8dvMXWNNQTZA66qjVwvCtMhyk4/DzD+ejrHhoTLW1ca/M4DDWwyzK7zyLvm7MFahYMebyvoPR+iuFmq0ug6iw38vdiAai7ReGdSHjLTCewHMqIuzc=
Message-ID: <8bd0f97a0708161128g71ca385ak6ddcb1b36d7fabc2@mail.gmail.com>
Date: Thu, 16 Aug 2007 14:28:43 -0400
From: "Mike Frysinger" <vapier.adi@gmail.com>
To: "Jie Zhang" <jie.zhang@analog.com>
Subject: Re: [PATCH 1/2] Add a new field `name' to struct linux_binfmt
Cc: linux-kernel@vger.kernel.org
In-Reply-To: <1187248823.11475.24.camel@mercury.analog.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1187248823.11475.24.camel@mercury.analog.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 921
Lines: 25

On 8/16/07, Jie Zhang <jie.zhang@analog.com> wrote:
> This patch addes a new `name' field to struct linux_binfmt and
> initialize it in each binfmt type.
>
> A second blackfin arch patch will use this field to distinguish `flat'
> binfmt with `FDPIC ELF'.
>
> Is it OK? Any comments?

the other possibility would be to not make linux_binfmt definitions
static and put appropriate prototypes in the fs.h header ... then you
could do:
if (current->binfmt == aout_format) {
  ... aout stuff ...
}

then again, this goes against the dynamic nature of the binfmt itself
... and the idea that the binfmt should not matter to anything else in
the kernel once it's executing ...
-mike
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/