Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0417e11649150202f717646809e7db5c55f7ac83.camel@ndufresne.ca>
Subject: Re: [PATCH v1 4/9] media: verisilicon: Check AV1 bitstreams bit
 depth
From:   Nicolas Dufresne <nicolas@ndufresne.ca>
To:     Benjamin Gaignard <benjamin.gaignard@collabora.com>,
        ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de,
        mchehab@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de,
        daniel.almeida@collabora.com, nicolas.dufresne@collabora.co.uk
Cc:     linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, kernel@collabora.com
Date:   Wed, 21 Dec 2022 11:16:12 -0500
In-Reply-To: <4aae8684-5ab4-c5a6-cc73-5dc61309b745@collabora.com>
References: <20221219155616.848690-1-benjamin.gaignard@collabora.com>
         <20221219155616.848690-5-benjamin.gaignard@collabora.com>
         <e3663c85c75d09259a3135cb6ccfe7d6231bd752.camel@ndufresne.ca>
         <4aae8684-5ab4-c5a6-cc73-5dc61309b745@collabora.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

Le mardi 20 d=C3=A9cembre 2022 =C3=A0 14:02 +0100, Benjamin Gaignard a =C3=
=A9crit=C2=A0:
> Le 19/12/2022 =C3=A0 21:38, Nicolas Dufresne a =C3=A9crit=C2=A0:
> > Le lundi 19 d=C3=A9cembre 2022 =C3=A0 16:56 +0100, Benjamin Gaignard a =
=C3=A9crit=C2=A0:
> > > The driver supports 8 and 10 bits bitstreams, make sure to discard
> > > other cases.
> > >=20
> > > Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> > > ---
> > >   drivers/media/platform/verisilicon/hantro_drv.c | 6 ++++++
> > >   1 file changed, 6 insertions(+)
> > >=20
> > > diff --git a/drivers/media/platform/verisilicon/hantro_drv.c b/driver=
s/media/platform/verisilicon/hantro_drv.c
> > > index 8e93710dcfed..e10fc59634dd 100644
> > > --- a/drivers/media/platform/verisilicon/hantro_drv.c
> > > +++ b/drivers/media/platform/verisilicon/hantro_drv.c
> > > @@ -282,7 +282,13 @@ static int hantro_try_ctrl(struct v4l2_ctrl *ctr=
l)
> > >   		/* We only support profile 0 */
> > >   		if (dec_params->profile !=3D 0)
> > >   			return -EINVAL;
> > > +	} else if (ctrl->id =3D=3D V4L2_CID_STATELESS_AV1_SEQUENCE) {
> > > +		const struct v4l2_ctrl_av1_sequence *sequence =3D ctrl->p_new.p_av=
1_sequence;
> > > +
> > > +		if (sequence->bit_depth !=3D 8 && sequence->bit_depth !=3D 10)
> > > +			return -EINVAL;
> > As you state in the cover letter, should this just be this for now ?
>=20
> The driver can decode 8 or 10 bits bitstreams but will on produce 8bits (=
NV12_4L4 or NV12)
> frames. The hardware is able to truncate 10bits bitstreams to 8 bits outp=
ut.

I tested that, and NV12 works, picking NV12_4L4 though leads to corrupted
buffers. I think the PP is not being activated. G2/VC8000 and likely VC9000=
 can
only produce tile reference in the original depth chosen (hence why it goes=
 not
have a format register like G1 does).

As you are aware, the driver didn't pick NV12_10LE40_4L4 automatically, and
that's what broke fluster 10bit test in tiled mode for 10bit. I suspect in =
v2,
we'll have all this fixed and 10bit will be activated, so this comment will=
 be
ignored.

>=20
> >=20
> >=20
> > > +		if (sequence->bit_depth !=3D 8)
> > > +			return -EINVAL;
> >=20
> > >   	}
> > > +
> > >   	return 0;
> > >   }
> > >  =20