Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757476AbXHPUDh (ORCPT ); Thu, 16 Aug 2007 16:03:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751210AbXHPUDY (ORCPT ); Thu, 16 Aug 2007 16:03:24 -0400 Received: from mx1.redhat.com ([66.187.233.31]:41452 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925AbXHPUDW (ORCPT ); Thu, 16 Aug 2007 16:03:22 -0400 Message-ID: <46C4ABC5.0@redhat.com> Date: Thu, 16 Aug 2007 15:55:49 -0400 From: Chris Snook User-Agent: Thunderbird 1.5.0.12 (Macintosh/20070509) MIME-Version: 1.0 To: =?ISO-8859-1?Q?Ilpo_J=E4rvinen?= CC: Herbert Xu , Paul Mackerras , Satyam Sharma , Christoph Lameter , "Paul E. McKenney" , Stefan Richter , Linux Kernel Mailing List , linux-arch@vger.kernel.org, Linus Torvalds , Netdev , Andrew Morton , ak@suse.de, heiko.carstens@de.ibm.com, David Miller , schwidefsky@de.ibm.com, wensong@linux-vs.org, horms@verge.net.au, wjiang@resilience.com, cfriesen@nortel.com, zlynx@acm.org, rpjday@mindspring.com, jesper.juhl@gmail.com, segher@kernel.crashing.org Subject: Re: [PATCH 0/24] make atomic_read() behave consistently across all architectures References: <20070816003948.GY9645@linux.vnet.ibm.com> <18115.44462.622801.683446@cargo.ozlabs.ibm.com> <20070816020042.GA30650@gondor.apana.org.au> <18115.45316.702491.681906@cargo.ozlabs.ibm.com> <18115.52863.638655.658466@cargo.ozlabs.ibm.com> <20070816053945.GB32442@gondor.apana.org.au> <18115.62741.807704.969977@cargo.ozlabs.ibm.com> <20070816070907.GA964@gondor.apana.org.au> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1298 Lines: 32 Ilpo J?rvinen wrote: > On Thu, 16 Aug 2007, Herbert Xu wrote: > >> We've been through that already. If it's a busy-wait it >> should use cpu_relax. > > I looked around a bit by using some command lines and ended up wondering > if these are equal to busy-wait case (and should be fixed) or not: > > ./drivers/telephony/ixj.c > 6674: while (atomic_read(&j->DSPWrite) > 0) > 6675- atomic_dec(&j->DSPWrite); > > ...besides that, there are couple of more similar cases in the same file > (with braces)... atomic_dec() already has volatile behavior everywhere, so this is semantically okay, but this code (and any like it) should be calling cpu_relax() each iteration through the loop, unless there's a compelling reason not to. I'll allow that for some hardware drivers (possibly this one) such a compelling reason may exist, but hardware-independent core subsystems probably have no excuse. If the maintainer of this code doesn't see a compelling reason not to add cpu_relax() in this loop, then it should be patched. -- Chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/