Received: by 2002:a05:6358:f14:b0:e5:3b68:ec04 with SMTP id b20csp6126805rwj; Wed, 21 Dec 2022 11:03:17 -0800 (PST) X-Google-Smtp-Source: AMrXdXs1fg7G64TKe1zEIf1dweN4Oz0Q+N9IWjvdthJEoZYGXFGjKC3+T2/ICFm0TXnZ0IE7IEIq X-Received: by 2002:a05:6a21:1709:b0:ac:5671:adfa with SMTP id nv9-20020a056a21170900b000ac5671adfamr20296984pzb.18.1671649397142; Wed, 21 Dec 2022 11:03:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671649397; cv=none; d=google.com; s=arc-20160816; b=HKBdu+JGrK6g+HSpiXVJeaoshVIj4Dl5bye2cxnRsXlAx3GjVlFAa0ny4F/hpOtws9 Kg4PEKl5Wyggsg6yS/BrIW+MwYjUlfTehalQbNd0vBmY7M3D6G1B4/10RVC23ZWnPbQ4 mGqrP2CkXTGBWHUNNKgdO+xuYsF1jSR9ZIK6mJ8Ca7INcJqxbl3glrqB6tpMtzygqX+Q z+X0c6cpONrYVU/uRuoDy3DzYR5UMP3DLmJEwGzQbyBs0Yk6jjFCOPN9PeV/Y7lHOKKH 20+KfDbgdtX31vbDibvRLZLCT2DOkxw4F/Z76QkueESB/xiNlUk1DgsBH/30KNNJgiMo A5OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=IqMLve4a+7yaawxIrTIZNKm2QG2HHAaYLBOV4f2gVjs=; b=FSmuF/9VwI/GpojzXpS0/DCOetUkyxiSj5ZqXwMuumQKMvPmMsOTx00o7raIn/8jx3 Ukx9evH5LJd46RPPnfpZsS10seo+L680vUGS9KT7JeKOFBj7seoeDlV2b6UDKTd8yfVR SGtnO+WJCwluYuvHARc6WpBr2SgvATbcQi+7Goz4ZulQ5RFskTTZSy6BIYa24E13Z8ZT hyZiUkD/0wIQRZafXkyEKHvN8RyBjbnv7XWhhIAbrdTliEUHa5K78bO5hjKWNKTePM5a /Z4PHlz9AoznDhsGbCLzw1ki1KpM4SKrV5CgU+Mlm5vDsx71s4Y1rHMh6EjntgDrDfFf NjgQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="lP5/16ii"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z19-20020aa79593000000b00572d26386b5si5855052pfj.146.2022.12.21.11.03.08; Wed, 21 Dec 2022 11:03:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b="lP5/16ii"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234837AbiLUSol (ORCPT + 67 others); Wed, 21 Dec 2022 13:44:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234296AbiLUSoj (ORCPT ); Wed, 21 Dec 2022 13:44:39 -0500 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F71920F45 for ; Wed, 21 Dec 2022 10:44:38 -0800 (PST) Received: by mail-pl1-x636.google.com with SMTP id n4so16417998plp.1 for ; Wed, 21 Dec 2022 10:44:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IqMLve4a+7yaawxIrTIZNKm2QG2HHAaYLBOV4f2gVjs=; b=lP5/16iiEYGHg9x3sdKqI41DZkM7CC4/jVRfG1JUluigHimrXgJ1BwwVBqPAJw6SLF FIgymM96JKS8LdWm8L4kciMCnvqhtX/lW6UloIH8bFCIsH6QflcXBvIa+fQBYFo3U86/ QroUendE8aUHa7TufrfR00JWJ0NbIJTwKDSAMR5RHnIOiaX6xl0pDzo3e6duurK0kza9 NfewXU0wGGhp9rU++dvhKVqIpHCfBNygPi5Qv60T3j3RYPH5aH8dB5POTXUrpWSbbW8F D670zUy5bQ8CwJqRo8x955cwaETg9qzeRHzzQfS8zR/qtvVN6M/26rabgDuM6mptso56 ezXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IqMLve4a+7yaawxIrTIZNKm2QG2HHAaYLBOV4f2gVjs=; b=c42MJOe4G2vOEXoGzxMy41rC4Lhv/NQnOih0KaBDXP72CbRj/LQK08lyLHJ8OC613W XxHztXV981nhf+d1VYVnX4fcoOqRg7OrRBXx3QidR5lEf/FWua5sJv4dNsAbWuogQnbW 4I+dK3ze8NlUh2arF+NAvlwOpqESkrIU4QEGwOiKK3ve1lo05qyrKjPTJbFNcE65bf+G kzMwmSOT4Za7f8xNxCvtrGMgagddB2sr6oAh7XCCrx3hwByzevtrpfxqgBcsMxXm0U7K JK+lZKuEXi2BmY3iltUhLlcNcAS/FtUCYTNi/NCAETzK/AzT4cQ0vROmA8ubZ78yVj9m AmsQ== X-Gm-Message-State: AFqh2kqHE2Ph7TD97VhHm7hIOUjYizMk/t4E9ophhSHsIiHePPySF49G g7wZuVKvpkmUT1Vx+RXVH4Yc5A== X-Received: by 2002:a17:90b:35d0:b0:218:7bf2:4ff2 with SMTP id nb16-20020a17090b35d000b002187bf24ff2mr700519pjb.0.1671648277545; Wed, 21 Dec 2022 10:44:37 -0800 (PST) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id gm16-20020a17090b101000b00219752c8ea5sm1731495pjb.37.2022.12.21.10.44.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Dec 2022 10:44:36 -0800 (PST) Date: Wed, 21 Dec 2022 18:44:33 +0000 From: Sean Christopherson To: Maxim Levitsky Cc: kvm@vger.kernel.org, Santosh Shukla , Sandipan Das , Paolo Bonzini , Jim Mattson , Peter Zijlstra , Dave Hansen , Borislav Petkov , Pawan Gupta , Thomas Gleixner , Ingo Molnar , Josh Poimboeuf , Daniel Sneddon , Jiaxi Chen , Babu Moger , linux-kernel@vger.kernel.org, Jing Liu , Wyes Karny , x86@kernel.org, "H. Peter Anvin" Subject: Re: [PATCH v2 00/11] SVM: vNMI (with my fixes) Message-ID: References: <20221129193717.513824-1-mlevitsk@redhat.com> <7af086556ff794bbe78e48c882b6e91aa5ad4022.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7af086556ff794bbe78e48c882b6e91aa5ad4022.camel@redhat.com> X-Spam-Status: No, score=-17.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 20, 2022, Maxim Levitsky wrote: > On Tue, 2022-11-29 at 21:37 +0200, Maxim Levitsky wrote: > > Hi! > > > > This is the vNMI patch series based on Santosh Shukla's vNMI patch series. > > > > In this version of this patch series I addressed most of the review feedback > > added some more refactoring and also I think fixed the issue with migration. > > > > I only tested this on a machine which doesn't have vNMI, so this does need > > some testing to ensure that nothing is broken. > > > > Best regards, > > Maxim Levitsky > > > > Maxim Levitsky (9): > > KVM: nSVM: don't sync back tlb_ctl on nested VM exit > > KVM: nSVM: clean up the copying of V_INTR bits from vmcb02 to vmcb12 > > KVM: nSVM: explicitly raise KVM_REQ_EVENT on nested VM exit if L1 > > doesn't intercept interrupts > > KVM: SVM: drop the SVM specific H_FLAGS > > KVM: x86: emulator: stop using raw host flags > > KVM: SVM: add wrappers to enable/disable IRET interception > > KVM: x86: add a delayed hardware NMI injection interface > > KVM: SVM: implement support for vNMI > > KVM: nSVM: implement support for nested VNMI > > > > Santosh Shukla (2): > > x86/cpu: Add CPUID feature bit for VNMI > > KVM: SVM: Add VNMI bit definition > > > > arch/x86/include/asm/cpufeatures.h | 1 + > > arch/x86/include/asm/kvm-x86-ops.h | 2 + > > arch/x86/include/asm/kvm_host.h | 24 +++-- > > arch/x86/include/asm/svm.h | 7 ++ > > arch/x86/kvm/emulate.c | 11 +-- > > arch/x86/kvm/kvm_emulate.h | 7 +- > > arch/x86/kvm/smm.c | 2 - > > arch/x86/kvm/svm/nested.c | 102 ++++++++++++++++--- > > arch/x86/kvm/svm/svm.c | 154 ++++++++++++++++++++++------- > > arch/x86/kvm/svm/svm.h | 41 +++++++- > > arch/x86/kvm/x86.c | 50 ++++++++-- > > 11 files changed, 318 insertions(+), 83 deletions(-) > > > > -- > > 2.26.3 > > > > > A very kind ping on these patches. Sorry, I won't get to this (or anything else) until the new year.