Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Liam Howlett <liam.howlett@oracle.com>
To:     Vernon Yang <vernon2gm@gmail.com>
CC:     "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "maple-tree@lists.infradead.org" <maple-tree@lists.infradead.org>
Subject: Re: [PATCH v2 0/7] Clean up and refinement for maple tree
Thread-Topic: [PATCH v2 0/7] Clean up and refinement for maple tree
Thread-Index: AQHZFQGqV1gzvMDpnEimGuywMFnWrK54sQUA
Date:   Wed, 21 Dec 2022 18:53:36 +0000
Message-ID: <20221221185330.5h27xfrvnargmduw@revolver>
References: <20221221060058.609003-1-vernon2gm@gmail.com>
In-Reply-To: <20221221060058.609003-1-vernon2gm@gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gbZZjY/kt2FS/4wNVLO+Z5LY3hcRRVZnvvT/hXLoGIEUZjyBNP2eiMzws5LZ?=
 =?us-ascii?Q?p4B2Q5SC1PjPZpR79Vw7xuYNJPj1zhH7wMBhRyIRt82jJURmKANcp8NyM5Sl?=
 =?us-ascii?Q?hS/Ys1YqGkN0SdLGi7V+KFO5POxxcQRrSNIIVrtvcMln3tE5SrP+81ePbe/C?=
 =?us-ascii?Q?lQQypAw01n9rkBrLPnBZT555ZXZpVWtJqCuKcFFgjNDpQdeDP3ldjSSMfPgd?=
 =?us-ascii?Q?y+ZhSR6DrMXseQDasY8oCQ/mlmdlBfxdRElQBvraUwGHxBWmXqZnjLRdW1UD?=
 =?us-ascii?Q?g8ItHC3pQyNuBa9CnJyC1dIC/El5tCon1r0Zo2GVCwk4G8MZWboAmhD1twA3?=
 =?us-ascii?Q?BgrYzBR3WGd+Ev87nqiFp+nWbeiKxQR3ztsMZif9DTPOC8hlRz4oozQIps0b?=
 =?us-ascii?Q?5JNmLK4ZhJhQab9NPhW6izJxhoK78dc5BOh0ni5eV30Ilq7Tr+Cf65RYecaL?=
 =?us-ascii?Q?w2sKfZ9OAcsZN2U3AAN1M5bW1of9ZfQ/a+tJufY4qERGOT6JKfaSgwRKxpla?=
 =?us-ascii?Q?cwy0KY/5ZMW/bS/1F72oCsumqfxR53rVyZzHfrGPkw3hUbUJWdh8+S7inOHC?=
 =?us-ascii?Q?yfCmbG6p38lcU94YHJrZEwi8JRBTYR6jBobOYlpV+Lprgx0OyPQXgvOmpLDC?=
 =?us-ascii?Q?d7wzxGE2XOZmS2OiSDSYlT3N7EYtUuWvSoUuePmRjEu65wlS8oPKp3JbB3de?=
 =?us-ascii?Q?wB4XJkXIC5sJOGtA9qjHCadkRFdwuoNRUdAHGi9aH6R8bDEO2cYsRmYgTZJk?=
 =?us-ascii?Q?FfQu4ivwFtVXwWdapx1Dtvkk9krKGlPsjZ1bP+mC2W15yvL+nxHCv5XGq5Mh?=
 =?us-ascii?Q?zS5NDZDaJfv0es9QspcUkLtkprmd9VQWoqxfX5Zc6yOJBRn12GfVyiPsyPuR?=
 =?us-ascii?Q?Oc+pfe4J8ctVVA3S9ONKyyTzsQzNj3hizxpsCieGXx63Mr8jG4ZRg5r+4ruU?=
 =?us-ascii?Q?UD3kTXkuh/VI2QmIq+VmeGszyflMRicxH4Dt4elYCI/4G1olAmMucENrcHJ3?=
 =?us-ascii?Q?cxKIcD0d1ETrdRg1AzHZ9QLS/sa+Q6aQcwcWVjjGf2hpMsmxVUwQ1FLjJ8d8?=
 =?us-ascii?Q?4ECVmKgx+1z4e4W22NwIG2CId1uve+UhZeO5+7AWzdgk9mBspBKktpUVSliC?=
 =?us-ascii?Q?C7yVQJGKpz68iUixlEW1u733qjxS/FE0FZIri4XZpLM5+A7nF/8ykgPCBu7q?=
 =?us-ascii?Q?gPgNJENW5HGBSqiuuKWVredWEk41HwC9HErredjTcMGtSOiWS5fGdn4ewaDm?=
 =?us-ascii?Q?XEsnUyzDRHD7BgYYsuhryprUfJ/q9M6kFgk88xJycUoF2E5BmIBfiM/8db1A?=
 =?us-ascii?Q?ehvdZhO5CdZPyRBkWLgy7J6atgBsrEk5/umSD3iCwjuCBuFCD3grujRF36JX?=
 =?us-ascii?Q?RcwSJBidngaHoivjaUIgbZTaN0F4wWSAr8IBwer8H+c3+Ok1oTMgp7h3XIrF?=
 =?us-ascii?Q?iuk+hZpjky4AEJmqQuvmB/i+WcouD47uDcq67VQ6D2C77NAmJb7zulX/p8/a?=
 =?us-ascii?Q?kJNH8VbRlfd+5auArfqNbEVUoOMEKNyWIUzEz6LTl8eoXc7oqT9u2OqtKYXI?=
 =?us-ascii?Q?UgmzBs2nti/ufD4O2bYEzzT2rhLWbwN/Zx+C5IBodxdq0m3M6e2pBwIti0Ny?=
 =?us-ascii?Q?kw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C14EC5B93895C54B8F32EC74297B42D3@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: cdaa169d-49a3-443c-135a-08dae384aaba
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2022 18:53:36.5699
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 5vTj1NPu5tUfD2U548j0K/qOub0Lz7uobdYGgTYIarCpZn1aMVnUj9ZD+t2Z7d3nG+22QLQHGqLIYpmg+RdLhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5801
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-21_11,2022-12-21_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 suspectscore=0
 adultscore=0 malwarescore=0 spamscore=0 mlxlogscore=966 mlxscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2212210160
X-Proofpoint-GUID: y8dua7OOWKf_vuiGHAJpRVMzO6tkzukE
X-Proofpoint-ORIG-GUID: y8dua7OOWKf_vuiGHAJpRVMzO6tkzukE
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

* Vernon Yang <vernon2gm@gmail.com> [221221 01:01]:
> Hello,
>=20
> This patchset clean up and refinement some maple tree code, a few small
> changes make the code easier to understand and for better readability.
>=20
> v2 changes:
> - Add Reviewed-by Liam R. Howlett to all patches besides 6 & 8.
> - Remove patch 6.
> - Add an unlikely() to the if statement for patch 8.
>=20
> v1: https://lore.kernel.org/linux-mm/20221220140829.1665432-1-vernon2gm@g=
mail.com/

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>

>=20
> Vernon Yang (7):
>   maple_tree: remove extra space and blank line
>   maple_tree: remove extra return statement
>   maple_tree: use mt_node_max() instead of direct operations mt_max[]
>   maple_tree: use macro MA_ROOT_PARENT instead of number
>   maple_tree: remove the redundant code
>   maple_tree: refine ma_state init from mas_start()
>   maple_tree: refine mab_calc_split function
>=20
>  include/linux/maple_tree.h |  6 ------
>  lib/maple_tree.c           | 35 ++++++++++++-----------------------
>  2 files changed, 12 insertions(+), 29 deletions(-)
>=20
> --
> 2.34.1
> =