Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ed6c9173-dbbd-6275-a285-04b21de26f13@intel.com>
Date:   Thu, 22 Dec 2022 09:18:35 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.6.1
Subject: Re: [linus:master] [mm] 0ba09b1733: will-it-scale.per_thread_ops
 -21.1% regression in mmap1 benchmark
Content-Language: en-US
To:     Yang Shi <shy828301@gmail.com>, Yujie Liu <yujie.liu@intel.com>
CC:     Liam Howlett <liam.howlett@oracle.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "oe-lkp@lists.linux.dev" <oe-lkp@lists.linux.dev>,
        "lkp@intel.com" <lkp@intel.com>,
        Nathan Chancellor <nathan@kernel.org>,
        "Huang, Ying" <ying.huang@intel.com>,
        Rik van Riel <riel@surriel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "feng.tang@intel.com" <feng.tang@intel.com>,
        "zhengjun.xing@linux.intel.com" <zhengjun.xing@linux.intel.com>
References: <202212151657.5d11a672-yujie.liu@intel.com>
 <CAHbLzkpVr62M4dWCb9J+eMErDvxx0hiTF6DD6bp2qEivzZYXCg@mail.gmail.com>
 <20221220204845.ul2wf4bj75dl5gbc@revolver> <Y6JwkEraN79acHP0@yujie-X299>
 <CAHbLzkpF4tuuukmhqC1soeVUaS4D5XtDjNDugy9t9D77s_xG8g@mail.gmail.com>
From:   "Yin, Fengwei" <fengwei.yin@intel.com>
In-Reply-To: <CAHbLzkpF4tuuukmhqC1soeVUaS4D5XtDjNDugy9t9D77s_xG8g@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anFZU0NzTG1RVVhTZ1FrVTZVNHZHcDRqNm9uTGxVczdYbS81U0wxeEN6aGh5?=
 =?utf-8?B?SDNzbGNmb0JkS3ZMYkd0L0R4Zng2UUhqVE5WRm42c2NRQ3luN082eGthZFFR?=
 =?utf-8?B?TnkxNkhkMTNVdkgyS2hHWWpVRGwzM0UzU3RORGtWWDF4ZWlOdDhZcld1eWVS?=
 =?utf-8?B?ekdvdGFsY1NmOTg4K1NIMXVvLzd6dXFOa3p2aDJURnptODJhemw2ZW1uVncw?=
 =?utf-8?B?S3N4b2ozU2d1Q0FtanBYYjVUM2dza1dtV256cjBhNGNlaTJzeE4vZmZpUW10?=
 =?utf-8?B?ZWJyc0lIdmkwbVZDaE9tcmN0YXFMVW1LNGFKbHY4RDloaWVuUS9xTzJ4S0dL?=
 =?utf-8?B?YzZ0dGtvWUw2RGg0cFN5K0tCVzEzQmR6U2M4SWtMQVNPTk1sZXNTdzNCWmZJ?=
 =?utf-8?B?TkQweUExWVh0b3N6WHA3NEdQOVBGZ0pFREN6MXZoWUJadTJCS3p5Y1gra3pz?=
 =?utf-8?B?TUl6ZVM0aEw5WVJiYUUyS052bk8yTDVQWkFSbENSS1o2WnZnbDVsbStqY1Q0?=
 =?utf-8?B?RjZ4VkE3YzN3VHRDSG1vbGRnckpNUWRhamRrVC9KVjZxaUhVYjRHNlpKSmJR?=
 =?utf-8?B?eXkvWWNKTExpQzhmZHFCNDlkckViYjBvUXFyRmdiZFY3V2xaZFQ0Mm5GNmhI?=
 =?utf-8?B?d3ZxcGxTUThocVAybU9EZ3NITDMwWUNZK3lXdjEzSnpsTWZTMndsR1Nnckh4?=
 =?utf-8?B?VWFVRHhSa3Bpd1BYSWJ4QzNvZEl5OUh0eE9IWnY3MDg2aFk3VU9NREw4M1Uw?=
 =?utf-8?B?WW5KbjFJbDNCMFVpelllcjVXRVU0UDg5SC9XbElZY0VzbjBob0NreFhQTzBJ?=
 =?utf-8?B?Rk04WSs5NVFIVEl0VmRMbkpGUkdiUXhWcWJhVHByWEI0L1ZkNndUTnNobURQ?=
 =?utf-8?B?YThSb3c0T0FLaFEyM2w3b3dxK1I2aUQzZVlRdzZITE5zTTlyakN5a2Z1b2Nm?=
 =?utf-8?B?cEpaenFRbitIeDRMZmtFaDdFUHM5ZjRER0FBL1JBSzZZd0IzckEyQlBHTTVF?=
 =?utf-8?B?TkduenUxMWFtTjRDUlRqSnprT1J5MkNKVlB1SGowWFVEcG5aZzZDbWVwWjE3?=
 =?utf-8?B?bk9xeEViUkMvZ0tWUEpBUWgwemswVzlDVmtEUnR1Vjk2Zzl4NmthYjVKdU9L?=
 =?utf-8?B?Yi9SR3VCZzNueVlydXQxZHBmWnh6b3dIaURwVGE2VEsycDV4bWMyTnNLbHZx?=
 =?utf-8?B?YUhGYkpPQk5MS0FwYVk4cGhxSldLSlBXQ2NNWG8xbkQ1cHV4NWpVVFBWd0ZF?=
 =?utf-8?B?ZWw4WlZ5RkU4eVFHcDFpU0hNWm9jcmhITTRTUVhkUDJST1gwN0hLZUVlMWM1?=
 =?utf-8?B?bVM4SmZieXRNRzJrRDE3WHIxK0FOSU5qdHJ5TytlODlPcUVLT2pLNmJ3Qksw?=
 =?utf-8?B?N0xPWjRWVE9hMldxNHpFbHFXK2FhVTR6YVFmeHVTOVVBd2UrOGpwRi9STU5n?=
 =?utf-8?B?aUsxZFg4REZDKzVaY0VQaVNYT0NnSmRGUDFSUWI2ZnlnWFhybk1WcUU2SFZE?=
 =?utf-8?B?N3VvdGlCTm9xMzEyd0VaREpZUW0yTm9WYjhWZCttUWxiWEFWVjNpSXhyTTkx?=
 =?utf-8?B?M0NTMFU2NU50eERDSnd0UmNJajRWWDFpOHUramJJdFplc20remZSeVVUcEg2?=
 =?utf-8?B?Q2hMNFlHYWM3aXE4RDZRdE0zTE1XQWxtMnhpSVpuQ0pCcTJ4Ti96TzF2bTVo?=
 =?utf-8?B?K2JubFAvdWZ1QnFxanp4cjdpRE5jSFlwNi80a21zcmRxM1lveHBEbnBLWXov?=
 =?utf-8?B?cFk4dk1BRU1BTXNvMW1aUGhLbWRBTFFzSm5hazBRdjdSNHZiZUExODRKNzBw?=
 =?utf-8?B?MytlMlVWR0k5em8xdmZkbmxOM3ZWa0d5NTREaVZnZkJxaVdzd05VaXVsQ2Nu?=
 =?utf-8?B?dlhRRWgySW9WaFJkRGNQVjk3WW5QbW5kaDZ3K2NOMmlRR2hBeGxmc2FwcXdZ?=
 =?utf-8?B?ZE9NVHAzUytIbjJSdWtqS1pzS3BPY0g2cmlQODFYUXdlVUcyQ01ieHBJRWt0?=
 =?utf-8?B?MVJzU0p5dmtUclB4VXp4Y3hhOE45Q3dpWkhDMkpHNkI5T2QrdVRZUmZZM2ho?=
 =?utf-8?B?WWN4U216clpiUWsrNzN1TlAvWnJGMmQrTER5SU5uaW53cGtYY0RhMjhPSGhY?=
 =?utf-8?Q?3fEaZTNBe8RFuSGcamoPhLtMG?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d4385fd4-119e-4e84-aca8-08dae3ba7954
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4820.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Dec 2022 01:18:46.8173
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: X1hHdaguRhhT+Di4XNyKDSHGX3cTeFmphCLuutUiXu2Wz05vbb20Vh/oZYh/Sqwf6hj/3vs3BDTGIc3nvmxJJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB7303
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-8.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/22/2022 12:45 AM, Yang Shi wrote:
>> We caught two mmap1 regressions on mailine, please see the data below:
>>
>> 830b3c68c1fb1 Linux 6.1                                                              2085 2355 2088
>> 76dcd734eca23 Linux 6.1-rc8                                                          2093 2082 2094 2073 2304 2088
>> 0ba09b1733878 Revert "mm: align larger anonymous mappings on THP boundaries"         2124 2286 2086 2114 2065 2081
>> 23393c6461422 char: tpm: Protect tpm_pm_suspend with locks                           2756 2711 2689 2696 2660 2665
>> b7b275e60bcd5 Linux 6.1-rc7                                                          2670 2656 2720 2691 2667
>> ...
>> 9abf2313adc1c Linux 6.1-rc1                                                          2725 2717 2690 2691 2710
>> 3b0e81a1cdc9a mmap: change zeroing of maple tree in __vma_adjust()                   2736 2781 2748
>> 524e00b36e8c5 mm: remove rb tree.                                                    2747 2744 2747
>> 0c563f1480435 proc: remove VMA rbtree use from nommu
>> d0cf3dd47f0d5 damon: convert __damon_va_three_regions to use the VMA iterator
>> 3499a13168da6 mm/mmap: use maple tree for unmapped_area{_topdown}
>> 7fdbd37da5c6f mm/mmap: use the maple tree for find_vma_prev() instead of the rbtree
>> f39af05949a42 mm: add VMA iterator
>> d4af56c5c7c67 mm: start tracking VMAs with maple tree
>> e15e06a839232 lib/test_maple_tree: add testing for maple tree                        4638 4628 4502
>> 9832fb87834e2 mm/demotion: expose memory tier details via sysfs                      4625 4509 4548
>> 4fe89d07dcc28 Linux 6.0                                                              4385 4205 4348 4228 4504
>>
>>
>> The first regression was between v6.0 and v6.1-rc1. The score dropped
>> from 4600 to 2700, and bisected to the patches switching from rb tree to
>> maple tree. This was reported at
>> https://lore.kernel.org/oe-lkp/202212191714.524e00b3-yujie.liu@intel.com/
>> Thanks for the explanation that it is an expected regression as a trade
>> off to benefit read performance.
>>
>> The second regression was between v6.1-rc7 and v6.1-rc8. The score
>> dropped from 2700 to 2100, and bisected to this "Revert "mm: align larger
>> anonymous mappings on THP boundaries"" commit.
> So it means "mm: align larger anonymous mappings on THP boundaries"
> actually improved the mmap1 benchmark? But it caused regression for
> other usecase, for example, building kernel with clang, which is a
> regression for a real life usecase.
Yes. The patch "mm: align larger anonymous mappings on THP boundaries"
can improve the mmap1 benchmark.

For building kernel regression, looks like it's not related with the
patch "mm: align larger anonymous mappings on THP boundaries" directly.
It's another existing behavior more visible with the patch.
https://lore.kernel.org/all/a4bcddad-e56f-cedc-891a-916e86d9a02c@intel.com/


Regards
Yin, Fengwei

>